coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6692 discussions

Change in coreboot[master]: mb/google/brya/vell: Enable USB2 port for KBD MCU
by Daisuke Nojiri (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Felix Singer. Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62505 ) Change subject: mb/google/brya/vell: Enable USB2 port for KBD MCU ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62505/comment/cca4f240_eb738cde PS1, Line 7: Vell: Enable USB2 port for KBD MCU > mb/google/brya/vell: Enable USB2 port for KBD MCU Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087 Gerrit-Change-Number: 62505 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 03 Mar 2022 20:29:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/vell: Enable USB2 port for KBD MCU
by Daisuke Nojiri (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Daisuke Nojiri. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62505 to look at the new patch set (#2). Change subject: mb/google/brya/vell: Enable USB2 port for KBD MCU ...................................................................... mb/google/brya/vell: Enable USB2 port for KBD MCU Vell has a keyboard MCU connected to USB2 port 7. This patch enables the port. localhost# usb_updater2 -f Found device. found interface 0 endpoint 1, chunk_len 64 READY ------- start target running protocol version 6 (type 1) maximum PDU size: 4096 Flash protection status: 0000 version: prism_v2.0.12137+c4ae1432f5 key_version: 1 min_rollback: 0 offset: writable at 0xc000 Current versions: Writable prism_v2.0.12137+c4ae1432f5 BUG=b:203664745,b:211496726 TEST=Run 'usb_updater2 -f' on Vell. Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/mainboard/google/brya/variants/vell/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/62505/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087 Gerrit-Change-Number: 62505 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork
by Sean Rhodes (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Name of user not set #1004172. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62418 ) Change subject: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: I'd personally prefer to not encourage using forks; the build options wont match up, the patches aren't properlly reviewed and everything should (ideally) live in upstream. Most of the patches in the 9elements branch have been or are being upstreamed anyway. You can always just set TIANOCORE_REPOSITORY and TIANOCORE_TAG_OR_REV locally to use a fork. -- To view, visit https://review.coreboot.org/c/coreboot/+/62418 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I932ebe03f9162c29109a3ea54133fa8ff5f28bad Gerrit-Change-Number: 62418 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1004172 Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Name of user not set #1004172 Gerrit-Comment-Date: Thu, 03 Mar 2022 20:15:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and ...
by Tim Wawrzynczak (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 ) Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix ...................................................................... Patch Set 12: (1 comment) File src/mainboard/google/brya/mainboard.c: https://review.coreboot.org/c/coreboot/+/61887/comment/6788b673_2ddfa92e PS12, Line 71: cpi_device_path_join(parent, "RTD3._STA") I think this could be `acpi_device_path_join(config->rtd3dev, "_STA")` -- To view, visit https://review.coreboot.org/c/coreboot/+/61887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9 Gerrit-Change-Number: 61887 Gerrit-PatchSet: 12 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 20:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork
by Name of user not set (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer. Name of user not set #1004172 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62418 ) Change subject: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62418/comment/bda6a16c_c92d408e PS1, Line 7: payloads/tianocore Makefile: Kconfig: Add option to build 9elements's UefiPayloadPkg fork > payload/tianocore: Add option to build 9elements’ UefiPayloadPkg fork Done https://review.coreboot.org/c/coreboot/+/62418/comment/2cfd2937_5e032d14 PS1, Line 9: Signed-off-by: Ratatouilledummie <ratatouillemorde(a)gmail.com> > Please put that at the end. Done Patchset: PS3: commit issues done -- To view, visit https://review.coreboot.org/c/coreboot/+/62418 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I932ebe03f9162c29109a3ea54133fa8ff5f28bad Gerrit-Change-Number: 62418 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1004172 Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 19:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alder lake: Send EOP early in the boot sequence
by Tim Wawrzynczak (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Sridhar Siricilla. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 ) Change subject: soc/intel/alder lake: Send EOP early in the boot sequence ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62272/comment/47754ae1_a3423bfd PS5, Line 7: alder lake `adl` -- To view, visit https://review.coreboot.org/c/coreboot/+/62272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9401d5e36ad43cdc0dfe947aabc82528d824df9b Gerrit-Change-Number: 62272 Gerrit-PatchSet: 5 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 19:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Vell: Enable USB2 port for KBD MCU
by Felix Singer (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Daisuke Nojiri. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62505 ) Change subject: Vell: Enable USB2 port for KBD MCU ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62505/comment/f5b91a2c_c4fd6efc PS1, Line 7: Vell: Enable USB2 port for KBD MCU mb/google/brya/vell: Enable USB2 port for KBD MCU -- To view, visit https://review.coreboot.org/c/coreboot/+/62505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087 Gerrit-Change-Number: 62505 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 19:12:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton Soc
by Jeff Daly (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Mariusz Szafrański, Paul Menzel, Stefan Reinauer, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michael Niewöhner, Michal Motyl, Kyösti Mälkki, Patrick Rudolph. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60830 ) Change subject: util/ifdtool: Add support for Denverton Soc ...................................................................... Patch Set 14: (1 comment) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/60830/comment/91cd11f7_c6095c9a PS13, Line 718: has_gbe_region = (platform != PLATFORM_DNV); : has_ec_region = (ifd_version >= IFD_VERSION_2) && (platform != PLATFORM_DNV); : has_10gbe_0_region = (platform == PLATFORM_DNV); : has_10gbe_1_region = (platform == PLATFORM_DNV); > will rework this into a function/macro for next time. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15939ce4672123f39a807d63c13ba7df98c57523 Gerrit-Change-Number: 60830 Gerrit-PatchSet: 14 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 19:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jeff Daly <jeffd(a)silicom-usa.com> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/chausie/devicetree: enable GFX HDA, ACP and XHCI2 devices
by Felix Held (Code Review) 03 Mar '22

03 Mar '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62571 ) Change subject: mb/amd/chausie/devicetree: enable GFX HDA, ACP and XHCI2 devices ...................................................................... mb/amd/chausie/devicetree: enable GFX HDA, ACP and XHCI2 devices GFX HDA is the audio controller that provides audio output via the external display connection, ACP is the audio coporcessor for the on- board audio codec and XHCI2 is the third XHCI controller that provides one USB 2.0 port. All those devices are used, so enable them in the board's devicetree. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I186797a832470eb17752e06aa2fcc0b5c9db0398 --- M src/mainboard/amd/chausie/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/62571/1 diff --git a/src/mainboard/amd/chausie/devicetree.cb b/src/mainboard/amd/chausie/devicetree.cb index 1d4d9da..fa4555e 100644 --- a/src/mainboard/amd/chausie/devicetree.cb +++ b/src/mainboard/amd/chausie/devicetree.cb @@ -36,6 +36,7 @@ device ref gpp_bridge_5 on end device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref gfx on end # Internal GPU (GFX) + device ref gfx_hda on end # Display HD Audio Controller (GFXAZ) device ref crypto on end # Crypto Coprocessor device ref xhci_0 on # USB 3.1 (USB0) chip drivers/usb/acpi @@ -73,6 +74,10 @@ end end end + device ref acp on end # Audio Processor (ACP) + end + device ref gpp_bridge_c on # Internal GPP Bridge 2 to Bus C + device ref xhci_2 on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/62571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I186797a832470eb17752e06aa2fcc0b5c9db0398 Gerrit-Change-Number: 62571 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Vell: Enable USB2 port for KBD MCU
by Tim Wawrzynczak (Code Review) 03 Mar '22

03 Mar '22

Attention is currently required from: Daisuke Nojiri. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62505 ) Change subject: Vell: Enable USB2 port for KBD MCU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087 Gerrit-Change-Number: 62505 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 18:58:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022