Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62435 )
Change subject: drivers/{pcie,wifi}/generic: Update untrusted property name
......................................................................
drivers/{pcie,wifi}/generic: Update untrusted property name
In order to align with established standards for establishing DMA
boundaries[1] from ACPI, the UntrustedDevice property has been renamed
to DmaProperty, which follows Microsoft's implementation. After
discussions with Microsoft, they have agreed to make the `UID` property
optional, so it is left out here, and instead it can be applied to:
1) Internal PCI devices
2) PCIe root ports
3) Downstream PCI(e) devices
[1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-…
BUG=b:215424986
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: Id70e916532e3d3d70305fc61473da28c702fc397
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62435
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
---
M src/drivers/pcie/generic/Kconfig
M src/drivers/pcie/generic/generic.c
M src/drivers/wifi/generic/acpi.c
M src/drivers/wifi/generic/chip.h
4 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
build bot (Jenkins): Verified
EricR Lai: Looks good to me, approved
diff --git a/src/drivers/pcie/generic/Kconfig b/src/drivers/pcie/generic/Kconfig
index 2a68708..f41f37d 100644
--- a/src/drivers/pcie/generic/Kconfig
+++ b/src/drivers/pcie/generic/Kconfig
@@ -5,7 +5,6 @@
help
This driver allows attaching arbitrary ACPI properties to
arbitrary PCI root ports or devices. Currently it supports one
- property, "UntrustedDevice". This property indicates to the
- operating system that the PCIe device may be considered
- untrusted, and appropriate policies, e.g. IOMMU isolation,
- should take place.
+ property, "DmaProperty", which indicates to the operating system that
+ the PCIe device may be considered untrusted, and appropriate policies,
+ e.g. IOMMU isolation, should take place.
diff --git a/src/drivers/pcie/generic/generic.c b/src/drivers/pcie/generic/generic.c
index 2daebda..c14628f 100644
--- a/src/drivers/pcie/generic/generic.c
+++ b/src/drivers/pcie/generic/generic.c
@@ -34,7 +34,7 @@
acpigen_write_ADR_pci_device(dev);
dsd = acpi_dp_new_table("_DSD");
- acpi_dp_add_integer(dsd, "UntrustedDevice", 1);
+ acpi_dp_add_integer(dsd, "DmaProperty", 1);
acpi_dp_write(dsd);
acpigen_write_device_end();
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c
index 7c606f9..16c1839 100644
--- a/src/drivers/wifi/generic/acpi.c
+++ b/src/drivers/wifi/generic/acpi.c
@@ -515,13 +515,13 @@
/* Wake capabilities */
acpigen_write_PRW(config->wake, ACPI_S3);
- /* Add _DSD for UntrustedDevice property. */
+ /* Add _DSD for DmaProperty property. */
if (config->is_untrusted) {
struct acpi_dp *dsd, *pkg;
dsd = acpi_dp_new_table("_DSD");
pkg = acpi_dp_new_table(ACPI_DSD_UNTRUSTED_UUID);
- acpi_dp_add_integer(pkg, "UntrustedDevice", 1);
+ acpi_dp_add_integer(pkg, "DmaProperty", 1);
acpi_dp_add_package(dsd, pkg);
acpi_dp_write(dsd);
}
diff --git a/src/drivers/wifi/generic/chip.h b/src/drivers/wifi/generic/chip.h
index 35726f2..907b260 100644
--- a/src/drivers/wifi/generic/chip.h
+++ b/src/drivers/wifi/generic/chip.h
@@ -10,7 +10,7 @@
struct drivers_wifi_generic_config {
unsigned int wake;
/* When set to true, this will add a _DSD which contains a single
- property, `UntrustedDevice`, set to 1, to the ACPI Device. */
+ property, `DmaProperty`, set to 1, under the ACPI Device. */
bool is_untrusted;
};
--
To view, visit https://review.coreboot.org/c/coreboot/+/62435
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id70e916532e3d3d70305fc61473da28c702fc397
Gerrit-Change-Number: 62435
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Marx Wang, Chen Wisley.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62564 )
Change subject: mb/google/brya/var/redrix{4es}: Correct the unused USB2/TCSS port
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62564/comment/1d05e075_96cfcac2
PS1, Line 8:
So I think this is due to
`commit 03c0853f4d58c73`
could you add that here, e.g.
```
Commit 03c0853f4d58c73 accidentally set the Bluetooth USB2 port
to "empty", therefore re-enable USB2 port 9.
```
https://review.coreboot.org/c/coreboot/+/62564/comment/ce06f150_a36c9f82
PS1, Line 12: 2. disable TCSS PCIe port1
Since this is separate from fixing the "broken" commit, I think this should go in a separate commit
--
To view, visit https://review.coreboot.org/c/coreboot/+/62564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie94ef847fc130019f1e06983fc5039f1f564cd3a
Gerrit-Change-Number: 62564
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.com>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:44:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62565 )
Change subject: Revert "mb/google/brya/var/taeko: Fix PLD group order (W/A)"
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62565/comment/bc44fdf2_a8682cc3
PS1, Line 10:
: This issue fix by OS that revert core boot work around.
:
suggestion:
```
This issue was fixed in the OS, therefore the workaround can be
reverted.
```
https://review.coreboot.org/c/coreboot/+/62565/comment/d857bb5d_d100afa1
PS1, Line 14: none
`firmware-brya-14505.B`
--
To view, visit https://review.coreboot.org/c/coreboot/+/62565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic836e0cf53c2f9d30bd12851be285d864b2256b8
Gerrit-Change-Number: 62565
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Zoey Wu, Zhuohao Lee, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62478 )
Change subject: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab153f16a3b729e7fa9daaa3dbfbccc70e6d789d
Gerrit-Change-Number: 62478
Gerrit-PatchSet: 5
Gerrit-Owner: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com>
Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:37:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62505 )
Change subject: mb/google/brya/vell: Enable USB2 port for KBD MCU
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62505/comment/cca4f240_eb738cde
PS1, Line 7: Vell: Enable USB2 port for KBD MCU
> mb/google/brya/vell: Enable USB2 port for KBD MCU
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62505
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087
Gerrit-Change-Number: 62505
Gerrit-PatchSet: 2
Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Daisuke Nojiri.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62505
to look at the new patch set (#2).
Change subject: mb/google/brya/vell: Enable USB2 port for KBD MCU
......................................................................
mb/google/brya/vell: Enable USB2 port for KBD MCU
Vell has a keyboard MCU connected to USB2 port 7. This patch enables
the port.
localhost# usb_updater2 -f
Found device.
found interface 0 endpoint 1, chunk_len 64
READY
-------
start
target running protocol version 6 (type 1)
maximum PDU size: 4096
Flash protection status: 0000
version: prism_v2.0.12137+c4ae1432f5
key_version: 1
min_rollback: 0
offset: writable at 0xc000
Current versions:
Writable prism_v2.0.12137+c4ae1432f5
BUG=b:203664745,b:211496726
TEST=Run 'usb_updater2 -f' on Vell.
Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087
Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org>
---
M src/mainboard/google/brya/variants/vell/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/62505/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62505
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad2140dbdf5e34332388f3f43b3ede3d22e73087
Gerrit-Change-Number: 62505
Gerrit-PatchSet: 2
Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Name of user not set #1004172.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62418 )
Change subject: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS3:
I'd personally prefer to not encourage using forks; the build options wont match up, the patches aren't properlly reviewed and everything should (ideally) live in upstream.
Most of the patches in the 9elements branch have been or are being upstreamed anyway.
You can always just set TIANOCORE_REPOSITORY and TIANOCORE_TAG_OR_REV locally to use a fork.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62418
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932ebe03f9162c29109a3ea54133fa8ff5f28bad
Gerrit-Change-Number: 62418
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1004172
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Name of user not set #1004172
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 )
Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61887/comment/6788b673_2ddfa92e
PS12, Line 71: cpi_device_path_join(parent, "RTD3._STA")
I think this could be
`acpi_device_path_join(config->rtd3dev, "_STA")`
--
To view, visit https://review.coreboot.org/c/coreboot/+/61887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9
Gerrit-Change-Number: 61887
Gerrit-PatchSet: 12
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 20:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer.
Name of user not set #1004172 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62418 )
Change subject: payload/tianocore: Add option to build 9elements's UefiPayloadPkg fork
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62418/comment/bda6a16c_c92d408e
PS1, Line 7: payloads/tianocore Makefile: Kconfig: Add option to build 9elements's UefiPayloadPkg fork
> payload/tianocore: Add option to build 9elements’ UefiPayloadPkg fork
Done
https://review.coreboot.org/c/coreboot/+/62418/comment/2cfd2937_5e032d14
PS1, Line 9: Signed-off-by: Ratatouilledummie <ratatouillemorde(a)gmail.com>
> Please put that at the end.
Done
Patchset:
PS3:
commit issues done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62418
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932ebe03f9162c29109a3ea54133fa8ff5f28bad
Gerrit-Change-Number: 62418
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1004172
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 19:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment