Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
Patch Set 1:
(4 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/6d25dff8_e706d607
PS1, Line 1591: uintptr_t coreboot_rsdp;
> um, static?
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/8fec3a8e_cae1ff15
PS1, Line 586: uint64_t
> Usually `lb_uint64` and no `__packed`. I don't like either way actually […]
Done
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/7ef95564_1b3c54d3
PS1, Line 57: uintptr_t get_coreboot_rsdp(void);
> Maybe don't mix this with #defines, or add some blank lines. Looks a bit […]
Done
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/ccc8d7a0_7d9282a7
PS1, Line 537: lb_add_acpi_rsdp(head);
> I guess this will need something like `if (CONFIG(ACPI))`.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Nico Huber, Tim Wawrzynczak, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62573
to look at the new patch set (#2).
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
coreboot_tables.c: Expose the ACPI RSDP
The ACPI RSDP can only be found in:
- legacy BIOS region
- via UEFI service
On some systems like ARM that legacy BIOS region is not an option, so
to avoid needing UEFI it makes sense to expose the RSDP via a coreboot
table entry.
Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/acpi/acpi.c
M src/commonlib/include/commonlib/coreboot_tables.h
M src/include/acpi/acpi.h
M src/lib/coreboot_table.c
4 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/62573/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File util/cbfstool/linux_trampoline.S:
https://review.coreboot.org/c/coreboot/+/62574/comment/540872bb_b512770e
PS2, Line 97: ACPI_RSDP_ADDR
Was this location unused in earlier zero page versions? i.e. no
version check needed?
https://review.coreboot.org/c/coreboot/+/62574/comment/fb174a22_9a1b863a
PS2, Line 100:
`jmp .endScan` I guess? This is a path where we know the next `cmp` will
fail, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/84d872a9_63b9619d
PS1, Line 586: uint64_t
Usually `lb_uint64` and no `__packed`. I don't like either way actually
(proper (de)serialization can spare us bug hunting).
--
To view, visit https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 )
Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix
......................................................................
Patch Set 12: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61887/comment/b1110283_2696c4bf
PS12, Line 24: MPST
`MPTS`
Patchset:
PS12:
Thanks Cliff! 😊
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61887/comment/c4ff0bc4_0149d4db
PS12, Line 71: cpi_device_path_join(parent, "RTD3._STA")
> The returned rtd3 dev path is with PXSX instead: […]
Oh yes you're right the RTD3 name is implicit... oh well, this is mainboard code, so we are more free to make assumptions if we must...
--
To view, visit https://review.coreboot.org/c/coreboot/+/61887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9
Gerrit-Change-Number: 61887
Gerrit-PatchSet: 12
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/5441552a_eeced963
PS1, Line 1591: uintptr_t coreboot_rsdp;
um, static?
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/c4757c80_3535bbc6
PS1, Line 57: uintptr_t get_coreboot_rsdp(void);
Maybe don't mix this with #defines, or add some blank lines. Looks a bit
odd this way.
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/4d16e669_b8145bd9
PS1, Line 537: lb_add_acpi_rsdp(head);
I guess this will need something like `if (CONFIG(ACPI))`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:58:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62575 )
Change subject: payloads/seabios: Update stable version to 1.16.0
......................................................................
payloads/seabios: Update stable version to 1.16.0
SeaBIOS 1.16.0 was released on March 2nd. Thus, update the stable
version from 1.14.0 to 1.16.0.
Change-Id: I475a9be47171bfbe3b3c2d4d1d14bb753d8575a8
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/SeaBIOS/Kconfig
M payloads/external/SeaBIOS/Makefile
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/62575/1
diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index 9aea2d0..d7dd165 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -5,7 +5,7 @@
default SEABIOS_STABLE
config SEABIOS_STABLE
- bool "1.14.0"
+ bool "1.16.0"
help
Stable SeaBIOS version
config SEABIOS_MASTER
diff --git a/payloads/external/SeaBIOS/Makefile b/payloads/external/SeaBIOS/Makefile
index cdcd426..502f4ea 100644
--- a/payloads/external/SeaBIOS/Makefile
+++ b/payloads/external/SeaBIOS/Makefile
@@ -1,5 +1,5 @@
TAG-$(CONFIG_SEABIOS_MASTER)=origin/master
-TAG-$(CONFIG_SEABIOS_STABLE)=155821a1990b6de78dde5f98fa5ab90e802021e0
+TAG-$(CONFIG_SEABIOS_STABLE)=d239552ce7220e448ae81f41515138f7b9e3c4db
TAG-$(CONFIG_SEABIOS_REVISION)=$(CONFIG_SEABIOS_REVISION_ID)
project_git_repo=https://review.coreboot.org/seabios.git
--
To view, visit https://review.coreboot.org/c/coreboot/+/62575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I475a9be47171bfbe3b3c2d4d1d14bb753d8575a8
Gerrit-Change-Number: 62575
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newchange
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Paul Menzel.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 )
Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61887/comment/19690f66_cb865f6c
PS12, Line 71: cpi_device_path_join(parent, "RTD3._STA")
> I think this could be […]
The returned rtd3 dev path is with PXSX instead:
static const char *pcie_rtd3_acpi_name(const struct device *dev)
{
/* Attached device name must be "PXSX" for the Linux Kernel to recognize it. */
return "PXSX";
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/61887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9
Gerrit-Change-Number: 61887
Gerrit-PatchSet: 12
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Rizwan Qureshi, Tim Wawrzynczak, Krishna P Bhat D, Balaji Manigandan.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62570 )
Change subject: mb/google/nissa: Select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW Kconfig
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/62570/comment/89a5ab79_14f26055
PS1, Line 67: select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW
Please move this up by one to keep them in alphabetical order.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib27149c527015bd54f839994e047f815e8922dc4
Gerrit-Change-Number: 62570
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment