Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 )
Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix
......................................................................
Patch Set 12: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61887/comment/b1110283_2696c4bf
PS12, Line 24: MPST
`MPTS`
Patchset:
PS12:
Thanks Cliff! 😊
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/61887/comment/c4ff0bc4_0149d4db
PS12, Line 71: cpi_device_path_join(parent, "RTD3._STA")
The returned rtd3 dev path is with PXSX instead: […]
Oh yes you're right the RTD3 name is implicit... oh well, this is mainboard code, so we are more free to make assumptions if we must...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9
Gerrit-Change-Number: 61887
Gerrit-PatchSet: 12
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment