Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/5441552a_eeced963 PS1, Line 1591: uintptr_t coreboot_rsdp; um, static?
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/c4757c80_3535bbc6 PS1, Line 57: uintptr_t get_coreboot_rsdp(void); Maybe don't mix this with #defines, or add some blank lines. Looks a bit odd this way.
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/4d16e669_b8145bd9 PS1, Line 537: lb_add_acpi_rsdp(head); I guess this will need something like `if (CONFIG(ACPI))`.