Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.

Patch set 1:Code-Review +1

View Change

3 comments:

• File src/acpi/acpi.c:

  • Patch Set #1, Line 1591: uintptr_t coreboot_rsdp;

    um, static?

• File src/include/acpi/acpi.h:

  • Patch Set #1, Line 57: uintptr_t get_coreboot_rsdp(void);

    Maybe don't mix this with #defines, or add some blank lines. Looks a bit
    odd this way.

• File src/lib/coreboot_table.c:

  • Patch Set #1, Line 537: lb_add_acpi_rsdp(head);

    I guess this will need something like `if (CONFIG(ACPI))`.

To view, visit change 62573. To unsubscribe, or for help writing mail filters, visit settings.