Change in coreboot[master]: coreboot_tables.c: Expose the ACPI RSDP

Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 ) Change subject: coreboot_tables.c: Expose the ACPI RSDP ...................................................................... Patch Set 1: (4 comments) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/62573/comment/6d25dff8_e706d607 PS1, Line 1591: uintptr_t coreboot_rsdp;
um, static? Done
File src/commonlib/include/commonlib/coreboot_tables.h: https://review.coreboot.org/c/coreboot/+/62573/comment/8fec3a8e_cae1ff15 PS1, Line 586: uint64_t
Usually `lb_uint64` and no `__packed`. I don't like either way actually […] Done
File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/62573/comment/7ef95564_1b3c54d3 PS1, Line 57: uintptr_t get_coreboot_rsdp(void);
Maybe don't mix this with #defines, or add some blank lines. Looks a bit […] Done
File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/62573/comment/ccc8d7a0_7d9282a7 PS1, Line 537: lb_add_acpi_rsdp(head);
I guess this will need something like `if (CONFIG(ACPI))`. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/62573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff Gerrit-Change-Number: 62573 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Lance Zhao Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Comment-Date: Thu, 03 Mar 2022 22:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment
participants (1)
-
Arthur Heymans (Code Review)