Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak.
4 comments:
File src/acpi/acpi.c:
Patch Set #1, Line 1591: uintptr_t coreboot_rsdp;
um, static?
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
Patch Set #1, Line 586: uint64_t
Usually `lb_uint64` and no `__packed`. I don't like either way actually […]
Done
File src/include/acpi/acpi.h:
Patch Set #1, Line 57: uintptr_t get_coreboot_rsdp(void);
Maybe don't mix this with #defines, or add some blank lines. Looks a bit […]
Done
File src/lib/coreboot_table.c:
Patch Set #1, Line 537: lb_add_acpi_rsdp(head);
I guess this will need something like `if (CONFIG(ACPI))`.
Done
To view, visit change 62573. To unsubscribe, or for help writing mail filters, visit settings.