March 2022 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: Documentation: Fix spelling of "QEMU"
by Matt DeVillier (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: Felix Singer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62450 ) Change subject: Documentation: Fix spelling of "QEMU" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a88985ce3a7c59b732c1ca3198d86a591de6bd Gerrit-Change-Number: 62450 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mainboard: Add Supermicro X9SAE to index site
by Matt DeVillier (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: Felix Singer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62449 ) Change subject: Documentation/mainboard: Add Supermicro X9SAE to index site ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3d0b5b935f1a3ea353a3d9e39208db7c7895ef Gerrit-Change-Number: 62449 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Fix spelling of "Supermicro"
by Matt DeVillier (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: Felix Singer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62448 ) Change subject: Documentation: Fix spelling of "Supermicro" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id630d9d130082fb38f9151e0dfb6f6fbb5a2789d Gerrit-Change-Number: 62448 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:27:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mainboard: Add QEMU POWER9 to index site
by Felix Singer (Code Review) March 1, 2022

March 1, 2022

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62451 ) Change subject: Documentation/mainboard: Add QEMU POWER9 to index site ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3b98735840c146cb0bfb122df0e6f762c2beeca Gerrit-Change-Number: 62451 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:22:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Fix spelling of "QEMU"
by Felix Singer (Code Review) March 1, 2022

March 1, 2022

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62450 ) Change subject: Documentation: Fix spelling of "QEMU" ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a88985ce3a7c59b732c1ca3198d86a591de6bd Gerrit-Change-Number: 62450 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mainboard: Add Supermicro X9SAE to index site
by Felix Singer (Code Review) March 1, 2022

March 1, 2022

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62449 ) Change subject: Documentation/mainboard: Add Supermicro X9SAE to index site ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3d0b5b935f1a3ea353a3d9e39208db7c7895ef Gerrit-Change-Number: 62449 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Fix spelling of "Supermicro"
by Felix Singer (Code Review) March 1, 2022

March 1, 2022

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62448 ) Change subject: Documentation: Fix spelling of "Supermicro" ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id630d9d130082fb38f9151e0dfb6f6fbb5a2789d Gerrit-Change-Number: 62448 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 01 Mar 2022 01:19:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Change ELAN touchpanel driver
by Shon Wang (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: YH Lin, Paul Menzel, Nick Vaccaro, Robert Chen. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62317 ) Change subject: mb/google/brya/var/vell: Change ELAN touchpanel driver ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62317/comment/69169075_78237e62 PS5, Line 8: : Due BIOS setting not correct > Due to incorrect BIOS setting Done https://review.coreboot.org/c/coreboot/+/62317/comment/a9ec61b6_853aa306 PS5, Line 9: can's > nit: looks to be typo. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f04fa21b542e21e88c46547779cfb55beb5c12 Gerrit-Change-Number: 62317 Gerrit-PatchSet: 6 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <coreboot.test(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 00:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Change ELAN touchpanel driver
by Shon Wang (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: Paul Menzel, Nick Vaccaro, Robert Chen, Shon Wang. Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62317 to look at the new patch set (#6). Change subject: mb/google/brya/var/vell: Change ELAN touchpanel driver ...................................................................... mb/google/brya/var/vell: Change ELAN touchpanel driver Due to incorrect BIOS setting, touch screen IC FW can't update and work according to ELAN's recommendations, we change to ELAN2513 driver it's workable and can flash touch screen FW change ELAN2513 driver and I2C address to 0x10 BUG=b:221340736 Change-Id: I22f04fa21b542e21e88c46547779cfb55beb5c12 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/vell/overridetree.cb 1 file changed, 9 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/62317/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/62317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f04fa21b542e21e88c46547779cfb55beb5c12 Gerrit-Change-Number: 62317 Gerrit-PatchSet: 6 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <coreboot.test(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "util/cbfstool: Port elogtool to libflashrom"
by ron minnich (Code Review) March 1, 2022

March 1, 2022

Attention is currently required from: Martin Roth. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62404 ) Change subject: Revert "util/cbfstool: Port elogtool to libflashrom" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I'm the one who forwarded the reports on this to Martin. Basically, on friday feb 25, we were unable to find a single upstream distro on which this would build. We had 5 engineers from 3 companies trying to see if anybody had any new distro on which this would build; none worked. It's unlikely you want to ship in this state. The problem is that even on the newest distros we tried (various ubuntu 20, popos, etc.) the libflashrom-dev is missing a prototype, so you get this error: /home/rminnich/AMD64/coreboot/util/cbfstool/uflashrom.c:113:3: error: implicit declaration of function ‘flashrom_layout_get_region_range’ [-Werror=implicit-function-declaration] 113 | flashrom_layout_get_region_range(layout, region, &r_start, &r_len); This is going to hit every person who tries to build cbfstool from source. There doesn't seem to be a great workaround at present. -- To view, visit https://review.coreboot.org/c/coreboot/+/62404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I572daa0c0f3998e20a8ed76df21228fdbb384baf Gerrit-Change-Number: 62404 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 00:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0