Change in coreboot[master]: Revert "util/cbfstool: Port elogtool to libflashrom"

[ron minnich (Code Review)]

Attention is currently required from: Martin Roth.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62404 )

Change subject: Revert "util/cbfstool: Port elogtool to libflashrom"
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
I'm the one who forwarded the reports on this to Martin. Basically, on friday feb 25, we were unable to find a single upstream distro on which this would build. We had 5 engineers from 3 companies trying to see if anybody had any new distro on which this would build; none worked.

It's unlikely you want to ship in this state.

The problem is that even on the newest distros we tried (various ubuntu 20, popos, etc.) the libflashrom-dev is missing a prototype, so you get this error:
/home/rminnich/AMD64/coreboot/util/cbfstool/uflashrom.c:113:3: error: implicit declaration of function ‘flashrom_layout_get_region_range’ [-Werror=implicit-function-declaration]
  113 |   flashrom_layout_get_region_range(layout, region, &r_start, &r_len);

This is going to hit every person who tries to build cbfstool from source. There doesn't seem to be a great workaround at present.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I572daa0c0f3998e20a8ed76df21228fdbb384baf
Gerrit-Change-Number: 62404
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Jason Glenesk <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Stefan Reinauer <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: ron minnich <[e-mail]>
Gerrit-CC: 9elements QA <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Martin Roth <[e-mail]>
Gerrit-Comment-Date: Tue, 01 Mar 2022 00:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment