coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: [for test] crossgcc: Update GCC from 11.2 to 12.2
by Elyes Haouas (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Julius Werner. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67821 ) Change subject: [for test] crossgcc: Update GCC from 11.2 to 12.2 ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: Nico, Would you please have look on "3rdparty/libgfxinit/common/hw-gfx-gma-pch-transcoder"? I got this error: Log excerpt: GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_aux_request.o GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_dual_mode.o GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_info.o GCC ramstage/libgfxinit/common/hw-gfx-gma-i2c.o GCC ramstage/libgfxinit/common/hw-gfx-gma-panel.o GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-fdi.o GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-sideband.o GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o raised STORAGE_ERROR : stack overflow or erroneous memory access make[3]: *** [Makefile:392: /cb-build/coreboot-toolchain.0/gcc-chromeos/GOOGLE_LINK/ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o] Error 1 (see https://qa.coreboot.org/job/coreboot-toolchain/1338/consoleFull ) Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/67821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911 Gerrit-Change-Number: 67821 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Dec 2022 05:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/mt8195: Add i2c driver support
by Elyes Haouas (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Rex-BC Chen. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53894 ) Change subject: soc/mediatek/mt8195: Add i2c driver support ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/mt8195/i2c.c: https://review.coreboot.org/c/coreboot/+/53894/comment/41bd16d1_b07ec8ab PS3, Line 109: gpio_set_mode(ptr[i].gpio, ptr[i].func); Log excerpt: In function 'mtk_i2c_set_gpio_pinmux', inlined from 'mtk_i2c_bus_init' at src/soc/mediatek/mt8195/i2c.c:114:2: src/soc/mediatek/mt8195/i2c.c:105:17: error: array subscript 17 is outside array bounds of 'const struct pad_func[8][2]' [-Werror=array-bounds] 105 | gpio_set_mode(ptr[i].gpio, ptr[i].func); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/soc/mediatek/mt8195/i2c.c: In function 'mtk_i2c_bus_init': src/soc/mediatek/mt8195/i2c.c:63:30: note: at offset 136 into object 'i2c_funcs' of size 128 63 | static const struct pad_func i2c_funcs[I2C_BUS_NUMBER][2] = { | ^~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [Makefile:392: /cb-build/coreboot-toolchain.0/gcc-chromeos/GOOGLE_TOMATO/romstage/soc/mediatek/mt8195/i2c.o] Error 1 (see https://qa.coreboot.org/job/coreboot-toolchain/1338/consoleFull ) -- To view, visit https://review.coreboot.org/c/coreboot/+/53894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia26e55512501e9758d7f5543d176730cf30ce03d Gerrit-Change-Number: 53894 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 05:46:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
by Dinesh Gehlot (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Subrata Banik, Alex Levin, Arthur Heymans, Andrey Petrov, Felix Held. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 ) Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > @Dinesh: can you please check this cl? The Changes looks fine to me. The rework enhances readability without altering the core functionality. -- To view, visit https://review.coreboot.org/c/coreboot/+/69499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 Gerrit-Change-Number: 69499 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Alex Levin <levinale(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 04:31:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
by Dinesh Gehlot (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Alex Levin, Arthur Heymans, Andrey Petrov, Felix Held. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 ) Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 Gerrit-Change-Number: 69499 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Alex Levin <levinale(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 04:21:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/sandybridge: Use write32p()
by Sridhar Siricilla (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Angel Pons, Elyes Haouas. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70293 ) Change subject: nb/intel/sandybridge: Use write32p() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0984ff1d0b1908bfb7028910f2c6f1083e153520 Gerrit-Change-Number: 70293 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 05 Dec 2022 04:20:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block: Use readXXp/writeXXp()
by Sridhar Siricilla (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Elyes Haouas. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70294 ) Change subject: soc/intel/common/block: Use readXXp/writeXXp() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83d05ce0b26b01fdfc95d1442a4c930ed77bf25c Gerrit-Change-Number: 70294 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 05 Dec 2022 04:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/marasov: Configure I2C high and low time
by Frank Chu (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Shun-min Yang, Tarun Tuli. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70232 ) Change subject: mb/google/brya/var/marasov: Configure I2C high and low time ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/marasov/overridetree.cb: https://review.coreboot.org/c/coreboot/+/70232/comment/393ecf13_7413e633 PS1, Line 38: I2C_SPEED_FAST > The speed of these I2C buses has not changed. Please clarify the purpose of the CL. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcec6e401992d30dff01940c50473cba48cffc19 Gerrit-Change-Number: 70232 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Shun-min Yang <shunminyang(a)google.com> Gerrit-Attention: Shun-min Yang <shunminyang(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 03:04:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shun-min Yang <shunminyang(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Update fw_config STORAGE field
by Ricky Chang (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Nick Vaccaro. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70220 ) Change subject: mb/google/brya/var/lisbon: Update fw_config STORAGE field ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd52112743ee0d64aca630e54511503607770d71 Gerrit-Change-Number: 70220 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 01:51:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gladios: Update fw_config STORAGE field
by Ricky Chang (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Kevin Chiu, Tarun Tuli, Nick Vaccaro. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70223 ) Change subject: mb/google/brya/var/gladios: Update fw_config STORAGE field ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27baa2ca8c2b334fb81aa87b22c3b7c028c38cd8 Gerrit-Change-Number: 70223 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 01:50:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/acpi, mb/google/skyrim: Implement DTTS Proposal
by EricKY Cheng (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Tim Van Patten, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held. EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 ) Change subject: soc/amd/common/acpi, mb/google/skyrim: Implement DTTS Proposal ...................................................................... Patch Set 79: (1 comment) File src/soc/amd/common/acpi/DTTS.asl: https://review.coreboot.org/c/coreboot/+/68471/comment/7ea32894_d8398979 PS39, Line 21: //Set table A as default table after power on SUT : If (\_SB.PRTN == 7) : { : \_SB.DDEF() : Store(0,\_SB.PRTN) : Return (Zero) : } > Hi Tim, […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622 Gerrit-Change-Number: 68471 Gerrit-PatchSet: 79 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 01:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022