Attention is currently required from: Rex-BC Chen.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53894 )
Change subject: soc/mediatek/mt8195: Add i2c driver support ......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8195/i2c.c:
https://review.coreboot.org/c/coreboot/+/53894/comment/41bd16d1_b07ec8ab PS3, Line 109: gpio_set_mode(ptr[i].gpio, ptr[i].func); Log excerpt: In function 'mtk_i2c_set_gpio_pinmux', inlined from 'mtk_i2c_bus_init' at src/soc/mediatek/mt8195/i2c.c:114:2: src/soc/mediatek/mt8195/i2c.c:105:17: error: array subscript 17 is outside array bounds of 'const struct pad_func[8][2]' [-Werror=array-bounds] 105 | gpio_set_mode(ptr[i].gpio, ptr[i].func); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/soc/mediatek/mt8195/i2c.c: In function 'mtk_i2c_bus_init': src/soc/mediatek/mt8195/i2c.c:63:30: note: at offset 136 into object 'i2c_funcs' of size 128 63 | static const struct pad_func i2c_funcs[I2C_BUS_NUMBER][2] = { | ^~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [Makefile:392: /cb-build/coreboot-toolchain.0/gcc-chromeos/GOOGLE_TOMATO/romstage/soc/mediatek/mt8195/i2c.o] Error 1
(see https://qa.coreboot.org/job/coreboot-toolchain/1338/consoleFull )