coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: soc/intel: Set IO APIC DMAR entry based on hw
by Werner Zeh (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Jeff Daly, Sean Rhodes, Tarun Tuli, Subrata Banik, Kapil Porwal, Vanessa Eusebio, Arthur Heymans, Lean Sheng Tan, Kyösti Mälkki. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70268 ) Change subject: soc/intel: Set IO APIC DMAR entry based on hw ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: I cherry-picked this train and tested on mc_ehl1 (Elkhart Lake) by comparing the DMAR ACPI table which is created at runtime (acpidump & iasl -d). The table remains unchanged (beside the time stamp) with this patch train. I just wonder now: shall we remove 'acpi_create_dmar_ds_ioapic' completely (maybe in a follow-up) as it is not used anymore (after this patch train). -- To view, visit https://review.coreboot.org/c/coreboot/+/70268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0965b511e71c58f1c31433bc54595a5fabb1c206 Gerrit-Change-Number: 70268 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 07:02:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for 2065X and 206AX
by build bot (Jenkins) (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Stefan Ott, Angel Pons, Alexander Couzens. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70296 ) Change subject: Enable VBOOT_VBNV_FLASH for 2065X and 206AX ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165215): https://review.coreboot.org/c/coreboot/+/70296/comment/bb4e09d1_5d42491c PS3, Line 28: [1] https://issuetracker.google.com/issues/235293589 Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6c2568f4f58b ("drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config")' -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 07:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for 2065X and 206AX
by Yu-Ping Wu (Code Review) 05 Dec '22

05 Dec '22

Attention is currently required from: Angel Pons, Alexander Couzens, Yu-Ping Wu. Hello build bot (Jenkins), Angel Pons, Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70296 to look at the new patch set (#3). Change subject: Enable VBOOT_VBNV_FLASH for 2065X and 206AX ...................................................................... Enable VBOOT_VBNV_FLASH for 2065X and 206AX To deprecate VBOOT_VBNV_CMOS [1], replace VBOOT_VBNV_CMOS with VBOOT_VBNV_FLASH for boards using CPU_INTEL_MODEL_206AX. Currently BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES is selected for CPU_INTEL_HASWELL, CPU_INTEL_MODEL_206AX and others (see [2]). However, there seems to be no particular reason on those platforms. We've dropped the config for haswell. Now do the same for CPU_INTEL_MODEL_206AX, so that VBOOT_VBNV_FLASH can be enabled. VBOOT_VBNV_FLASH is enabled for the following boards: - Google boards: butterfly, link, lumpy, parrot, stout, stumpy. Use the unused flash space for RW_NVRAM. - Lenovo boards: t410, t420, t420s, t430, t430s, t520, t530, x131e x1_carbon_gen1, x201, x220, x230. A 0x2000 RW_NVRAM region is allocated for them, with the COREBOOT size reduced by 0x2000. Also remove a VBOOT_VBNV_CMOS comment in emeraldlake2 Kconfig. [1] https://issuetracker.google.com/issues/235293589 [2] commit 6c2568f4f58b9a1b209c9af36d7f980fde784f08 (CB:45740) drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config BUG=b:235293589 TEST=./util/abuild/abuild -t LENOVO_T430S -a (with VBOOT enabled) Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/cpu/intel/model_2065x/Kconfig M src/cpu/intel/model_206ax/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/butterfly/chromeos.fmd M src/mainboard/google/link/Kconfig M src/mainboard/google/link/chromeos.fmd M src/mainboard/google/parrot/Kconfig M src/mainboard/google/parrot/chromeos.fmd M src/mainboard/google/stout/Kconfig M src/mainboard/google/stout/chromeos.fmd M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t410/vboot-rwa.fmd M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/vboot-rwab.fmd M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x201/vboot-rwa.fmd M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/vboot-rwab.fmd M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/lumpy/chromeos.fmd M src/mainboard/samsung/stumpy/Kconfig M src/mainboard/samsung/stumpy/chromeos.fmd 39 files changed, 82 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/70296/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init: Inform user of memory training
by Subrata Banik (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Andrey Petrov, Zhixing Ma, Nico Huber, Michał Żygowski, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70300 ) Change subject: drivers/intel/fsp2_0/memory_init: Inform user of memory training ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Can I request you to add `topic` for the entire patch train so, we can easily review the dependent CLs. -- To view, visit https://review.coreboot.org/c/coreboot/+/70300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ea15123eed1a4355c5ff7d815925032d4151de0 Gerrit-Change-Number: 70300 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 06:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX
by Yu-Ping Wu (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Alexander Couzens. Hello Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70296 to look at the new patch set (#2). Change subject: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX ...................................................................... Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX To deprecate VBOOT_VBNV_CMOS [1], replace VBOOT_VBNV_CMOS with VBOOT_VBNV_FLASH for boards using CPU_INTEL_MODEL_206AX. Currently BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES is selected for CPU_INTEL_HASWELL, CPU_INTEL_MODEL_206AX and others (see [2]). However, there seems to be no particular reason on those platforms. We've dropped the config for haswell. Now do the same for CPU_INTEL_MODEL_206AX, so that VBOOT_VBNV_FLASH can be enabled. VBOOT_VBNV_FLASH is enabled for the following boards: - Google boards: butterfly, link, lumpy, parrot, stout, stumpy. Use the unused flash space for RW_NVRAM. - Lenovo boards: t420, t420s, t430, t430s, t520, t530, x131e x1_carbon_gen1, x220, x230. A 0x2000 RW_NVRAM region is allocated for them, with the COREBOOT size reduced by 0x2000. Also remove a VBOOT_VBNV_CMOS comment in emeraldlake2 Kconfig. [1] https://issuetracker.google.com/issues/235293589 [2] commit 6c2568f4f58b9a1b209c9af36d7f980fde784f08 (CB:45740) drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config BUG=b:235293589 TEST=./util/abuild/abuild -t LENOVO_T430S -a (with VBOOT enabled) Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/cpu/intel/model_206ax/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/butterfly/chromeos.fmd M src/mainboard/google/link/Kconfig M src/mainboard/google/link/chromeos.fmd M src/mainboard/google/parrot/Kconfig M src/mainboard/google/parrot/chromeos.fmd M src/mainboard/google/stout/Kconfig M src/mainboard/google/stout/chromeos.fmd M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/vboot-rwab.fmd M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/vboot-rwab.fmd M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/lumpy/chromeos.fmd M src/mainboard/samsung/stumpy/Kconfig M src/mainboard/samsung/stumpy/chromeos.fmd 34 files changed, 78 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/70296/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/hp/z220_series: Drop VBOOT support
by Yu-Ping Wu (Code Review) 04 Dec '22

04 Dec '22

Yu-Ping Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/70295 ) Change subject: mb/hp/z220_series: Drop VBOOT support ...................................................................... mb/hp/z220_series: Drop VBOOT support There is no .fmd file with RW regions for z220_series, which is required for VBOOT. Therefore, the VBOOT option is useless for z220_series. In fact, HP_Z220_CMT_WORKSTATION doesn't even build with VBOOT: E: Image is missing 'GBB' region Remove the VBOOT Kconfig option from z220_series. BUG=b:235293589 TEST=none Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M Documentation/security/vboot/list_vboot.md M src/mainboard/hp/z220_series/Kconfig 2 files changed, 21 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/70295/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f Gerrit-Change-Number: 70295 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX
by build bot (Jenkins) (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Alexander Couzens. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70296 ) Change subject: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165214): https://review.coreboot.org/c/coreboot/+/70296/comment/cc0989de_7f3ad78f PS1, Line 28: [1] https://issuetracker.google.com/issues/235293589 Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6c2568f4f58b ("drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config")' -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 06:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: Move codes to support new PCH
by Shuming Chu (Shuming) (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Morgan Jang. Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70009 ) Change subject: soc/intel/xeon_sp: Move codes to support new PCH ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/70009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06555ed6612c632ea2ce1938d81781cd9348017a Gerrit-Change-Number: 70009 Gerrit-PatchSet: 2 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Mon, 05 Dec 2022 06:43:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX
by Yu-Ping Wu (Code Review) 04 Dec '22

04 Dec '22

Attention is currently required from: Alexander Couzens. Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70296 ) Change subject: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX ...................................................................... Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX To deprecate VBOOT_VBNV_CMOS [1], replace VBOOT_VBNV_CMOS with VBOOT_VBNV_FLASH for boards using CPU_INTEL_MODEL_206AX. Currently BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES is selected for CPU_INTEL_HASWELL, CPU_INTEL_MODEL_206AX and others (see [2]). However, there seems to be no particular reason on those platforms. We've dropped the config for haswell. Now do the same for CPU_INTEL_MODEL_206AX, so that VBOOT_VBNV_FLASH can be enabled. VBOOT_VBNV_FLASH is enabled for the following boards: - Google boards: butterfly, link, lumpy, parrot, stout, stumpy. Use the unused flash space for RW_NVRAM. - Lenovo boards: t420, t420s, t430, t430s, t520, t530, x131e x1_carbon_gen1, x220, x230. A 0x2000 RW_NVRAM region is allocated for them, with the COREBOOT size reduced by 0x2000. Also remove a VBOOT_VBNV_CMOS comment in emeraldlake2 Kconfig. [1] https://issuetracker.google.com/issues/235293589 [2] commit 6c2568f4f58b9a1b209c9af36d7f980fde784f08 (CB:45740) drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/cpu/intel/model_206ax/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/butterfly/chromeos.fmd M src/mainboard/google/link/Kconfig M src/mainboard/google/link/chromeos.fmd M src/mainboard/google/parrot/Kconfig M src/mainboard/google/parrot/chromeos.fmd M src/mainboard/google/stout/Kconfig M src/mainboard/google/stout/chromeos.fmd M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420/vboot-rwa.fmd M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t420s/vboot-rwa.fmd M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/vboot-rwab.fmd M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/vboot-rwab.fmd M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t520/vboot-rwa.fmd M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t530/vboot-rwab.fmd M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x131e/vboot-rwab.fmd M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/vboot-rwa.fmd M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/vboot-rwab.fmd M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/lumpy/chromeos.fmd M src/mainboard/samsung/stumpy/Kconfig M src/mainboard/samsung/stumpy/chromeos.fmd 34 files changed, 75 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/70296/1 diff --git a/src/cpu/intel/model_206ax/Kconfig b/src/cpu/intel/model_206ax/Kconfig index c168c9b..032450d 100644 --- a/src/cpu/intel/model_206ax/Kconfig +++ b/src/cpu/intel/model_206ax/Kconfig @@ -6,7 +6,6 @@ config CPU_SPECIFIC_OPTIONS def_bool y select ARCH_X86 - select BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES select HAVE_EXP_X86_64_SUPPORT if USE_NATIVE_RAMINIT select MMX select SSE2 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 49ac7d2..8444afc 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -23,7 +23,7 @@ select SYSTEM_TYPE_LAPTOP config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "google/butterfly" diff --git a/src/mainboard/google/butterfly/chromeos.fmd b/src/mainboard/google/butterfly/chromeos.fmd index 93048a3..d8b092d 100644 --- a/src/mainboard/google/butterfly/chromeos.fmd +++ b/src/mainboard/google/butterfly/chromeos.fmd @@ -22,7 +22,7 @@ } RW_ENVIRONMENT@0x1f8000 0x4000 RW_VPD(PRESERVE)@0x1fc000 0x2000 - RW_UNUSED@0x1fe000 0x2000 + RW_NVRAM(PRESERVE)@0x1fe000 0x2000 SMMSTORE(PRESERVE)@0x200000 0x40000 RW_LEGACY(CBFS)@0x240000 0x1c0000 WP_RO@0x400000 0x200000 { diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index e6e4b0b..511a152 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -23,7 +23,7 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "google/link" diff --git a/src/mainboard/google/link/chromeos.fmd b/src/mainboard/google/link/chromeos.fmd index 3841445..0980639 100644 --- a/src/mainboard/google/link/chromeos.fmd +++ b/src/mainboard/google/link/chromeos.fmd @@ -21,7 +21,7 @@ VBLOCK_DEV@0x2000 0x2000 } RW_VPD(PRESERVE)@0x1f8000 0x2000 - RW_UNUSED@0x1fa000 0x6000 + RW_NVRAM(PRESERVE)@0x1fa000 0x6000 SMMSTORE(PRESERVE)@0x200000 0x40000 RW_LEGACY(CBFS)@0x240000 0x1c0000 WP_RO@0x400000 0x200000 { diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index dd6df3e..bae827f 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -24,7 +24,7 @@ select SYSTEM_TYPE_LAPTOP config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "google/parrot" diff --git a/src/mainboard/google/parrot/chromeos.fmd b/src/mainboard/google/parrot/chromeos.fmd index 6752888..066c78a 100644 --- a/src/mainboard/google/parrot/chromeos.fmd +++ b/src/mainboard/google/parrot/chromeos.fmd @@ -22,7 +22,7 @@ } RW_ENVIRONMENT@0x1f8000 0x4000 RW_VPD(PRESERVE)@0x1fc000 0x2000 - RW_UNUSED@0x1fe000 0x2000 + RW_NVRAM(PRESERVE)@0x1fe000 0x2000 SMMSTORE(PRESERVE)@0x200000 0x40000 RW_LEGACY(CBFS)@0x240000 0x1c0000 WP_RO@0x400000 0x200000 { diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 152c57f..2b2381c 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -22,7 +22,7 @@ select SYSTEM_TYPE_LAPTOP config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "google/stout" diff --git a/src/mainboard/google/stout/chromeos.fmd b/src/mainboard/google/stout/chromeos.fmd index 93048a3..d8b092d 100644 --- a/src/mainboard/google/stout/chromeos.fmd +++ b/src/mainboard/google/stout/chromeos.fmd @@ -22,7 +22,7 @@ } RW_ENVIRONMENT@0x1f8000 0x4000 RW_VPD(PRESERVE)@0x1fc000 0x2000 - RW_UNUSED@0x1fe000 0x2000 + RW_NVRAM(PRESERVE)@0x1fe000 0x2000 SMMSTORE(PRESERVE)@0x200000 0x40000 RW_LEGACY(CBFS)@0x240000 0x1c0000 WP_RO@0x400000 0x200000 { diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 86fe98a..42d95ea 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -15,7 +15,6 @@ #select MAINBOARD_HAS_CHROMEOS config VBOOT - #select VBOOT_VBNV_CMOS config MAINBOARD_DIR default "intel/emeraldlake2" diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index b82f45a..4fe2f8a 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -29,7 +29,7 @@ select SERIRQ_CONTINUOUS_MODE config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC diff --git a/src/mainboard/lenovo/t420/vboot-rwa.fmd b/src/mainboard/lenovo/t420/vboot-rwa.fmd index 8a4cd3b..4bd4b86 100644 --- a/src/mainboard/lenovo/t420/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t420/vboot-rwa.fmd @@ -16,14 +16,15 @@ } RW_VPD(PRESERVE)@0x1a0000 0x1000 SMMSTORE(PRESERVE)@0x1a1000 0x40000 + RW_NVRAM(PRESERVE)@0x1e1000 0x2000 - WP_RO@0x1e1000 0x11f000 { + WP_RO@0x1e3000 0x11d000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_PADDING@0x840 0x7c0 RO_VPD(PRESERVE)@0x1000 0x1000 GBB@0x2000 0x1e000 - COREBOOT(CBFS)@0x20000 0xff000 + COREBOOT(CBFS)@0x20000 0xfd000 } } } diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 4045506..7b4f9d9 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -32,7 +32,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_A default y diff --git a/src/mainboard/lenovo/t420s/vboot-rwa.fmd b/src/mainboard/lenovo/t420s/vboot-rwa.fmd index 8a4cd3b..4bd4b86 100644 --- a/src/mainboard/lenovo/t420s/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t420s/vboot-rwa.fmd @@ -16,14 +16,15 @@ } RW_VPD(PRESERVE)@0x1a0000 0x1000 SMMSTORE(PRESERVE)@0x1a1000 0x40000 + RW_NVRAM(PRESERVE)@0x1e1000 0x2000 - WP_RO@0x1e1000 0x11f000 { + WP_RO@0x1e3000 0x11d000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_PADDING@0x840 0x7c0 RO_VPD(PRESERVE)@0x1000 0x1000 GBB@0x2000 0x1e000 - COREBOOT(CBFS)@0x20000 0xff000 + COREBOOT(CBFS)@0x20000 0xfd000 } } } diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index cfa8283..748a6c4 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -32,7 +32,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_AB default y diff --git a/src/mainboard/lenovo/t430/vboot-rwab.fmd b/src/mainboard/lenovo/t430/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/t430/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t430/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 373d08f..fbb9968 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -30,7 +30,7 @@ select SERIRQ_CONTINUOUS_MODE config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC diff --git a/src/mainboard/lenovo/t430s/vboot-rwab.fmd b/src/mainboard/lenovo/t430s/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/t430s/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t430s/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index 81a1e30d..343e6be 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -28,7 +28,7 @@ if BOARD_LENOVO_BASEBOARD_T520 config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC diff --git a/src/mainboard/lenovo/t520/vboot-rwa.fmd b/src/mainboard/lenovo/t520/vboot-rwa.fmd index 8a4cd3b..4bd4b86 100644 --- a/src/mainboard/lenovo/t520/vboot-rwa.fmd +++ b/src/mainboard/lenovo/t520/vboot-rwa.fmd @@ -16,14 +16,15 @@ } RW_VPD(PRESERVE)@0x1a0000 0x1000 SMMSTORE(PRESERVE)@0x1a1000 0x40000 + RW_NVRAM(PRESERVE)@0x1e1000 0x2000 - WP_RO@0x1e1000 0x11f000 { + WP_RO@0x1e3000 0x11d000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_PADDING@0x840 0x7c0 RO_VPD(PRESERVE)@0x1000 0x1000 GBB@0x2000 0x1e000 - COREBOOT(CBFS)@0x20000 0xff000 + COREBOOT(CBFS)@0x20000 0xfd000 } } } diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 39d37e9..d323097 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -39,7 +39,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_AB default y diff --git a/src/mainboard/lenovo/t530/vboot-rwab.fmd b/src/mainboard/lenovo/t530/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/t530/vboot-rwab.fmd +++ b/src/mainboard/lenovo/t530/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index 872249e..08dffcc 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -27,7 +27,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_AB default y diff --git a/src/mainboard/lenovo/x131e/vboot-rwab.fmd b/src/mainboard/lenovo/x131e/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/x131e/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x131e/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index 451d819..fa08c13 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -32,7 +32,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_AB default y diff --git a/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd b/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index d51deae..81d3a81d 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -32,7 +32,7 @@ select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config VBOOT_SLOTS_RW_A default y diff --git a/src/mainboard/lenovo/x220/vboot-rwa.fmd b/src/mainboard/lenovo/x220/vboot-rwa.fmd index 8a4cd3b..4bd4b86 100644 --- a/src/mainboard/lenovo/x220/vboot-rwa.fmd +++ b/src/mainboard/lenovo/x220/vboot-rwa.fmd @@ -16,14 +16,15 @@ } RW_VPD(PRESERVE)@0x1a0000 0x1000 SMMSTORE(PRESERVE)@0x1a1000 0x40000 + RW_NVRAM(PRESERVE)@0x1e1000 0x2000 - WP_RO@0x1e1000 0x11f000 { + WP_RO@0x1e3000 0x11d000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_PADDING@0x840 0x7c0 RO_VPD(PRESERVE)@0x1000 0x1000 GBB@0x2000 0x1e000 - COREBOOT(CBFS)@0x20000 0xff000 + COREBOOT(CBFS)@0x20000 0xfd000 } } } diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index f966726..6f0a0b8 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -30,7 +30,7 @@ select SERIRQ_CONTINUOUS_MODE config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC diff --git a/src/mainboard/lenovo/x230/vboot-rwab.fmd b/src/mainboard/lenovo/x230/vboot-rwab.fmd index 1747c0e..13df4f6 100644 --- a/src/mainboard/lenovo/x230/vboot-rwab.fmd +++ b/src/mainboard/lenovo/x230/vboot-rwab.fmd @@ -21,6 +21,7 @@ } RW_VPD(PRESERVE) 0x1000 SMMSTORE(PRESERVE)@0x521000 0x40000 + RW_NVRAM(PRESERVE)@0x561000 0x2000 WP_RO { FMAP 0x800 diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 8d8f625..782a266 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -26,7 +26,7 @@ select HAVE_SPD_IN_CBFS config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "samsung/lumpy" diff --git a/src/mainboard/samsung/lumpy/chromeos.fmd b/src/mainboard/samsung/lumpy/chromeos.fmd index 9852a22..051cfd1 100644 --- a/src/mainboard/samsung/lumpy/chromeos.fmd +++ b/src/mainboard/samsung/lumpy/chromeos.fmd @@ -5,7 +5,8 @@ } SI_BIOS@0x180000 0x680000 { RW_VPD(PRESERVE)@0x0 0x1000 - RW_UNUSED@0x1000 0x67000 + RW_UNUSED@0x1000 0x5f000 + RW_NVRAM(PRESERVE)@0x60000 0x8000 RW_SHARED@0x68000 0x18000 { RW_ENVIRONMENT@0x0 0x4000 RW_MRC_CACHE@0x4000 0x10000 diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index e123058..f79d42c 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -22,7 +22,7 @@ select SANDYBRIDGE_VBOOT_IN_ROMSTAGE config VBOOT - select VBOOT_VBNV_CMOS + select VBOOT_VBNV_FLASH config MAINBOARD_DIR default "samsung/stumpy" diff --git a/src/mainboard/samsung/stumpy/chromeos.fmd b/src/mainboard/samsung/stumpy/chromeos.fmd index 9852a22..051cfd1 100644 --- a/src/mainboard/samsung/stumpy/chromeos.fmd +++ b/src/mainboard/samsung/stumpy/chromeos.fmd @@ -5,7 +5,8 @@ } SI_BIOS@0x180000 0x680000 { RW_VPD(PRESERVE)@0x0 0x1000 - RW_UNUSED@0x1000 0x67000 + RW_UNUSED@0x1000 0x5f000 + RW_NVRAM(PRESERVE)@0x60000 0x8000 RW_SHARED@0x68000 0x18000 { RW_ENVIRONMENT@0x0 0x4000 RW_MRC_CACHE@0x4000 0x10000 -- To view, visit https://review.coreboot.org/c/coreboot/+/70296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3 Gerrit-Change-Number: 70296 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/hp/z220_series: Drop VBOOT support
by Yu-Ping Wu (Code Review) 04 Dec '22

04 Dec '22

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70295 ) Change subject: mb/hp/z220_series: Drop VBOOT support ...................................................................... mb/hp/z220_series: Drop VBOOT support There is no .fmd file with RW regions for z220_series, which is required for VBOOT. Therefore, the VBOOT option is useless for z220_series. In fact, HP_Z220_CMT_WORKSTATION doesn't even build with VBOOT: E: Image is missing 'GBB' region Remove the VBOOT Kconfig option from z220_series. Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M Documentation/security/vboot/list_vboot.md M src/mainboard/hp/z220_series/Kconfig 2 files changed, 18 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/70295/1 diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index cc265ee..9559599 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -276,10 +276,6 @@ - Shuboz - Gumboz (HP Chromebook x360 14a) -## HP -- Z220 CMT Workstation -- Z220 SFF Workstation - ## Intel - Alderlake-P RVP - Alderlake-P RVP with Chrome EC diff --git a/src/mainboard/hp/z220_series/Kconfig b/src/mainboard/hp/z220_series/Kconfig index 1be3972..ab5dded 100644 --- a/src/mainboard/hp/z220_series/Kconfig +++ b/src/mainboard/hp/z220_series/Kconfig @@ -26,18 +26,6 @@ if BOARD_HP_Z220_SERIES_COMMON -config VBOOT - select VBOOT_VBNV_CMOS - select VBOOT_NO_BOARD_SUPPORT - select GBB_FLAG_DISABLE_LID_SHUTDOWN - select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC - select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC - select GBB_FLAG_DISABLE_FWMP - -config VBOOT_VBNV_OFFSET - hex - default 0x2a - config CBFS_SIZE default 0x570000 -- To view, visit https://review.coreboot.org/c/coreboot/+/70295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dcabda5e8ee3a0084736d3674dca31d1f5a641f Gerrit-Change-Number: 70295 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022