Attention is currently required from: Alexander Couzens.
Hello Alexander Couzens,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70296
to look at the new patch set (#2).
Change subject: Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX
......................................................................
Enable VBOOT_VBNV_FLASH for CPU_INTEL_MODEL_206AX
To deprecate VBOOT_VBNV_CMOS [1], replace VBOOT_VBNV_CMOS with
VBOOT_VBNV_FLASH for boards using CPU_INTEL_MODEL_206AX.
Currently BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES is selected for
CPU_INTEL_HASWELL, CPU_INTEL_MODEL_206AX and others (see [2]). However,
there seems to be no particular reason on those platforms. We've dropped
the config for haswell. Now do the same for CPU_INTEL_MODEL_206AX, so
that VBOOT_VBNV_FLASH can be enabled.
VBOOT_VBNV_FLASH is enabled for the following boards:
- Google boards: butterfly, link, lumpy, parrot, stout, stumpy. Use the
unused flash space for RW_NVRAM.
- Lenovo boards: t420, t420s, t430, t430s, t520, t530, x131e
x1_carbon_gen1, x220, x230. A 0x2000 RW_NVRAM region is allocated for
them, with the COREBOOT size reduced by 0x2000.
Also remove a VBOOT_VBNV_CMOS comment in emeraldlake2 Kconfig.
[1] https://issuetracker.google.com/issues/235293589
[2] commit 6c2568f4f58b9a1b209c9af36d7f980fde784f08 (CB:45740)
drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config
BUG=b:235293589
TEST=./util/abuild/abuild -t LENOVO_T430S -a (with VBOOT enabled)
Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/cpu/intel/model_206ax/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/butterfly/chromeos.fmd
M src/mainboard/google/link/Kconfig
M src/mainboard/google/link/chromeos.fmd
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/parrot/chromeos.fmd
M src/mainboard/google/stout/Kconfig
M src/mainboard/google/stout/chromeos.fmd
M src/mainboard/intel/emeraldlake2/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420/vboot-rwa.fmd
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t420s/vboot-rwa.fmd
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430/vboot-rwab.fmd
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t430s/vboot-rwab.fmd
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t520/vboot-rwa.fmd
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/t530/vboot-rwab.fmd
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x131e/vboot-rwab.fmd
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/vboot-rwab.fmd
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x220/vboot-rwa.fmd
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x230/vboot-rwab.fmd
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/lumpy/chromeos.fmd
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/samsung/stumpy/chromeos.fmd
34 files changed, 78 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/70296/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I833edd4f7a328b21e81c971ba8a9aec0aad7d3d3
Gerrit-Change-Number: 70296
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Morgan Jang.
Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70009 )
Change subject: soc/intel/xeon_sp: Move codes to support new PCH
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/70009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06555ed6612c632ea2ce1938d81781cd9348017a
Gerrit-Change-Number: 70009
Gerrit-PatchSet: 2
Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 06:43:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67821 )
Change subject: [for test] crossgcc: Update GCC from 11.2 to 12.2
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
Nico,
Would you please have look on "3rdparty/libgfxinit/common/hw-gfx-gma-pch-transcoder"?
I got this error:
Log excerpt:
GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_aux_request.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_dual_mode.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-dp_info.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-i2c.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-panel.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-fdi.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-sideband.o
GCC ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o
raised STORAGE_ERROR : stack overflow or erroneous memory access
make[3]: *** [Makefile:392: /cb-build/coreboot-toolchain.0/gcc-chromeos/GOOGLE_LINK/ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o] Error 1
(see https://qa.coreboot.org/job/coreboot-toolchain/1338/consoleFull )
Thank you
--
To view, visit https://review.coreboot.org/c/coreboot/+/67821
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02d5680929b56ad357c3a010cff7e1540001911
Gerrit-Change-Number: 67821
Gerrit-PatchSet: 12
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 05 Dec 2022 05:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Alex Levin, Arthur Heymans, Andrey Petrov, Felix Held.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 )
Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> @Dinesh: can you please check this cl?
The Changes looks fine to me. The rework enhances readability without altering the core functionality.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52
Gerrit-Change-Number: 69499
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Alex Levin <levinale(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 04:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Alex Levin, Arthur Heymans, Andrey Petrov, Felix Held.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 )
Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52
Gerrit-Change-Number: 69499
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Alex Levin <levinale(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 04:21:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment