coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: soc/intel/alderlake: [WIP]Trigger cse_fw_sync before DRAM Init
by build bot (Jenkins) (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Sridhar Siricilla, Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 ) Change subject: soc/intel/alderlake: [WIP]Trigger cse_fw_sync before DRAM Init ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/alderlake/romstage/romstage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127191): https://review.coreboot.org/c/coreboot/+/55364/comment/7106c7aa_f97e7e2c PS3, Line 140: if (!s3wake) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/55364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad7403650df8bc4e40aa6e48ccfeba95a5789a2d Gerrit-Change-Number: 55364 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 10:02:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/tigerlake: Don't send CSE EOP if CSME is disabled
by Sean Rhodes (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57149 ) Change subject: soc/tigerlake: Don't send CSE EOP if CSME is disabled ...................................................................... Patch Set 10: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/57149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic00fdb0d97fefac977c0878d1d5893d07d4481ea Gerrit-Change-Number: 57149 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:50:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Added multiboot support to cbfstool and made changes to behaviour for...
by Paul Menzel (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Michał Żygowski. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27957 ) Change subject: Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: How can this be tested? -- To view, visit https://review.coreboot.org/c/coreboot/+/27957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaeb808e8750ad81bdf8c4daedb0d91e961eebb70 Gerrit-Change-Number: 27957 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by Paul Menzel (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Patrick Rudolph, Dun Tan. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57296 ) Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57296/comment/6cddf87a_b7146ee8 PS3, Line 7: Fix the bug Fix bug https://review.coreboot.org/c/coreboot/+/57296/comment/6ca1d04c_659b6a9c PS3, Line 7: cbftool cbfstool https://review.coreboot.org/c/coreboot/+/57296/comment/455d85c0_22a4c6e6 PS3, Line 7: Uefipayload UefiPayload https://review.coreboot.org/c/coreboot/+/57296/comment/baafd061_7421730c PS3, Line 9: The patch is to fix "Not a usable UEFI firmware volume" issue when : creating CBFS/flash image. Is that documented somewhere? Please add a reference, or elaborate how to reproduce this. I am also curious, because a lot of people are using this, I think, and I have not heard about the problem yet. https://review.coreboot.org/c/coreboot/+/57296/comment/563d7e9d_0ed806fa PS3, Line 10: This issue is caused by adding FvNameGuid : in UefiPayloadEntry.fdf in EDKII. There is an ext header between header : of Fv and header of PayloadEntry in Fv with FvNameGuid. The ext header : causes the UefiPayloadEntry to be found incorrectly when parsing Fv. Is that a recent change in UefiPayload? -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 3 Gerrit-Owner: Dun Tan <dun.tan(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ray Ni <ray.ni(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Dun Tan <dun.tan(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7
by Subrata Banik (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Kyösti Mälkki, Swift Geek (Sebastian Grzywna). Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Kyösti Mälkki, Swift Geek (Sebastian Grzywna), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57306 to look at the new patch set (#2). Change subject: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7 ...................................................................... arch/x86: Check unsupported CPU type while writing to SMBIOS table 7 Don't attempt to fill the SMBIOS table if the CPU doesn't support deterministic cache CPUID. TEST=Able to fix the hang issue seen on ASRock E350M1 with commit hash e2b5fee. Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/smbios.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/57306/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f Gerrit-Change-Number: 57306 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Subrata Banik (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Kyösti Mälkki. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 ) Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57305/comment/ea8907a4_f263eee2 PS1, Line 12: skip > skips Ack https://review.coreboot.org/c/coreboot/+/57305/comment/0e79220c_e404af1b PS1, Line 14: > Please mention the hang on the ASRock E350M1, and also add a `Fixes:` tag. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Subrata Banik (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Kyösti Mälkki. Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Kyösti Mälkki, Swift Geek (Sebastian Grzywna), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57305 to look at the new patch set (#2). Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... arch/x86: Skip returning default leaf value as `0` `cpu_get_cache_info_leaf()` function is responsible to report leaf value for CPU that have support for deterministic cache cpuid. As per available datasheets from AMD and Intel the supported CPUID leaf are 0x8000_001d for AMD and 0x04 for Intel. Hence, this CL skips returning default leaf value as `0`. TEST=Able to fix the hang issue seen on ASRock E350M1 with commit hash e2b5fee Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/cpu_common.c 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/57305/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Remove some duplicate binaries/entries in PSP table
by Paul Menzel (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Bao Zheng, Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57064 ) Change subject: amdfwtool: Remove some duplicate binaries/entries in PSP table ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57064/comment/96a39df4_7441ce53 PS5, Line 9: these Which ones exactly? https://review.coreboot.org/c/coreboot/+/57064/comment/3dfb4e75_4b71edfe PS5, Line 12: goint going https://review.coreboot.org/c/coreboot/+/57064/comment/b36cb262_9d0ef8ca PS5, Line 22: Issue issue -- To view, visit https://review.coreboot.org/c/coreboot/+/57064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia81b8a85792d1565445803100bdb01c3436e5698 Gerrit-Change-Number: 57064 Gerrit-PatchSet: 5 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Detect the flag multilevel to decide the actual value
by Paul Menzel (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Bao Zheng, Zheng Bao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57063 ) Change subject: amdfwtool: Detect the flag multilevel to decide the actual value ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57063/comment/971c6ffc_4e439207 PS4, Line 9: define defined https://review.coreboot.org/c/coreboot/+/57063/comment/049b0918_3622e78a PS4, Line 12: How much space is saved? -- To view, visit https://review.coreboot.org/c/coreboot/+/57063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe8cdd5c14225899352b02bb19aae6059d56d428 Gerrit-Change-Number: 57063 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Wed, 01 Sep 2021 09:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/redrix: adjust uid for Maxim amp
by Paul Menzel (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Chen Wisley, Angel Pons, Keith Tzeng. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57208 ) Change subject: mb/google/brya/var/redrix: adjust uid for Maxim amp ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57208/comment/84de3672_a07c579d PS1, Line 13: > This is to consist with other 2 speakers configs, and m/c driver design. […] Please mention that in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/57208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a3183b1e1ecbb109258d6e076551158e0b40ce1 Gerrit-Change-Number: 57208 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 09:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021