September 2021 - coreboot-gerrit

Change in coreboot[master]: amdfwtool: Add support for traditional recovery
by Bao Zheng (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Zheng Bao. Hello build bot (Jenkins), Zheng Bao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57131 to look at the new patch set (#4). Change subject: amdfwtool: Add support for traditional recovery ...................................................................... amdfwtool: Add support for traditional recovery Change-Id: I2671b95fe089aafdaf61b55bc9d2e8dcf6a66dbc Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 54 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/57131/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/57131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2671b95fe089aafdaf61b55bc9d2e8dcf6a66dbc Gerrit-Change-Number: 57131 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by Ray Ni (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: duntan. Ray Ni has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57296 ) Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you please update the commit message to explain what issue was met that needs this fix? -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 1 Gerrit-Owner: duntan <dun.tan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ray Ni <ray.ni(a)intel.com> Gerrit-Attention: duntan <dun.tan(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 03:07:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Detect the flag multilevel to decide the actual value
by build bot (Jenkins) (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Bao Zheng, Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57063 ) Change subject: amdfwtool: Detect the flag multilevel to decide the actual value ...................................................................... Patch Set 4: (2 comments) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127168): https://review.coreboot.org/c/coreboot/+/57063/comment/cf7cabda_3d61a230 PS4, Line 589: amd_cb_config *cb_config) need consistent spacing around '*' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127168): https://review.coreboot.org/c/coreboot/+/57063/comment/d032842a_9d335f0f PS4, Line 770: amd_cb_config *cb_config) need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/57063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe8cdd5c14225899352b02bb19aae6059d56d428 Gerrit-Change-Number: 57063 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Wed, 01 Sep 2021 03:06:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpch: Introduce new thermal control mechanism for pch device
by Sumeet R Pawnikar (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 ) Change subject: tpch: Introduce new thermal control mechanism for pch device ...................................................................... Patch Set 2: (4 comments) Patchset: PS1: > Why did you break this out into a separate chip driver? […] ACK File src/drivers/intel/tpch/tpch.h: https://review.coreboot.org/c/coreboot/+/57096/comment/15059077_c2d2c1d5 PS1, Line 15: /* IPC command to control FIVR Configuration */ : #define V_PMC_PWRM_IPC_CMD_COMMAND_FIVR 0xA3 : /* IPC subcommand to write FIVR Register */ : #define V_PMC_PWRM_IPC_CMD_CMD_ID_FIVR_WRITE 0x01 : /* IPC subcommand to control RFI Control 0 register logic write */ : #define V_PMC_PWRM_IPC_SUBCMD_RFI_CTRL0_LOGIC 0x00 : /* IPC subcommand to control RFI Control 4 register logic write */ : #define V_PMC_PWRM_IPC_SUBCMD_RFI_CTRL4_LOGIC 0x01 > These should probably go in […] Done File src/drivers/intel/tpch/tpch.c: https://review.coreboot.org/c/coreboot/+/57096/comment/cdd241e3_ffe03abb PS1, Line 26: acpigen_emit_namestring("IPCS"); : acpigen_write_integer(V_PMC_PWRM_IPC_CMD_COMMAND_FIVR); : acpigen_write_integer(V_PMC_PWRM_IPC_CMD_CMD_ID_FIVR_WRITE); : acpigen_write_integer(0x8); : acpigen_write_integer(V_PMC_PWRM_IPC_SUBCMD_RFI_CTRL0_LOGIC); : acpigen_write_dword(3); : acpigen_emit_byte(RETURN_OP); : acpigen_write_package(0); : acpigen_write_method_end(); : acpigen_pop_len(); : : acpigen_write_method_serialized("RFC1", 1); : acpigen_emit_namestring("IPCS"); : acpigen_write_integer(V_PMC_PWRM_IPC_CMD_COMMAND_FIVR); : acpigen_write_integer(V_PMC_PWRM_IPC_CMD_CMD_ID_FIVR_WRITE); : acpigen_write_integer(0x8); : acpigen_write_integer(V_PMC_PWRM_IPC_SUBCMD_RFI_CTRL4_LOGIC); > Got it, thanks! Should the GFC0 and GFC1 methods be implemented too? Welcome. Yes, I'm working phase wise manner, will submit separate new CL for GFC0 and GFC1 methods on top of this. https://review.coreboot.org/c/coreboot/+/57096/comment/57ce1790_64a8c763 PS1, Line 51: devices > nit: space after `devices` Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/57096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I035d2844b9ba6a9532ae006fc1c43e34cb94328a Gerrit-Change-Number: 57096 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 02:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by duntan (Code Review) Sept. 1, 2021

Sept. 1, 2021

duntan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57296 ) Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... util/cbftool: Fix the bug in parsing Uefipayload with extended header There is an extended header in Fv file with FvNameGuid. The existence of ext header can be confirmed by the value of ext_header_offs. Signed-off-by: Dun Tan <dun.tan(a)intel.com> Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/fv.h 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/57296/1 diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index ae875f3..5341337 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -283,6 +283,7 @@ struct cbfs_payload_segment segs[2] = { {0} }; int doffset, len = 0; firmware_volume_header_t *fv; + firmware_volume_ext_header_t *fvh_ext; ffs_file_header_t *fh; common_section_header_t *cs; dos_header_t *dh; @@ -305,6 +306,12 @@ } fh = (ffs_file_header_t *)(input->data + fv->header_length); + if (fv->ext_header_offs != 0) { + fvh_ext = (firmware_volume_ext_header_t *)((uintptr_t)fv + fv->ext_header_offs); + fh = (ffs_file_header_t *)((uintptr_t)fvh_ext + fvh_ext->ext_header_size); + fh = (ffs_file_header_t *)(((uintptr_t)fh + 7) & ~7); + } + while (fh->file_type == FILETYPE_PAD) { unsigned long offset = (fh->size[2] << 16) | (fh->size[1] << 8) | fh->size[0]; DEBUG("skipping %lu bytes of FV padding\n", offset); diff --git a/util/cbfstool/fv.h b/util/cbfstool/fv.h index 21bd89f..0ad650f 100644 --- a/util/cbfstool/fv.h +++ b/util/cbfstool/fv.h @@ -32,3 +32,8 @@ uint8_t size[3]; uint8_t section_type; } common_section_header_t; + +typedef struct { + uint8_t guid[16]; + uint32_t ext_header_size; +} firmware_volume_ext_header_t; -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 1 Gerrit-Owner: duntan <dun.tan(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/system76/*: cmos.layout: Reserve century byte
by Jeremy Soller (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Tim Crawford. Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57055 ) Change subject: mb/system76/*: cmos.layout: Reserve century byte ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia395acacda1e251251c880587bbf61d7ee81ba3d Gerrit-Change-Number: 57055 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 01:40:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Fix processor hang while plug unplug of TBT device
by Sugnan Prabhu S (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Abhijeet Rao, Furquan Shaikh, Sugnan Prabhu S, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph. Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56503 ) Change subject: soc/intel/alderlake: Fix processor hang while plug unplug of TBT device ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Tim, Furquan, Can we merge this patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/56503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3577df519f64c6f7270dc5537278af76536774e Gerrit-Change-Number: 56503 Gerrit-PatchSet: 7 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com> Gerrit-Attention: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 01:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/goog/brya: Add probed fw_configs to SMBIOS OEM strings
by Keith Tzeng (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Chen Wisley. Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57142 ) Change subject: mb/goog/brya: Add probed fw_configs to SMBIOS OEM strings ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: please help review, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/57142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93cd9ef2d1ad963e66c422cff17b083abf731046 Gerrit-Change-Number: 57142 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 01:19:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: driver/i2c/max98390: add dsm_param_name
by Keith Tzeng (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Paul Menzel. Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57119 ) Change subject: driver/i2c/max98390: add dsm_param_name ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: Please help review, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/57119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I006572d6a6ea55298374c688dfd9d877835da82d Gerrit-Change-Number: 57119 Gerrit-PatchSet: 17 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 01:18:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Add argument to send message to appropriate fix...
by Rizwan Qureshi (Code Review) Sept. 1, 2021

Sept. 1, 2021

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57295 to look at the new patch set (#2). Change subject: soc/intel/common/cse: Add argument to send message to appropriate fixed client ...................................................................... soc/intel/common/cse: Add argument to send message to appropriate fixed client There are multiple HECI clents in the CSE. Currently coreboot is sending HECI messages to only the MKHI client. Add an argument to heci_send_receive() funtion to provide flexibility to the caller to select the client for which the message is intended. In the follow-up patches there will be messages sent to one other client. BUG=None BRANCH=None TEST=Build and boot brya. HECI message send and receive to MKHI client is working. Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Change-Id: Icde6d0155b62472b6a7caadc5fc8ea2e2ba6eb0c --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 4 files changed, 17 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/57295/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icde6d0155b62472b6a7caadc5fc8ea2e2ba6eb0c Gerrit-Change-Number: 57295 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0