Attention is currently required from: Philip Chen, zanxi chen, Bob Moragues, Julius Werner.
Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 )
Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
> We probably don't need extra strapping pins to identify panels.
If we use SKU ID to indentify different panel, it means each SKU can only support one of these two panels, it will impact the production and after sale.
PS4:
> I am not sure that this is the correct way to handle this. […]
Mrbland has only one SKU now and supports two panels, INX and BOE. We hope these two panels can work normally in this SKU. Even if there are more SKUs in the future, we hope that these two panels can work normally in each SKU at the same time. If we use SKU ID to indentify different panel, it means each SKU can only support one of these two panels, it will impact the production and after sale.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2
Gerrit-Change-Number: 57329
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Wenli Xu <xuwenli(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Philip Chen <philipchen(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Comment-Date: Fri, 03 Sep 2021 01:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Chen <philipchen(a)google.com>
Comment-In-Reply-To: Bob Moragues <moragues(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Yu-Ping Wu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: preserve WDT reset reason for debugging
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/44d0ed08_110e2e46
PS2, Line 22: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
> the common/reset.c may be overridden by mainboard reset. […]
ah, didn't see that only mt8173 adds that file to the build. only did a quick git grep of that register name when i was wondering what that line does when i went through the list of patches that were ready to submit at that time
--
To view, visit https://review.coreboot.org/c/coreboot/+/57270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52
Gerrit-Change-Number: 57270
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 00:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: SH Kim, Karthik Ramasubramanian.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57328 )
Change subject: mb/google/dedede/var/bugzzy: Adjust framebuffer orientation
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/57328/comment/bf3ec4e6_e8982743
PS1, Line 84: BOARD_GOOGLE_SASUKE
> Isn't it for Buggzy?
Ah! Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/57328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3477255bab4d99bad5948fd5a4828aa61d8cfa0
Gerrit-Change-Number: 57328
Gerrit-PatchSet: 2
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 00:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Marx Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/57330 )
Change subject: mb/google/brya: Enable SaGv support for baseboard
......................................................................
Abandoned
enable SaGv by each variant instead of baseboard
--
To view, visit https://review.coreboot.org/c/coreboot/+/57330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If109915f2cd3d8df2d74f84fb85e1812e63cc11c
Gerrit-Change-Number: 57330
Gerrit-PatchSet: 1
Gerrit-Owner: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Kane Chen.
Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57330 )
Change subject: mb/google/brya: Enable SaGv support for baseboard
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This is already enabled for brya0 and right now we are letting the variants enable this one by one a […]
Understood. I'll ask the owners to enable it for the variants that have been brought up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If109915f2cd3d8df2d74f84fb85e1812e63cc11c
Gerrit-Change-Number: 57330
Gerrit-PatchSet: 1
Gerrit-Owner: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 00:40:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu, Felix Held.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: preserve WDT reset reason for debugging
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57270/comment/439a3ed2_37c69974
PS4, Line 10: reserve
preserve
https://review.coreboot.org/c/coreboot/+/57270/comment/711d4ab9_91624e11
PS4, Line 11: reserve
preserved
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/b0bbada6_1dd972ee
PS2, Line 22: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
> do_board_reset https://review.coreboot. […]
the common/reset.c may be overridden by mainboard reset.c; in fact, all google mainboards (kukui, asurada, cherry) do have a different implementation as `gpio_output(GPIO_RESET, 1);`.
@Rex, which is the right way to do secondary reset?
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/484d918a_542f6b77
PS4, Line 23: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
add a comment before this:
/* do a secondary reset. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/57270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52
Gerrit-Change-Number: 57270
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 00:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment