Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Yu-Ping Wu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: preserve WDT reset reason for debugging
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/44d0ed08_110e2e46
PS2, Line 22: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
the common/reset.c may be overridden by mainboard reset. […]
ah, didn't see that only mt8173 adds that file to the build. only did a quick git grep of that register name when i was wondering what that line does when i went through the list of patches that were ready to submit at that time
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52
Gerrit-Change-Number: 57270
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 00:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment