coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: soc/rockchip/rk3399/sdram: Add channel to error message
by Julius Werner (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Moritz Fischer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51127 ) Change subject: soc/rockchip/rk3399/sdram: Add channel to error message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4109bd0573e3d9f90d699d89350ddbcc48714d3 Gerrit-Change-Number: 51127 Gerrit-PatchSet: 1 Gerrit-Owner: Moritz Fischer <moritzf(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Moritz Fischer <moritzf(a)google.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:50:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/rockchip/rk3399/sdram: Simplify error condition
by Julius Werner (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Moritz Fischer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51126 ) Change subject: soc/rockchip/rk3399/sdram: Simplify error condition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72612af4108a616b6247ee68c8ac2a53242b0853 Gerrit-Change-Number: 51126 Gerrit-PatchSet: 1 Gerrit-Owner: Moritz Fischer <moritzf(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Moritz Fischer <moritzf(a)google.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:50:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendor: mediatek: Add mediatek mt8192 dram initialization codes
by Julius Werner (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Angel Pons. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 ) Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes ...................................................................... Patch Set 16: (3 comments) File src/vendorcode/mediatek/Kconfig: https://review.coreboot.org/c/coreboot/+/50294/comment/75c0fbb5_7a6835f8 PS16, Line 3: config DEBUG_DRAM : bool "Output verbose DRAM related debug messages" : default y : help : This option enables additional DRAM related debug messages. > I wonder if we can revise it to something like [...] That construct will not compile-time eliminate the debug strings from non-debug images, I think for performance you want something where the check is performed on a constant. (You can still move the Kconfig to the SoC directory if you want, of course. That would probably be a bit nicer for menuconfig because the SoC-stuff is not weirdly split apart between different menus.) File src/vendorcode/mediatek/mt8192/dramc/ANA_init_config.c: PS13: > > Even vendorcode files always need to have an SPDX header […] I assume that is more about SPDX specifically than about the license in general. I can see that for example the AMD Agesa files have old-style non-SPDX license headers (but with a BSD-style license), and maybe there were concerns about touching that. Maybe Martin or Patrick know more details. I think we should probably change that to only exclude specific subdirectories in vendorcode from the SPDX check if necessary. But anyway, legally these files don't need an SPDX header specifically but they absolutely need a (GPL-compatible) license. This code is directly linked into GPL files, and distributing the resulting binaries wouldn't be legal without that. The easiest way to fix that would be for MediaTek to just adopt SPDX headers for this code. File src/vendorcode/mediatek/mt8192/dramc/ANA_init_config.c: https://review.coreboot.org/c/coreboot/+/50294/comment/3c314ebd_d2d96a38 PS16, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ Just from a practical perspective: while I do love the GPL and want everyone to use it in general, please be aware that if you make this GPL and if later someone else makes any change to this code that you want to sync back to your internally-tracked version for whatever reason, your internal version will become GPL (meaning you need to release sources for any other image you use that code in as well). So if it's not your intention to open source every firmware you use this code in, you may want to make this BSD-3-Clause instead to avoid those problems. (You can also write "GPL-2.0-only OR BSD-3-Clause" to explicitly dual-license it.) I know that you generally intend this code to just be a one-way street from you to coreboot, but just in case some situation comes up where you'd want to sync something back from here, it would be stupid if licensing details cause that to turn into a huge problem then. -- To view, visit https://review.coreboot.org/c/coreboot/+/50294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4 Gerrit-Change-Number: 50294 Gerrit-PatchSet: 16 Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com> Gerrit-CC: Joel Kitching <kitching(a)google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-CC: Yidi Lin <yidi.lin(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c: sx9310: Replace register map with descriptive names
by Gwendal Grignou (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Julius Werner. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50210 ) Change subject: drivers/i2c: sx9310: Replace register map with descriptive names ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50210/comment/75b233a1_a2a6a9f4 PS4, Line 7: drivers/i2c: sx9310: Use open source variables > Maybe: […] Done File src/drivers/i2c/sx9310/registers.h: https://review.coreboot.org/c/coreboot/+/50210/comment/835b41a4_e0fe9154 PS4, Line 7: reg_prox_ctrl0 > Another board needs to be fixed along with this: nocturne (https://qa.coreboot. […] Done File src/mainboard/google/hatch/variants/mushu/overridetree.cb: https://review.coreboot.org/c/coreboot/+/50210/comment/3bd7f8d0_851dc461 PS4, Line 158: - > _ instead of - […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/50210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b Gerrit-Change-Number: 50210 Gerrit-PatchSet: 4 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:38:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c: sx9310: Replace register map with descriptive names
by Gwendal Grignou (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Julius Werner, Gwendal Grignou. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50210 to look at the new patch set (#5). Change subject: drivers/i2c: sx9310: Replace register map with descriptive names ...................................................................... drivers/i2c: sx9310: Replace register map with descriptive names The current driver is using chip registers map to configure the SAR sensor, which is opaque, especially when the datasheet is not published widely. Use more descriptive names, as defined in Linux kernel documentation at https://www.kernel.org/doc/Documentation/devicetree/bindings/iio/proximity/… BUG=b:173341604 BRANCH=volteer TEST=Dump all tables, check semtech property: for i in $(find /sys/firmware/acpi/tables/ -type f) ; do f=$(basename $i); cat $i > /tmp/$f.dat ; iasl -d /tmp/$f.dat done In SSDT.dsl, we have: Package (0x06) { Package (0x02) { "semtech,cs0-ground", Zero }, Package (0x02) { "semtech,startup-sensor", Zero }, Package (0x02) { "semtech,proxraw-strength", Zero }, Package (0x02) { "semtech,avg-pos-strength", 0x0200 }, Package (0x02) { "semtech,combined-sensors", Package (0x03) { Zero, One, 0x02 } }, Package (0x02) { "semtech,resolution", "finest" } } Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b Signed-off-by: Gwendal Grignou <gwendal(a)chromium.org> --- M src/drivers/i2c/sx9310/chip.h D src/drivers/i2c/sx9310/registers.h M src/drivers/i2c/sx9310/sx9310.c M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/mushu/overridetree.cb M src/mainboard/google/octopus/variants/bobba/overridetree.cb M src/mainboard/google/volteer/variants/halvor/overridetree.cb M src/mainboard/google/volteer/variants/malefor/overridetree.cb M src/mainboard/google/volteer/variants/trondo/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 12 files changed, 159 insertions(+), 247 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/50210/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/50210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b Gerrit-Change-Number: 50210 Gerrit-PatchSet: 5 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] vc/amd/cezanne: add platform_Descriptors.c
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Marshall Dawson, Justin Frodsham, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: [WIP] vc/amd/cezanne: add platform_Descriptors.c ...................................................................... Patch Set 2: (1 comment) File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/2e3f34fe_3248fd2c PS2, Line 128: * Cezanne DXIO logical lane to physical PCIe lane mapping: to make review a bit easier: this is in "Figure 51: SERDES Configuration" from the nbio/pcie chapter of the ppr -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] vc/amd/cezanne: add platform_Descriptors.c
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Marshall Dawson, Justin Frodsham, Matt Papageorge. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: [WIP] vc/amd/cezanne: add platform_Descriptors.c ...................................................................... Patch Set 2: (2 comments) File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/51197/comment/16b8c76d_d18c2cc7 PS2, Line 108: EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init i'm not 100% sure about this and the next 3 https://review.coreboot.org/c/coreboot/+/51197/comment/b8d594c7_faa11a3a PS2, Line 159: Currently unused by FSP will those be used or not? i think at first we'll use them, but will end up removing the functionality from fsp, since coreboot can do that itself -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Justin Frodsham <justin.frodsham(a)protonmail.com> Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Configure tcss port information for early tcss init
by Brandon Breitenstein (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 ) Change subject: mb/google/volteer: Configure tcss port information for early tcss init ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/volteer/mainboard.c: https://review.coreboot.org/c/coreboot/+/51195/comment/058f9f4a_40a9264c PS1, Line 182: mux_info > I think you can still set the MAX_TYPE_C_PORTS to 4 and return num_ports based on what get_connector […] Done https://review.coreboot.org/c/coreboot/+/51195/comment/a1af89ae_efc46ecb PS1, Line 186: get_connector_config > Yeah that makes more sense then fetching all the devices should save some time only fetching them on […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I59e5c5a7d2ab5ef5293abe6c59c3a585b25f7b75 Gerrit-Change-Number: 51195 Gerrit-PatchSet: 2 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] vc/amd/cezanne: add platform_Descriptors.c
by Felix Held (Code Review) 02 Mar '21

02 Mar '21

Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/51197 ) Change subject: [WIP] vc/amd/cezanne: add platform_Descriptors.c ...................................................................... [WIP] vc/amd/cezanne: add platform_Descriptors.c Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 --- A src/vendorcode/amd/fsp/cezanne/platform_descriptors.h 1 file changed, 172 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/51197/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474 Gerrit-Change-Number: 51197 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
by Brandon Breitenstein (Code Review) 02 Mar '21

02 Mar '21

Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie, Patrick Rudolph. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 ) Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51194/comment/0129be51_49cd7d6e PS1, Line 12: the ports are not initialized till the ports are set to the appropriate mode. > In addition to setting the muxes to disconnected state, early_tcss driver is also setting up the por […] Done File src/soc/intel/tigerlake/early_tcss.c: https://review.coreboot.org/c/coreboot/+/51194/comment/29e58ec8_30e656ae PS1, Line 322: mainboard_tcss_get_port_info > it is acpi specific and I hate to abstract it out and create additional weirdness it also seems to b […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4 Gerrit-Change-Number: 51194 Gerrit-PatchSet: 3 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 03 Mar 2021 01:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021