Attention is currently required from: Marshall Dawson, Justin Frodsham, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: [WIP] vc/amd/cezanne: add platform_Descriptors.c
......................................................................
Patch Set 2:
(2 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/16b8c76d_d18c2cc7
PS2, Line 108: EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init
i'm not 100% sure about this and the next 3
https://review.coreboot.org/c/coreboot/+/51197/comment/b8d594c7_faa11a3a
PS2, Line 159: Currently unused by FSP
will those be used or not? i think at first we'll use them, but will end up removing the functionality from fsp, since coreboot can do that itself
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 01:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment