Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 )
Change subject: mb/google/volteer: Configure tcss port information for early tcss init
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51195/comment/058f9f4a_40a9264c
PS1, Line 182: mux_info
I think you can still set the MAX_TYPE_C_PORTS to 4 and return num_ports based on what get_connector […]
Done
https://review.coreboot.org/c/coreboot/+/51195/comment/a1af89ae_efc46ecb
PS1, Line 186: get_connector_config
Yeah that makes more sense then fetching all the devices should save some time only fetching them on […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59e5c5a7d2ab5ef5293abe6c59c3a585b25f7b75
Gerrit-Change-Number: 51195
Gerrit-PatchSet: 2
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 01:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment