Attention is currently required from: Andy Shevchenko, Paul Menzel, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51176 )
Change subject: src/drivers/i2c/rx6110sa: Add official ACPI ID
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45838162f014a760520692c6dcaae329ad98547d
Gerrit-Change-Number: 51176
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Andy Shevchenko <andy.shevchenko(a)gmail.com>
Gerrit-Reviewer: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Andy Shevchenko <andy.shevchenko(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 07:35:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Martin Roth, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51171 )
Change subject: mb/google/zork/var/vilboz: Update WiFi SAR for Vilboz
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi Google,
Would you help to merge the CL?
Then we can have official CPFE FW after cherry-picking it to zork firmware branch.
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51171
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I477b55d64fd9d33d753b10b2de443041a12d13e2
Gerrit-Change-Number: 51171
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 07:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Martin Roth, Tim Wawrzynczak, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51051 )
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 07:10:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: John Su, Martin Roth, Chris Wang, Rob Barnes.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51165 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7c5083c4c5affec5ae0b5583efb5237e10d0ec
Gerrit-Change-Number: 51165
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 06:50:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Henry Sun, zanxi chen, Paul Menzel, Andy Yeh, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> That means ODM needs to setup the related factory process to probe and provision the SSFC as well. […]
I have synced with Henry to provision the SSFC as early as possible. Can ODM team please raise a bug so that it gets provisioned in the upcoming build phase. I want to ensure that it is provisioned. The device can be probed and enabled in the devicetree later.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 06:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Andy Yeh <andy.yeh(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51177 )
Change subject: libpayload: Enable LTO by default
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
nvramcui fails to build due to problems with PDCurses:
```
LPGCC nvramcui.bin
curses/PDCurses/pdcurses/refresh.c: In function 'wrefresh':
curses/pdcurses-backend/pdcdisp.c:217:4: error: 'bg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
curses/pdcurses-backend/pdcdisp.c:214:18: note: 'bg' was declared here
curses/pdcurses-backend/pdcdisp.c:217:4: error: 'fg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
curses/pdcurses-backend/pdcdisp.c:214:14: note: 'fg' was declared here
lto1: all warnings being treated as errors
lto-wrapper: fatal error: i386-elf-gcc returned 1 exit status
compilation terminated.
/opt/xgcc/lib/gcc/i386-elf/8.3.0/../../../../i386-elf/bin/ld.bfd: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[2]: *** [../libpayload/Makefile.payload:91: build/nvramcui.bin] Error 1
make[2]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit/payloads/nvramcui'
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/51177
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc58034ea8a9510ddc08d61d19e75a7c6f9cbc7
Gerrit-Change-Number: 51177
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Comment-Date: Wed, 03 Mar 2021 05:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Angel Pons, Patrick Rudolph.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51205 )
Change subject: soc/intel/skylake: Do not unhide P2SB before disabling HECI
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/skylake/finalize.c:
https://review.coreboot.org/c/coreboot/+/51205/comment/63c30d23_456e680e
PS3, Line 37: p2sb_unhide();
> i don't really understand the motivation here. […]
We unconditionally hide P2SB at the end of `pch_finalize_script`, but may conditionally unhide it first if `HeciEnabled == 0`.
P2SB is either hidden or not hidden when `pch_finalize_script` is called. Therefore, either `pch_disable_heci` does both unhide and hide (P2SB was hidden) or `pch_disable_heci` does not need to unhide (P2SB was not hidden).
Testing showed that P2SB is not hidden when `pch_disable_heci` is called. Therefore remove that call. It's mainly a point of clarity.
I can improve the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide61392992db4d1ab74e1fff500000a427a87347
Gerrit-Change-Number: 51205
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 03 Mar 2021 05:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, zanxi chen, Paul Menzel, Andy Yeh, Weimin Wu, Karthik Ramasubramanian.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Re Karthik - That means we need to start implementing SSFC for Storo for now, right?
That means ODM needs to setup the related factory process to probe and provision the SSFC as well. If we decide to go, let's confirm and let me file an issue to track that with ODM.
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 04:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Andy Yeh <andy.yeh(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, zanxi chen, Paul Menzel, Andy Yeh, Weimin Wu, Karthik Ramasubramanian.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Hi Karthik, […]
Re Karthik - That means we need to start implementing SSFC for Storo for now, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 04:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Andy Yeh <andy.yeh(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment