coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7266 discussions

Change in coreboot[master]: mb/google/dedede/var/storo:Add P-sensor for storo
by zanxi chen (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Weimin Wu. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 ) Change subject: mb/google/dedede/var/storo:Add P-sensor for storo ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/dedede/variants/storo/overridetree.cb: https://review.coreboot.org/c/coreboot/+/51016/comment/18285d64_674c9a8d PS2, Line 210: register "reg_gnrl_ctrl0" = "0x0a" > Please mention that in the commit message. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8 Gerrit-Change-Number: 51016 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 01:43:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo:Add P-sensor for storo
by zanxi chen (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Weimin Wu. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Tao Xia, Weimin Wu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51016 to look at the new patch set (#4). Change subject: mb/google/dedede/var/storo:Add P-sensor for storo ...................................................................... mb/google/dedede/var/storo:Add P-sensor for storo Add P-sensor into devicetree for storo according to configuration information provided by the vendor. BUG=b:177392203 BRANCH=dedede TEST=built storo firmware and verified P-sensor function Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/storo/overridetree.cb 1 file changed, 68 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/51016/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8 Gerrit-Change-Number: 51016 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Add codec and speaker amplifier support
by zanxi chen (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Karthik Ramasubramanian. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51003 ) Change subject: mb/google/dedede/var/storo: Add codec and speaker amplifier support ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51003/comment/84cb3c79_bcb0c998 PS2, Line 8: speaker amplifier support into devicetree > Zanxi, […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia864ac47223adb80463966209f6ff3640b715378 Gerrit-Change-Number: 51003 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 01:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Add codec and speaker amplifier support
by zanxi chen (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Paul Menzel. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Tao Xia, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51003 to look at the new patch set (#4). Change subject: mb/google/dedede/var/storo: Add codec and speaker amplifier support ...................................................................... mb/google/dedede/var/storo: Add codec and speaker amplifier support Add audio codec and speaker amplifier support into devicetree BUG=b:179057895 BRANCH=dedede TEST=audio function is OK Change-Id: Ia864ac47223adb80463966209f6ff3640b715378 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/storo/overridetree.cb 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/51003/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia864ac47223adb80463966209f6ff3640b715378 Gerrit-Change-Number: 51003 Gerrit-PatchSet: 4 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Remove if-statement I forgot earlier
by Kevin Keijzer (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Kevin Keijzer. Hello Kevin Keijzer, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/51124 to review the following change. Change subject: Remove if-statement I forgot earlier ...................................................................... Remove if-statement I forgot earlier Change-Id: I55d7e682d1b7e2d0a786fcc800c7525edd2986ad Signed-off-by: Kevin Keijzer <kevin(a)quietlife.nl> --- M src/mainboard/lenovo/x200/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/51124/1 diff --git a/src/mainboard/lenovo/x200/mainboard.c b/src/mainboard/lenovo/x200/mainboard.c index 1337035..0fc77d3 100644 --- a/src/mainboard/lenovo/x200/mainboard.c +++ b/src/mainboard/lenovo/x200/mainboard.c @@ -17,7 +17,6 @@ GMA_INT15_BOOT_DISPLAY_DEFAULT, 2); dev->ops->acpi_fill_ssdt = fill_ssdt; - if (CONFIG(BOARD_LENOVO_X200)); } struct chip_operations mainboard_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/51124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55d7e682d1b7e2d0a786fcc800c7525edd2986ad Gerrit-Change-Number: 51124 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/lenovo/x200: Fix docking events
by Kevin Keijzer (Code Review) 01 Mar '21

01 Mar '21

Attention is currently required from: Bill XIE, Nico Huber, Arthur Heymans, Alexander Couzens, Patrick Rudolph, Kevin Keijzer. Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51118 ) Change subject: mb/lenovo/x200: Fix docking events ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Patchset: PS1: > I just did a checkout of 96ae7a3a2d38b96c1dfee57fda2c2eaab7e9e762 and then cherry-picked this one. […] Done PS1: > Maybe try to do something similar to CB:39708 on the X200. Done PS1: > The button on the side is also still broken, though Fn+F9 does work Done PS1: This change should fix the redocking being broken. I have pushed another change (CB:51123) for fixing the undocking after resume, which also seems to fix the undock button on the left side of the dock. TESTED on Lenovo X200 -- To view, visit https://review.coreboot.org/c/coreboot/+/51118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561e7ae81f2e096a091868ce51daa1c8f66af067 Gerrit-Change-Number: 51118 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Comment-Date: Mon, 01 Mar 2021 00:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kevin Keijzer Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021