Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 )
Change subject: mb/google/volteer: Configure tcss port information for early tcss init
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51195/comment/a4f1c2a4_4ca7661a
PS1, Line 182: mux_info
> mux_info is never really allocated space. So, this code ends up writing at address 0. […]
My only thing with this is how would we define MAX_TYPE_C_PORTS? for TGL that is 4 but we are only using 2 on Chrome in most cases. That is the only reason I did it as I did cause then we can just count the ports based on each devicetree of the board.
https://review.coreboot.org/c/coreboot/+/51195/comment/a75827a5_01c7e8fd
PS1, Line 186: get_connector_config
> This function can be called with mux as a pointer rather than having to fetch mux pointer every time […]
Yeah that makes more sense then fetching all the devices should save some time only fetching them once
--
To view, visit https://review.coreboot.org/c/coreboot/+/51195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59e5c5a7d2ab5ef5293abe6c59c3a585b25f7b75
Gerrit-Change-Number: 51195
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, John Zhao, Duncan Laurie, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 )
Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/51194/comment/9e04b787_e76fbc37
PS1, Line 322: mainboard_tcss_get_port_info
> Aah that intent was definitely not clear from the callbacks. […]
There is a static helper function in ec_acpi.c that could be repurposed for this, `get_usb_port_references`. Right now, it stuffs out parameters with references to the `struct device *` USB2/3/4 ports for the given Type-C port; those references contain the port numbers in the `path` member (port_type == 2/3/4, and port_id is the 0-based port ID.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4
Gerrit-Change-Number: 51194
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie, Brandon Breitenstein.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 )
Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/51194/comment/b685bded_225c2ec2
PS1, Line 322: mainboard_tcss_get_port_info
> The reason it was done this way was to avoid any calling to EC/other FWs to get the information for […]
Aah that intent was definitely not clear from the callbacks. What do you think about splitting the structure into two as well:
instead of
struct tcss_mux {
bool dp; /* DP connected */
bool usb; /* USB connected */
bool cable; /* Activ/Passive Cable */
bool polarity; /* polarity of connected device */
bool hpd_lvl; /* HPD Level assert */
bool hpd_irq; /* HPD IRQ assert */
bool ufp;
bool acc;
uint8_t dp_mode; /* DP Operation Mode */
uint8_t usb3_port; /* USB2 Port Number */
uint8_t usb2_port; /* USB3 Port Number */
};
define:
struct tcss_port_map {
uint8_t usb3_port; /* USB2 Port Number */
uint8_t usb2_port; /* USB3 Port Number */
};
struct tcss_port_mux_config {
bool dp; /* DP connected */
bool usb; /* USB connected */
bool cable; /* Activ/Passive Cable */
bool polarity; /* polarity of connected device */
bool hpd_lvl; /* HPD Level assert */
bool hpd_irq; /* HPD IRQ assert */
bool ufp;
bool acc;
uint8_t dp_mode; /* DP Operation Mode */
};
and then the callbacks can be named:
mainboard_get_tcss_port_map()
mainboard_get_tcss_mux_config()
Current function can do this:
Step 1: Get MUX port map using mainboard_get_tcss_port_map()
Step 2: Reset MUX to disconnected state and set up USB2/3 port mapping
Step 3: If display init is not required, return.
Step 4: For each port, in the above map, request MUX config using mainboard_get_tcss_mux_config and call tcss_configure_dp_mode for it.
I am not sure if there is a better way to get USB2/3 port mapping from the devicetree directly. Tim might have some pointers since he has looked closely at that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4
Gerrit-Change-Number: 51194
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:19:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-MessageType: comment
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51196 )
Change subject: google/trogdor: Fix trogdor-rev1 eDP power GPIO
......................................................................
google/trogdor: Fix trogdor-rev1 eDP power GPIO
Looks like I forgot about trogdor-rev1 in CB:51004. Unlike rev0 (other
special case) or rev2 (works like CoachZ/Homestar), rev1 used the same
pin as Lazor and Pompom for EN_PP3300_DX_EDP. Apparently there are still
some people using these, so add in another special case for that.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I7093aa63778d69fde240af3b0c62b97ac99c28dc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51196
Reviewed-by: Douglas Anderson <dianders(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/trogdor/board.h
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Douglas Anderson: Looks good to me, approved
diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index fb0852b..79dafc0 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -18,9 +18,10 @@
#define GPIO_BACKLIGHT_ENABLE GPIO(12)
#define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
#define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
+ (CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() == 1 ? GPIO(30) : \
(CONFIG(BOARD_GOOGLE_COACHZ) && board_id() == 0 ? GPIO(52) : \
(CONFIG(BOARD_GOOGLE_LAZOR) || CONFIG(BOARD_GOOGLE_POMPOM) ? GPIO(30) : \
- GPIO(67))))
+ GPIO(67)))))
/* Fingerprint-specific GPIOs. Only for fingerprint-enabled devices (e.g. CoachZ). */
#if CONFIG(TROGDOR_HAS_FINGERPRINT)
--
To view, visit https://review.coreboot.org/c/coreboot/+/51196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7093aa63778d69fde240af3b0c62b97ac99c28dc
Gerrit-Change-Number: 51196
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Xuxin Xiong.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51004 )
Change subject: mb/google/trogdor: Add new configs homestar
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/51004/comment/c95dec16_dfd5f30b
PS9, Line 20: #define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
: (CONFIG(BOARD_GOOGLE_COACHZ) && board_id() == 0 ? GPIO(52) : \
: (CONFIG(BOARD_GOOGLE_LAZOR) || CONFIG(BOARD_GOOGLE_POMPOM) ? GPIO(30) : \
: GPIO(67))))
> Am I reading it right that trogdor-rev1 is broken here? For trogdors: […]
Right, sorry. Fix: CB:51196
--
To view, visit https://review.coreboot.org/c/coreboot/+/51004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0f9b6c89198a882acae7191d08b166eb8c1dd71
Gerrit-Change-Number: 51004
Gerrit-PatchSet: 9
Gerrit-Owner: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Wai-Hong Tam <waihong(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Douglas Anderson <dianders(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51196 )
Change subject: google/trogdor: Fix trogdor-rev1 eDP power GPIO
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Whee!
--
To view, visit https://review.coreboot.org/c/coreboot/+/51196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7093aa63778d69fde240af3b0c62b97ac99c28dc
Gerrit-Change-Number: 51196
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Douglas Anderson.
Hello Douglas Anderson,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/51196
to review the following change.
Change subject: google/trogdor: Fix trogdor-rev1 eDP power GPIO
......................................................................
google/trogdor: Fix trogdor-rev1 eDP power GPIO
Looks like I forgot about trogdor-rev1 in CB:51004. Unlike rev0 (other
special case) or rev2 (works like CoachZ/Homestar), rev1 used the same
pin as Lazor and Pompom for EN_PP3300_DX_EDP. Apparently there are still
some people using these, so add in another special case for that.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I7093aa63778d69fde240af3b0c62b97ac99c28dc
---
M src/mainboard/google/trogdor/board.h
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/51196/1
diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index fb0852b..79dafc0 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -18,9 +18,10 @@
#define GPIO_BACKLIGHT_ENABLE GPIO(12)
#define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
#define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
+ (CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() == 1 ? GPIO(30) : \
(CONFIG(BOARD_GOOGLE_COACHZ) && board_id() == 0 ? GPIO(52) : \
(CONFIG(BOARD_GOOGLE_LAZOR) || CONFIG(BOARD_GOOGLE_POMPOM) ? GPIO(30) : \
- GPIO(67))))
+ GPIO(67)))))
/* Fingerprint-specific GPIOs. Only for fingerprint-enabled devices (e.g. CoachZ). */
#if CONFIG(TROGDOR_HAS_FINGERPRINT)
--
To view, visit https://review.coreboot.org/c/coreboot/+/51196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7093aa63778d69fde240af3b0c62b97ac99c28dc
Gerrit-Change-Number: 51196
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie, Brandon Breitenstein.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 )
Change subject: mb/google/volteer: Configure tcss port information for early tcss init
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51195/comment/26524ff8_d2f69754
PS1, Line 182: mux_info
mux_info is never really allocated space. So, this code ends up writing at address 0. As mentioned on the SoC CL, I think this should return a pointer to the table rather than expecting SoC to pass in allocated space:
const struct tcss_mux *mainboard_get_tcss_mux_info(size_t *num_ports)
{
static struct tcss_mux mux_info[MAX_TYPE_C_PORTS];
size_t port;
*num_ports = ARRAY_SIZE(mux_info);
for (port = 0; port < *num_ports; port++) {
...
}
return mux_info;
}
https://review.coreboot.org/c/coreboot/+/51195/comment/22bf1e66_3ce4af91
PS1, Line 186: get_connector_config
This function can be called with mux as a pointer rather than having to fetch mux pointer every time.
const struct device *pmc;
const struct device *mux;
*num_ports = 0;
pmc = pcidev_path_on_root(PCH_DEVFN_PMC);
if (!pmc)
return NULL;
mux = pmc->link_list->children;
if (!mux)
return NULL;
*num_ports = ARRAY_SIZE(mux_info);
for (port = 0; port < *num_ports; port++) {
mux_config = get_connector_config(mux, port);
if (mux_config == NULL)
continue;
mux_info[port].usb2_port = ...;
...
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/51195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59e5c5a7d2ab5ef5293abe6c59c3a585b25f7b75
Gerrit-Change-Number: 51195
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 22:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 )
Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/51194/comment/415551ed_8d87a32a
PS1, Line 322: mainboard_tcss_get_port_info
> I don't think you need another callback here. […]
The reason it was done this way was to avoid any calling to EC/other FWs to get the information for the entire mux configuration. This call simply gets only the mux and port map information to avoid any unwanted delays on systems that do not need the entire display stack implemented
--
To view, visit https://review.coreboot.org/c/coreboot/+/51194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4
Gerrit-Change-Number: 51194
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 22:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment