coreboot-gerrit March 2021

coreboot-gerrit@coreboot.org

1 participants
7263 discussions

Change in coreboot[master]: mb/google/zork: add UPDM updating function before runing FSP-M
by chris wang (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: EricR Lai. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51181 ) Change subject: mb/google/zork: add UPDM updating function before runing FSP-M ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/zork/romstage.c: https://review.coreboot.org/c/coreboot/+/51181/comment/45466fd1_0e9bc74a PS2, Line 3: #include <baseboard/variants.h> > I mean <console/console.h> <console/uart.h>..etc. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4954a438a51b29b086015624127e651fd06f971b Gerrit-Change-Number: 51181 Gerrit-PatchSet: 4 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: chris wang <Chris.Wang(a)amd.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: add UPDM updating function before runing FSP-M
by chris wang (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: chris wang. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Patrick Georgi, Martin Roth, Marshall Dawson, Chris Wang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51181 to look at the new patch set (#4). Change subject: mb/google/zork: add UPDM updating function before runing FSP-M ...................................................................... mb/google/zork: add UPDM updating function before runing FSP-M Add the UPD updating hook in early stage for customization. BUG=b:117719313 BRANCH=zork TEST=build,check the hook function been executed. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: I4954a438a51b29b086015624127e651fd06f971b --- M src/mainboard/google/zork/Makefile.inc A src/mainboard/google/zork/romstage.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/soc/amd/picasso/include/soc/romstage.h M src/soc/amd/picasso/romstage.c 6 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/51181/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4954a438a51b29b086015624127e651fd06f971b Gerrit-Change-Number: 51181 Gerrit-PatchSet: 4 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
by chris wang (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: John Su, Martin Roth, Paul Menzel, Chris Wang, chris wang. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 ) Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/49683/comment/dc5a5faa_0bf2c010 PS6, Line 13: BRANCH=zork > How is this tested? Maybe paste the new log messages? Just a debug print before upload. ------------------------------------------------ image ID: AMD_PCS0, base 0x20c0000 + 0x4b000 Config region 0x46cec + 0x104 Memory init offset 0x7b8 POST: 0x34 bootmode is set to: 0 CW variant_updm_update telemetry_vddcr_vdd_slope_mA: 32453 telemetry_vddcr_vdd_offset: 168 telemetry_vddcr_soc_slope_mA: 22644 telemetry_vddcr_soc_offset: -70 POST: 0x36 Calling FspMemoryInit: 0x020c07b8 0x02000dec: raminit_upd 0x0204d57c: &hob_list_ptr ------------------------------------------------- -- To view, visit https://review.coreboot.org/c/coreboot/+/49683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d Gerrit-Change-Number: 49683 Gerrit-PatchSet: 7 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:30:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
by EricR Lai (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: John Su, Martin Roth, Chris Wang, chris wang. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 ) Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/zork/variants/vilboz/romstage.c: https://review.coreboot.org/c/coreboot/+/49683/comment/00f37122_8a3d9773 PS6, Line 3: #include <baseboard/variants.h> > it consumed by variant_updm_update. so keep the header file. I mean #include <console/uart.h> #include <fw_config.h> #include <soc/pci_devs.h> #include <fw_config.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/49683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d Gerrit-Change-Number: 49683 Gerrit-PatchSet: 7 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: chris wang <Chris.Wang(a)amd.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
by chris wang (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: John Su, Martin Roth, Chris Wang, EricR Lai. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 ) Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC ...................................................................... Patch Set 7: (3 comments) Patchset: PS6: > I would suggest call the file like variant.c not romstage. […] it use the romstage to align picasso/romstage, and try to avoid to confuse another varinat.c but I think it's a open option. File src/mainboard/google/zork/variants/vilboz/romstage.c: https://review.coreboot.org/c/coreboot/+/49683/comment/ad150a62_4a202ccd PS3, Line 22: } > adding a line without newline at end of file File src/mainboard/google/zork/variants/vilboz/romstage.c: https://review.coreboot.org/c/coreboot/+/49683/comment/0f8285bc_87da58a3 PS6, Line 3: #include <baseboard/variants.h> > please remove unused header. it consumed by variant_updm_update. so keep the header file. -- To view, visit https://review.coreboot.org/c/coreboot/+/49683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d Gerrit-Change-Number: 49683 Gerrit-PatchSet: 7 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:21:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: add UPDM updating function before runing FSP-M
by EricR Lai (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: chris wang. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51181 ) Change subject: mb/google/zork: add UPDM updating function before runing FSP-M ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/zork/romstage.c: https://review.coreboot.org/c/coreboot/+/51181/comment/5e3f1839_5734bc2b PS2, Line 3: #include <baseboard/variants.h> > it still need used for void __weak variant_updm_update(FSP_M_CONFIG *mcfg) {} […] I mean <console/console.h> <console/uart.h>..etc. -- To view, visit https://review.coreboot.org/c/coreboot/+/51181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4954a438a51b29b086015624127e651fd06f971b Gerrit-Change-Number: 51181 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:19:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: chris wang <Chris.Wang(a)amd.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: add UPDM updating function before runing FSP-M
by chris wang (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: EricR Lai. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51181 ) Change subject: mb/google/zork: add UPDM updating function before runing FSP-M ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/zork/romstage.c: https://review.coreboot.org/c/coreboot/+/51181/comment/d3c5b85d_973c11f9 PS2, Line 3: #include <baseboard/variants.h> > please remove the unused header. it still need used for void __weak variant_updm_update(FSP_M_CONFIG *mcfg) {} so keep the header file. File src/mainboard/google/zork/variants/vilboz/Makefile.inc: https://review.coreboot.org/c/coreboot/+/51181/comment/e2cf35bc_45be1e36 PS2, Line 5: romstage-y += romstage.c > this should be in another CL. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4954a438a51b29b086015624127e651fd06f971b Gerrit-Change-Number: 51181 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 04 Mar 2021 07:16:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory wi...
by Furquan Shaikh (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: Kevin Chang, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB ...................................................................... Patch Set 7: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51200/comment/6aa1a37f_f8fb9f62 PS7, Line 10: judement MB identify build File src/mainboard/google/volteer/variants/lindar/memory.c: https://review.coreboot.org/c/coreboot/+/51200/comment/23763586_7cc1c50d PS6, Line 4: #include <memory_info.h> Is this required? https://review.coreboot.org/c/coreboot/+/51200/comment/9e9293e3_d2a8bbef PS6, Line 5: #include <fw_config.h> Is this required? https://review.coreboot.org/c/coreboot/+/51200/comment/245739aa_0b89f7ad PS6, Line 7: #include <soc/romstage.h> Is this required? https://review.coreboot.org/c/coreboot/+/51200/comment/c6cbbe69_29debf18 PS6, Line 72: (google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1 Use board_id() instead because it stashes the board_version once it is read from the EC in a particular stage and avoids multiple calls to the EC. https://review.coreboot.org/c/coreboot/+/51200/comment/d6f5b289_28132f1b PS6, Line 73: mem_cfg->SaGv I usually recommend not touching the UPDs in mainboard. But given that this is a temporary workaround, I think it is okay. Can you please file a separate bug to ensure that this workaround gets dropped once board version 1 is deprecated? -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 7 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Mar 2021 06:35:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory wi...
by Zhuohao Lee (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: Kevin Chang, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 ) Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f Gerrit-Change-Number: 51200 Gerrit-PatchSet: 7 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Mar 2021 06:18:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Add USB2 PHY parameters
by Tao Xia (Code Review) 04 Mar '21

04 Mar '21

Attention is currently required from: Tao Xia. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51247 to look at the new patch set (#2). Change subject: mb/google/dedede/var/sasukette: Add USB2 PHY parameters ...................................................................... mb/google/dedede/var/sasukette: Add USB2 PHY parameters This change adds fine-tuned USB2 PHY parameters for sasukette. BUG=180753635 TEST=Built and verified USB2 eye diagram test result Signed-off-by: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Change-Id: I5612e7dcca15b340763dee1475e979ee551a2146 --- M src/mainboard/google/dedede/variants/sasukette/overridetree.cb 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/51247/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5612e7dcca15b340763dee1475e979ee551a2146 Gerrit-Change-Number: 51247 Gerrit-PatchSet: 2 Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2021