Attention is currently required from: EricR Lai.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51181 )
Change subject: mb/google/zork: add UPDM updating function before runing FSP-M
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/zork/romstage.c:
https://review.coreboot.org/c/coreboot/+/51181/comment/d3c5b85d_973c11f9
PS2, Line 3: #include <baseboard/variants.h>
please remove the unused header.
it still need used for void __weak variant_updm_update(FSP_M_CONFIG *mcfg) {}
so keep the header file.
File src/mainboard/google/zork/variants/vilboz/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51181/comment/e2cf35bc_45be1e36
PS2, Line 5: romstage-y += romstage.c
this should be in another CL.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4954a438a51b29b086015624127e651fd06f971b
Gerrit-Change-Number: 51181
Gerrit-PatchSet: 3
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 07:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment