Attention is currently required from: Kevin Chang, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB ......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51200/comment/6aa1a37f_f8fb9f62 PS7, Line 10: judement MB identify build
File src/mainboard/google/volteer/variants/lindar/memory.c:
https://review.coreboot.org/c/coreboot/+/51200/comment/23763586_7cc1c50d PS6, Line 4: #include <memory_info.h> Is this required?
https://review.coreboot.org/c/coreboot/+/51200/comment/9e9293e3_d2a8bbef PS6, Line 5: #include <fw_config.h> Is this required?
https://review.coreboot.org/c/coreboot/+/51200/comment/245739aa_0b89f7ad PS6, Line 7: #include <soc/romstage.h> Is this required?
https://review.coreboot.org/c/coreboot/+/51200/comment/c6cbbe69_29debf18 PS6, Line 72: (google_chromeec_get_board_version(&board_version) == 0) && (board_version == 1 Use board_id() instead because it stashes the board_version once it is read from the EC in a particular stage and avoids multiple calls to the EC.
https://review.coreboot.org/c/coreboot/+/51200/comment/d6f5b289_28132f1b PS6, Line 73: mem_cfg->SaGv I usually recommend not touching the UPDs in mainboard. But given that this is a temporary workaround, I think it is okay. Can you please file a separate bug to ensure that this workaround gets dropped once board version 1 is deprecated?