Attention is currently required from: John Su, Martin Roth, Chris Wang, chris wang.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 )
Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/romstage.c:
https://review.coreboot.org/c/coreboot/+/49683/comment/00f37122_8a3d9773
PS6, Line 3: #include <baseboard/variants.h>
it consumed by variant_updm_update. so keep the header file.
I mean #include <console/uart.h> #include <fw_config.h> #include <soc/pci_devs.h> #include <fw_config.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d
Gerrit-Change-Number: 49683
Gerrit-PatchSet: 7
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 07:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment