Attention is currently required from: John Su, Martin Roth, Chris Wang, EricR Lai.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 )
Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS6:
I would suggest call the file like variant.c not romstage. […]
it use the romstage to align picasso/romstage, and try to avoid to confuse another varinat.c but I think it's a open option.
File src/mainboard/google/zork/variants/vilboz/romstage.c:
https://review.coreboot.org/c/coreboot/+/49683/comment/ad150a62_4a202ccd
PS3, Line 22: }
adding a line without newline at end of file
File src/mainboard/google/zork/variants/vilboz/romstage.c:
https://review.coreboot.org/c/coreboot/+/49683/comment/0f8285bc_87da58a3
PS6, Line 3: #include <baseboard/variants.h>
please remove unused header.
it consumed by variant_updm_update. so keep the header file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d
Gerrit-Change-Number: 49683
Gerrit-PatchSet: 7
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 07:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment