Attention is currently required from: Hung-Te Lin.
Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51203 )
Change subject: src/mediatek/common: Move DRAM implementation from mt8192 to common
......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS1:
> Hmmm. Can you try to do 'move' instead of 'add'? […]
OK.
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/51203/comment/7a4f359a_b0c0a1e3
PS1, Line 1: config MEDIATEK_DRAM_DVFS
: bool
: default n
: help
: This option enables DRAM calibration with multiple frequencies (low,
: medium and high frequency groups, with total 7 frequencies) for DVFS
: feature. All supported data rates are: 800, 1200, 1600, 1866, 2400,
: 3200, 4266.
:
: config MEDIATEK_DRAM_DVFS_LIMIT_FREQ_CNT
: bool
: default y
: select MEDIATEK_DRAM_DVFS
: help
: This options limit DRAM frequency calibration count from total 7 to 3,
: other frequency will directly use the low frequency shu result.
:
: config MEMORY_TEST
: bool
: default y
: help
: This option enables memory basic compare test to verify the DRAM read
: or write is as expected.
:
> I think we have to move this to an if-block so only MTK platforms will have these options, otherwise […]
Got it, i thought that soc/mediatek/xxx are only for MEDIATEK SOCs, right, needs to add SOC_MEDIATEK_COMMON config.
File src/soc/mediatek/common/dram_init.c:
https://review.coreboot.org/c/coreboot/+/51203/comment/e58e03d8_fb0ac1f4
PS1, Line 10: extern void (*do_putc)(unsigned char c);
> I think we don't need this anymore?
yes, no need, remove it.
https://review.coreboot.org/c/coreboot/+/51203/comment/96f2d5f3_4bf7e3ad
PS1, Line 30: const
> If mt_set_emi can't take const, what about just removing the const for init_dram_by_params? […]
Ack
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/51203/comment/87b4c148_8665c388
PS1, Line 28: } else {
: printk(BIOS_DEBUG, "[MEM] complex R/W mem test passed\n");
: }
:
> remove the else and move the printk to either add printing rank number, or move to outside of the fo […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I557c96b3d09828472b8b6f932b0192a90894043e
Gerrit-Change-Number: 51203
Gerrit-PatchSet: 3
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Mar 2021 06:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Martin Roth.
Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51202 )
Change subject: mb/google/asurada: Add generic DRAM groups
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> need ddr_type in sdram struct.
rebase parent to CB:51125.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51202
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ee170c159e551e840ab4e748f18f5149506b4f
Gerrit-Change-Number: 51202
Gerrit-PatchSet: 2
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 06:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Xi Chen.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51203
to look at the new patch set (#3).
Change subject: src/mediatek/common: Move DRAM implementation from mt8192 to common
......................................................................
src/mediatek/common: Move DRAM implementation from mt8192 to common
To reduce duplicated dram sources on seperate SOCs,
add dpm, dram_init, dramc_params, memory(fast-k or full-k)
implementations, also add dramc log level macro header files.
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.com>
Change-Id: I557c96b3d09828472b8b6f932b0192a90894043e
---
A src/soc/mediatek/common/Kconfig
A src/soc/mediatek/common/dpm.c
A src/soc/mediatek/common/dram_init.c
A src/soc/mediatek/common/dramc_param.c
A src/soc/mediatek/common/include/soc/dpm.h
A src/soc/mediatek/common/include/soc/dramc_common.h
A src/soc/mediatek/common/include/soc/dramc_param.h
A src/soc/mediatek/common/include/soc/emi.h
A src/soc/mediatek/common/memory.c
M src/soc/mediatek/mt8173/Kconfig
M src/soc/mediatek/mt8183/Kconfig
M src/soc/mediatek/mt8192/Kconfig
12 files changed, 661 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/51203/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I557c96b3d09828472b8b6f932b0192a90894043e
Gerrit-Change-Number: 51203
Gerrit-PatchSet: 3
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Cindy Ching, Martin Roth, Shaoming Chen, Paul Menzel, Duan huayang.
Hello Hung-Te Lin, build bot (Jenkins), Cindy Ching, Patrick Georgi, Martin Roth, Shaoming Chen, Duan huayang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51125
to look at the new patch set (#16).
Change subject: src/mediatek/mt8192: use Mediatek mt8192 vendor code (CB:50294)
......................................................................
src/mediatek/mt8192: use Mediatek mt8192 vendor code (CB:50294)
Mediatek maintains the DRAM initialization code, the coding style
is different from coreboot, when CB:50294 is ready, soc/mediatek/mt8192
will not be used.
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.com>
Change-Id: I2b2f41d774c6b85f106867144fb0b29a4a1bdfcf
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/Makefile.inc
D src/soc/mediatek/mt8192/dpm.c
D src/soc/mediatek/mt8192/dramc_dvfs.c
D src/soc/mediatek/mt8192/dramc_param.c
D src/soc/mediatek/mt8192/dramc_pi_basic_api.c
D src/soc/mediatek/mt8192/dramc_pi_calibration_api.c
D src/soc/mediatek/mt8192/dramc_pi_main.c
D src/soc/mediatek/mt8192/dramc_utility.c
D src/soc/mediatek/mt8192/emi.c
D src/soc/mediatek/mt8192/include/soc/dpm.h
D src/soc/mediatek/mt8192/include/soc/dramc_ac_timing.h
D src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h
D src/soc/mediatek/mt8192/include/soc/dramc_param.h
D src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h
D src/soc/mediatek/mt8192/include/soc/dramc_register.h
D src/soc/mediatek/mt8192/include/soc/dramc_register_bits_def.h
A src/soc/mediatek/mt8192/include/soc/dramc_soc.h
D src/soc/mediatek/mt8192/include/soc/emi.h
D src/soc/mediatek/mt8192/memory.c
M src/vendorcode/Makefile.inc
21 files changed, 54 insertions(+), 13,159 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/51125/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/51125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b2f41d774c6b85f106867144fb0b29a4a1bdfcf
Gerrit-Change-Number: 51125
Gerrit-PatchSet: 16
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Duan huayang <huayang.duan(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Cindy Ching <cindy.ching(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Duan huayang <huayang.duan(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shaoming Chen, Yu-Ping Wu.
Hello Hung-Te Lin, build bot (Jenkins), Shaoming Chen, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51224
to look at the new patch set (#3).
Change subject: src/soc/mediatek/mt8173 & mt8183: use common dramc_xxx log macro
......................................................................
src/soc/mediatek/mt8173 & mt8183: use common dramc_xxx log macro
Use mediatek common dramc_xxx log macro instead of SOCs defined macro.
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.com>
Change-Id: Ifa483dcfffe0e1383cb46811563c90f0ab484d5d
---
M src/soc/mediatek/mt8173/Kconfig
M src/soc/mediatek/mt8173/dramc_pi_basic_api.c
M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h
M src/soc/mediatek/mt8183/Kconfig
M src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h
6 files changed, 79 insertions(+), 101 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/51224/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa483dcfffe0e1383cb46811563c90f0ab484d5d
Gerrit-Change-Number: 51224
Gerrit-PatchSet: 3
Gerrit-Owner: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Zhuohao Lee.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51200/comment/7e788c0c_a9415412
PS6, Line 9: EVT MB
> Please don't disclose the phase of the project in the commit message.
Hi Zhuohao
Update in patchset 7.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 7
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 06:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, Patrick Rudolph, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51200
to look at the new patch set (#7).
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB
......................................................................
mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB
Disable SA GV, because factory used Samsung memory with wrong date code.
So we need to use board version to judement MB phase to disable SA GV.
Disable SA GV when board version equal one.
BUG=b:179747696
BRANCH=firmware-volteer-13672.B
TEST=Built and booted into OS.
Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
---
M src/mainboard/google/volteer/romstage.c
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/volteer/variants/lindar/memory.c
3 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/51200/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 7
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset