Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51246 )
Change subject: soc/mediatek/mt8192: mt6315: revise initial setting
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51246/comment/608fb2eb_d904cfb4
PS1, Line 7: update
> are we updating this to fix a bug or simply revising?
It's not bug fix, just simply revising.
https://review.coreboot.org/c/coreboot/+/51246/comment/ed5343e8_1e53dae7
PS1, Line 9: According to current flow, we don't check the boot reason of mt6315, so
: removing the unused setting about boot status.
: Reset power-off sequence to zero to make sure it meets hardware
: requirement.
> - Remove unused boot status settings […]
In hw design, MT6315 should shutdown with power-of sequence only if the device is normal power-off. Otherwise, it should be shutdown immediately. We set it with no power-off sequence in the initial setting and enable the power-off sequence in the shutdown callback of MT6315 kernel regulator driver.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51246
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d39be532ec378bd6df6bf1b93307dae4068fc6
Gerrit-Change-Number: 51246
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
......................................................................
Patch Set 6: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:37:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51200/comment/3eb250fc_f557c2f1
PS6, Line 9: EVT MB
Please don't disclose the phase of the project in the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:36:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51245 )
Change subject: soc/mediatek/mt8192: mt6315: update initial flow
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51245/comment/dfeb52f9_1255486e
PS1, Line 9: programming guide
> please provide the name of that datasheet/guide (just the name would be enough, even better if you c […]
Done
https://review.coreboot.org/c/coreboot/+/51245/comment/8e4573d4_daa66e31
PS1, Line 11: Although there is no issue about it, we still want to update it in order
: to sync with programming guide.
:
> no need to have this comment :)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51245
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7f970a44904fda09a97f4064eef7c95feefad7
Gerrit-Change-Number: 51245
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, hsin-hsiung wang.
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51056 )
Change subject: soc/mediatek/mt8192: mt6315: update correct slave id
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51056/comment/619802a6_34fb5c02
PS1, Line 8:
> What problem does this fix?
Done
https://review.coreboot.org/c/coreboot/+/51056/comment/55699d22_fdfe77a6
PS1, Line 11: 2. update the correct sequence flow of the key protection.
> 1. Please start sentences with a capital letter. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/51056/comment/49e94a48_eb54995a
PS2, Line 9: We found the initial setting of MT6315 is not applied due to
: the wrong slave id.
: Update correct slave id to fix it.
> The initial settings for MT6315 was not applied correctly […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd04da8ac55bcc9f9fdbc088d430522c2725ad47
Gerrit-Change-Number: 51056
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-CC: Nicolas Boichat <drinkcat(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu, hsin-hsiung wang.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51056
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8192: mt6315: update correct slave id
......................................................................
soc/mediatek/mt8192: mt6315: update correct slave id
The initial settings for MT6315 was not applied correctly
because the setup process didn't specify correct slave id
(incorrectly always sending 0).
BUG=b:179000151
BRANCH=none
TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang(a)mediatek.com>
Change-Id: Ifd04da8ac55bcc9f9fdbc088d430522c2725ad47
---
M src/soc/mediatek/mt8192/mt6315.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/51056/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd04da8ac55bcc9f9fdbc088d430522c2725ad47
Gerrit-Change-Number: 51056
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicolas Boichat <drinkcat(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Yu-Ping Wu, hsin-hsiung wang.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51245
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8192: mt6315: update initial flow
......................................................................
soc/mediatek/mt8192: mt6315: update initial flow
After checking MT6315 PMIC protection key summary.xlsx and MT6315
Top and CLK programming guide.docx, we found there are something
wrong about the sequence of magic key protection flow and clk
setting. Update correct initial flow.
BUG=b:179000151
BRANCH=none
TEST=boot asurada correctly
Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang(a)mediatek.com>
Change-Id: I1b7f970a44904fda09a97f4064eef7c95feefad7
---
M src/soc/mediatek/mt8192/mt6315.c
M src/soc/mediatek/mt8192/pmif_spmi.c
2 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/51245/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51245
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7f970a44904fda09a97f4064eef7c95feefad7
Gerrit-Change-Number: 51245
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Julius Werner, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51174 )
Change subject: soc/mediatek/mt8192: Increase PRERAM_CBMEM_CONSOLE to 400K
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
sounds great - let's do that. do you need another CL to increase the KCONFIG value?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896884d298e197149f75865e9d00579124a34404
Gerrit-Change-Number: 51174
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment