Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, hsin-hsiung wang.
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51056 )
Change subject: soc/mediatek/mt8192: mt6315: update correct slave id
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51056/comment/619802a6_34fb5c02
PS1, Line 8:
What problem does this fix?
Done
https://review.coreboot.org/c/coreboot/+/51056/comment/55699d22_fdfe77a6
PS1, Line 11: 2. update the correct sequence flow of the key protection.
- Please start sentences with a capital letter. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/51056/comment/49e94a48_eb54995a
PS2, Line 9: We found the initial setting of MT6315 is not applied due to
: the wrong slave id.
: Update correct slave id to fix it.
The initial settings for MT6315 was not applied correctly […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd04da8ac55bcc9f9fdbc088d430522c2725ad47
Gerrit-Change-Number: 51056
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 05:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment