Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51246 )
Change subject: soc/mediatek/mt8192: mt6315: revise initial setting ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51246/comment/608fb2eb_d904cfb4 PS1, Line 7: update
are we updating this to fix a bug or simply revising?
It's not bug fix, just simply revising.
https://review.coreboot.org/c/coreboot/+/51246/comment/ed5343e8_1e53dae7 PS1, Line 9: According to current flow, we don't check the boot reason of mt6315, so : removing the unused setting about boot status. : Reset power-off sequence to zero to make sure it meets hardware : requirement.
- Remove unused boot status settings […]
In hw design, MT6315 should shutdown with power-of sequence only if the device is normal power-off. Otherwise, it should be shutdown immediately. We set it with no power-off sequence in the initial setting and enable the power-off sequence in the shutdown callback of MT6315 kernel regulator driver.