coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6507 discussions

Change in coreboot[master]: soc/intel/tigerlake: Enable TC Cold support
by Nick Vaccaro (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49244 ) Change subject: soc/intel/tigerlake: Enable TC Cold support ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: This change looks good, but I'm running into an unrelated flashrom failure that is currently keeping me from being able to verify that my volteer2 boots with this change. Has anyone checked this on a volteer2? -- To view, visit https://review.coreboot.org/c/coreboot/+/49244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ad0322693b4f8fbf1000b24eb21dddcebec686b Gerrit-Change-Number: 49244 Gerrit-PatchSet: 3 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 22:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/superiotool: add IT5570E registers
by Tim Wawrzynczak (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Michael Niewöhner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48922 ) Change subject: util/superiotool: add IT5570E registers ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: sorry this one got list in my inbox -- To view, visit https://review.coreboot.org/c/coreboot/+/48922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc764c6180e235298835d7639fcb0b562a2c21a4 Gerrit-Change-Number: 48922 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: unbreak compilation on FreeBSD
by Julius Werner (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Idwer Vollering. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49314 ) Change subject: util/cbfstool: unbreak compilation on FreeBSD ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: > Another approach is to append __BSD_VISIBLE to HOSTCFLAGS in Makefile. That would probably be a bit more in line with what we do for the glibc control macros, but doesn't really matter much either way. PS1: Well... in my defense I did check the FreeBSD man page (https://www.freebsd.org/cgi/man.cgi?query=flock&sektion=2) and it doesn't say anything about needing this. :P -- To view, visit https://review.coreboot.org/c/coreboot/+/49314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3433e4c9269880d3202dd494e5b2e962757a6b87 Gerrit-Change-Number: 49314 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/genesyslogic/gl9763e: Fix boot on eMMC failed issue on Volteer
by 陳建宏 (Code Review) 11 Jan '21

11 Jan '21

陳建宏 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48941 ) Change subject: drivers/genesyslogic/gl9763e: Fix boot on eMMC failed issue on Volteer ...................................................................... drivers/genesyslogic/gl9763e: Fix boot on eMMC failed issue on Volteer Boot on Kingston(EMMC64G-TA29/TX29-HP) and Hynix(H26M74002HMR) eMMC will be failed. This is a workaround for improving the compatibiliy between GL9763E(revision 03) and these two eMMC. Signed-off-by: Renius Chen <reniuschengl(a)gmail.com> Change-Id: Iddb145ed6a9edb2d7a50248e64659cda78b88ae6 --- M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/genesyslogic/gl9763e/gl9763e.h 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48941/1 diff --git a/src/drivers/genesyslogic/gl9763e/gl9763e.c b/src/drivers/genesyslogic/gl9763e/gl9763e.c index 48e520b..9b44215 100644 --- a/src/drivers/genesyslogic/gl9763e/gl9763e.c +++ b/src/drivers/genesyslogic/gl9763e/gl9763e.c @@ -12,6 +12,8 @@ static void gl9763e_init(struct device *dev) { + uint32_t ver; + printk(BIOS_INFO, "GL9763E: init\n"); pci_dev_init(dev); @@ -25,6 +27,12 @@ pci_update_config32(dev, PLL_CTL_2, ~PLL_CTL_2_MAX_SSC_MASK, MAX_SSC_30000PPM); /* Enable SSC */ pci_or_config32(dev, PLL_CTL, PLL_CTL_SSC); + /* Check CHIP version */ + ver = pci_read_config32(dev, HW_VER_2); + if ((ver & HW_VER_MASK) == REVISION_03) { + /* Set clock source for RX path */ + pci_update_config32(dev, SDCLKRX_DLY, ~CLK_SRC_MASK, AFTER_OUTPUT_BUFF); + } /* Set VHS to read-only */ pci_update_config32(dev, VHS, ~VHS_REV_MASK, VHS_REV_R); } diff --git a/src/drivers/genesyslogic/gl9763e/gl9763e.h b/src/drivers/genesyslogic/gl9763e/gl9763e.h index fd9c6ba..5cdaa68 100644 --- a/src/drivers/genesyslogic/gl9763e/gl9763e.h +++ b/src/drivers/genesyslogic/gl9763e/gl9763e.h @@ -21,3 +21,11 @@ #define PLL_CTL_2 0x93C #define PLL_CTL_2_MAX_SSC_MASK (0xFFFF << 16) #define MAX_SSC_30000PPM (0xF5C3 << 16) + +#define HW_VER_2 0x8F8 +#define HW_VER_MASK 0xFFFF +#define REVISION_03 0x0011 + +#define SD_CLKRX_DLY 0x934 +#define CLK_SRC_MASK (0x3 << 24) +#define AFTER_OUTPUT_BUFF (0x0 << 24) -- To view, visit https://review.coreboot.org/c/coreboot/+/48941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddb145ed6a9edb2d7a50248e64659cda78b88ae6 Gerrit-Change-Number: 48941 Gerrit-PatchSet: 1 Gerrit-Owner: 陳建宏 <renius.chen(a)genesyslogic.com.tw> Gerrit-MessageType: newchange

4 10

Change in coreboot[master]: soc/intel/common/fast_spi: Fix ignored build error
by Raul Rangel (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Caveh Jalali, Patrick Rudolph. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 ) Change subject: soc/intel/common/fast_spi: Fix ignored build error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e Gerrit-Change-Number: 49316 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:30:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/fast_spi: Fix ignored build error
by Caveh Jalali (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Patrick Rudolph. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 ) Change subject: soc/intel/common/fast_spi: Fix ignored build error ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/fast_spi/Makefile.inc: https://review.coreboot.org/c/coreboot/+/49316/comment/8e493fd2_e168e578 PS1, Line 45: $$start > required here too? and for $$end? start and end are assigned values unconditionally, so this should be OK. ideally, all variable references would be quoted to avoid such situations. i'm more surprised by the use of $((...)) here. where are we guaranteeing the use of bash for coreboot makefiles? -- To view, visit https://review.coreboot.org/c/coreboot/+/49316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e Gerrit-Change-Number: 49316 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: unbreak compilation on FreeBSD
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Julius Werner. Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49314 ) Change subject: util/cbfstool: unbreak compilation on FreeBSD ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Another approach is to append __BSD_VISIBLE to HOSTCFLAGS in Makefile. -- To view, visit https://review.coreboot.org/c/coreboot/+/49314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3433e4c9269880d3202dd494e5b2e962757a6b87 Gerrit-Change-Number: 49314 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/fast_spi: Fix ignored build error
by Furquan Shaikh (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Martin Roth, Caveh Jalali, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 ) Change subject: soc/intel/common/fast_spi: Fix ignored build error ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/fast_spi/Makefile.inc: https://review.coreboot.org/c/coreboot/+/49316/comment/2ef3b1fd_913a0ea5 PS1, Line 45: $$start required here too? and for $$end? -- To view, visit https://review.coreboot.org/c/coreboot/+/49316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e Gerrit-Change-Number: 49316 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 21:00:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/fast_spi: Fix ignored build error
by Furquan Shaikh (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Martin Roth, Caveh Jalali, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 ) Change subject: soc/intel/common/fast_spi: Fix ignored build error ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thanks for fixing this Caveh! -- To view, visit https://review.coreboot.org/c/coreboot/+/49316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e Gerrit-Change-Number: 49316 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 20:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/fast_spi: Fix ignored build error
by Caveh Jalali (Code Review) 11 Jan '21

11 Jan '21

Attention is currently required from: Furquan Shaikh. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 ) Change subject: soc/intel/common/fast_spi: Fix ignored build error ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/49316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e Gerrit-Change-Number: 49316 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 11 Jan 2021 20:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021