Attention is currently required from: Furquan Shaikh, Martin Roth, Patrick Rudolph.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 )
Change subject: soc/intel/common/fast_spi: Fix ignored build error
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49316/comment/8e493fd2_e168e578
PS1, Line 45: $$start
required here too? and for $$end?
start and end are assigned values unconditionally, so this should be OK.
ideally, all variable references would be quoted to avoid such situations.
i'm more surprised by the use of $((...)) here. where are we
guaranteeing the use of bash for coreboot makefiles?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49316
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e
Gerrit-Change-Number: 49316
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 11 Jan 2021 21:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment