Attention is currently required from: Idwer Vollering.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49314 )
Change subject: util/cbfstool: unbreak compilation on FreeBSD
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
Another approach is to append __BSD_VISIBLE to HOSTCFLAGS in Makefile.
That would probably be a bit more in line with what we do for the glibc control macros, but doesn't really matter much either way.
PS1:
Well... in my defense I did check the FreeBSD man page (https://www.freebsd.org/cgi/man.cgi?query=flock&sektion=2) and it doesn't say anything about needing this. :P
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3433e4c9269880d3202dd494e5b2e962757a6b87
Gerrit-Change-Number: 49314
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 21:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment