Attention is currently required from: Nathaniel L Desimone.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48775 )
Change subject: {soc,vc,mb}/intel: Drop support for Cannon Lake SoC
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
Patchset:
PS11:
Got feedback from Nate, he doesn't see any future for Cannon Lake work either. Let's get rid of this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48775
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f698e16099acb45444b2bc675642d161ff8c237
Gerrit-Change-Number: 48775
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 17:23:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Marc Jones, Martin Roth, Marshall Dawson, Paul Menzel, Rocky Phagura, Subrata Banik, Angel Pons, Patrick Rudolph.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 )
Change subject: src/acpi: Add APEI EINJ support
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49286/comment/b43fcad2_ba4fd323
PS1, Line 11: acpi_create_einj with an address where action table resides. The action table
It would be more clear to explain that soc code should prepare the action table, and call acpi_create_einj() with the address of the action table.
https://review.coreboot.org/c/coreboot/+/49286/comment/fbcd7e20_9eb7de5e
PS1, Line 13: E820 table.
The action table must be shared memory between FW and OS. It should be marked as reserved in the E820 table.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/49286/comment/0246a133_f6745c53
PS1, Line 790: for (i = 0; i < TRIGGER_ACTION_TABLES; i++) {
Not all socs would define all the entries in action table. Either the size of action table, or the number of entries should be passed to this function.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/49286/comment/2ea78b99_717f4751
PS1, Line 76: VFCT, NHLT, SPMI, CRAT, EINJ
EINJ is not a proprietary table, we should move it up and follow alphabetic order.
https://review.coreboot.org/c/coreboot/+/49286/comment/15122650_e12a44c8
PS1, Line 930: #define NO_OP 0x04
please align the values to make it easier to read.
https://review.coreboot.org/c/coreboot/+/49286/comment/a8752850_b35a47f3
PS1, Line 961: acpi_einj_action_table_t trigger_action[4];
Here 4 is hardcoded. What is that number? Should we define a macro?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e
Gerrit-Change-Number: 49286
Gerrit-PatchSet: 1
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 11 Jan 2021 17:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49312 )
Change subject: util/ifdtool: Add coreboot build system support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49312
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42c7b43cc0859916174d59cba6b62630e70287fd
Gerrit-Change-Number: 49312
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 17:04:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48623
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/boten: Update LTE GPIO configuration
......................................................................
mb/google/dedede/var/boten: Update LTE GPIO configuration
LTE module is not expected to be powered off during warm reset. Hence
configure the LTE_PWR_OFF_ODL (GPP_A10) gpio pad reset configuration to
PWROK and set the TX state to 1.
BUG=b:163100335
BRANCH=dedede
TEST=Verified through the waveforms that power sequence is meeting the LTE module requirements.
Change-Id: I8676da6186559288aabe078b6158fc01075c7b41
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M src/mainboard/google/dedede/variants/boten/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48623/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/48623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8676da6186559288aabe078b6158fc01075c7b41
Gerrit-Change-Number: 48623
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Allen Cheng <allen.cheng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48623 )
Change subject: mb/google/dedede/var/boten: Update LTE GPIO configuration
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8676da6186559288aabe078b6158fc01075c7b41
Gerrit-Change-Number: 48623
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Allen Cheng <allen.cheng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 17:02:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Duncan Laurie, Brandon Breitenstein, Rajmohan Mani.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49257 )
Change subject: ec/google/chromeec: Provide EC access path for Retimer firmware update
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/49257/comment/4b1f232f_80741b09
PS1, Line 242: RFWU
> I don't see this added to `ec/google/chromeec/acpi/ec. […]
CB:49051 already adds RFWU to ec/google/chromeec/acpi/ec.asl. This patch has dependency on CB:48630 which has this mainboard_retimer_fw_update_path function declaration.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49257
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3817d93cfdeedf15825dab6c537b151fd063338b
Gerrit-Change-Number: 49257
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Attention: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 16:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 )
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5
......................................................................
Patch Set 6:
(4 comments)
File Documentation/mainboard/system76/oryp5.md:
https://review.coreboot.org/c/coreboot/+/47892/comment/a396b16b_15906f1d
PS5, Line 15: 2666 MHz
> These are from the marketing material, which it seems most vendors use MHz instead of MT/s. […]
Done
File src/mainboard/system76/oryp5/Kconfig:
https://review.coreboot.org/c/coreboot/+/47892/comment/106b0949_f0f3ef77
PS5, Line 12: HAVE_SMI_HANDLER
> Selected by the SOC, will remove.
Done
File src/mainboard/system76/oryp5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47892/comment/03fb68c1_bdaaca64
PS5, Line 41: WARNING: must then be mapped from FSP value to PCH value
> Potentially. But I'm more inclined to just remove the comments like this. […]
Done
File src/mainboard/system76/oryp5/gpio.c:
https://review.coreboot.org/c/coreboot/+/47892/comment/ef3074f5_33884a0e
PS5, Line 98: PAD_NC(GPP_C20, UP_20K), // UART2_RXD (test point)
: PAD_NC(GPP_C21, UP_20K), // UART2_TXD (test point)
> Yes please, for the sake of completeness
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/47892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae6e530dcd52df3642cdfe74b65bfff5aa0dd402
Gerrit-Change-Number: 47892
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 16:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jeremy Soller, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47892
to look at the new patch set (#6).
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5
......................................................................
mb/system76/oryp5: Add System76 Oryx Pro 5
Tested with TianoCore payload.
Not working:
- Discrete/Hybrid graphics
- Internal speakers
Change-Id: Iae6e530dcd52df3642cdfe74b65bfff5aa0dd402
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/oryp5.md
A configs/config.system76_oryp5
A src/mainboard/system76/oryp5/Kconfig
A src/mainboard/system76/oryp5/Kconfig.name
A src/mainboard/system76/oryp5/Makefile.inc
A src/mainboard/system76/oryp5/acpi/gpe.asl
A src/mainboard/system76/oryp5/acpi/mainboard.asl
A src/mainboard/system76/oryp5/acpi/sleep.asl
A src/mainboard/system76/oryp5/board_info.txt
A src/mainboard/system76/oryp5/bootblock.c
A src/mainboard/system76/oryp5/data.vbt
A src/mainboard/system76/oryp5/devicetree.cb
A src/mainboard/system76/oryp5/dsdt.asl
A src/mainboard/system76/oryp5/gpio.c
A src/mainboard/system76/oryp5/gpio_early.c
A src/mainboard/system76/oryp5/hda_verb.c
A src/mainboard/system76/oryp5/include/mainboard/gpio.h
A src/mainboard/system76/oryp5/ramstage.c
A src/mainboard/system76/oryp5/romstage.c
20 files changed, 818 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/47892/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/47892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae6e530dcd52df3642cdfe74b65bfff5aa0dd402
Gerrit-Change-Number: 47892
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset