coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6507 discussions

Change in coreboot[master]: util/board_status/board_status.sh: improve getopt detection and usage...
by build bot (Jenkins) (Code Review) 11 Jan '21

11 Jan '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49307 ) Change subject: util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes ...................................................................... Patch Set 2: (1 comment) File util/board_status/board_status.sh: https://review.coreboot.org/c/coreboot/+/49307/comment/9bc7594b_e1466b58 PS2, Line 213: echo "Please install getopt, or build and install misc/getopt from ports" line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/49307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b Gerrit-Change-Number: 49307 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Jan 2021 14:13:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/board_status/board_status.sh: invoke md5 on FreeBSD
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49309 to look at the new patch set (#2). Change subject: util/board_status/board_status.sh: invoke md5 on FreeBSD ...................................................................... util/board_status/board_status.sh: invoke md5 on FreeBSD Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I8d9493ce0c3fa97ea9c3c2f60a0106bb98bd8315 --- M util/board_status/board_status.sh 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/49309/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49309 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d9493ce0c3fa97ea9c3c2f60a0106bb98bd8315 Gerrit-Change-Number: 49309 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/board_status/board_status.sh: improve mktemp behaviour on non-li...
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49308 to look at the new patch set (#2). Change subject: util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes ...................................................................... util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606 --- M util/board_status/board_status.sh 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/49308/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606 Gerrit-Change-Number: 49308 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/board_status/board_status.sh: improve getopt detection and usage...
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49307 to look at the new patch set (#2). Change subject: util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes ...................................................................... util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b --- M util/board_status/board_status.sh 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/49307/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b Gerrit-Change-Number: 49307 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/board_status/board_status.sh: select the right gnu make binary
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49306 to look at the new patch set (#2). Change subject: util/board_status/board_status.sh: select the right gnu make binary ...................................................................... util/board_status/board_status.sh: select the right gnu make binary Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761 --- M util/board_status/board_status.sh 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/49306/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761 Gerrit-Change-Number: 49306 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/board_status/board_status.sh: absorb and inject user identificat...
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49311 ) Change subject: util/board_status/board_status.sh: absorb and inject user identification from the top-level git directory ...................................................................... util/board_status/board_status.sh: absorb and inject user identification from the top-level git directory Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I385f10bffc797db691be1a9109af5336bc8601e3 --- M util/board_status/board_status.sh 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/49311/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 76ff594..d75454d 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -507,6 +507,10 @@ # extract username from ssh://<username>@review.coreboot.org/blah bsrepo=$(git config --get remote.origin.url | sed "s,$.*$/coreboot,\1/board-status,") + # absorb parts of git configuration from the top-level directory + git_email="$(git config -f .git/config user.email)" + git_username="$(git config -f .git/config user.name)" + cd "util/board_status/" if [ ! -e "board-status" ]; then # FIXME: the board-status directory might get big over time. @@ -521,6 +525,10 @@ cd "board-status" + # inject the absorbed git identification in board-status/.git/config + git config -f .git/config user.email "${git_email}" + git config -f .git/config user.name "${git_username}" + echo "Checking for duplicate results" # get any updates to board-status git pull -- To view, visit https://review.coreboot.org/c/coreboot/+/49311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I385f10bffc797db691be1a9109af5336bc8601e3 Gerrit-Change-Number: 49311 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/board_status/board_status.sh: build the cbmem binary when absent
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49310 ) Change subject: util/board_status/board_status.sh: build the cbmem binary when absent ...................................................................... util/board_status/board_status.sh: build the cbmem binary when absent Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: Ia6442e8ba5e789fc5eab89b6796ec45635f1e923 --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/49310/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index cc83bd4..76ff594 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -401,7 +401,12 @@ if [ -n "$CBMEM_PATH" ]; then cbmem_cmd="$CBMEM_PATH" else - cbmem_cmd="cbmem" + if [ -e util/cbmem/ ] && [ ! -x util/cbmem/cbmem ]; then + $MAKE -C util/cbmem/ + cbmem_cmd="util/cbmem/cbmem" + else + cbmem_cmd="cbmem" + fi fi cmos_enabled=0 -- To view, visit https://review.coreboot.org/c/coreboot/+/49310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6442e8ba5e789fc5eab89b6796ec45635f1e923 Gerrit-Change-Number: 49310 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/board_status/board_status.sh: invoke md5 on FreeBSD
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49309 ) Change subject: util/board_status/board_status.sh: invoke md5 on FreeBSD ...................................................................... util/board_status/board_status.sh: invoke md5 on FreeBSD Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I8d9493ce0c3fa97ea9c3c2f60a0106bb98bd8315 --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/49309/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index ce636b7..cc83bd4 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -350,7 +350,12 @@ echo "Extracting payload_version from $COREBOOT_IMAGE" $cbfstool_cmd "$COREBOOT_IMAGE" extract -n payload_version -f "${tmpdir}/payload_version.txt" >/dev/null 2>&1 fi -md5sum -b "$COREBOOT_IMAGE" > "${tmpdir}/rom_checksum.txt" +case $(uname) in +FreeBSD) +md5 "$COREBOOT_IMAGE" > "${tmpdir}/rom_checksum.txt";; +*) +md5sum -b "$COREBOOT_IMAGE" > "${tmpdir}/rom_checksum.txt";; +esac if test $do_clean_cbfstool -eq 1; then $MAKE -C util/cbfstool clean -- To view, visit https://review.coreboot.org/c/coreboot/+/49309 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d9493ce0c3fa97ea9c3c2f60a0106bb98bd8315 Gerrit-Change-Number: 49309 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/board_status/board_status.sh: improve mktemp behaviour on non-li...
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49308 ) Change subject: util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes ...................................................................... util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606 --- M util/board_status/board_status.sh 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/49308/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 17ba85c..ce636b7 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -306,7 +306,12 @@ # Results will be placed in a temporary location until we're ready to upload. # If the user does not wish to upload, results will remain in /tmp. -tmpdir=$(mktemp -d --tmpdir coreboot_board_status.XXXXXXXX) +case $(uname) in +FreeBSD) +tmpdir=$(mktemp -d -t coreboot_board_status);; +*) +tmpdir=$(mktemp -d --tmpdir coreboot_board_status.XXXXXXXX);; +esac # Obtain coreboot config by running cbfstool on the ROM image. cbfstool may # already exist in build/ or util/cbfstool/, but if not then we'll build it -- To view, visit https://review.coreboot.org/c/coreboot/+/49308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606 Gerrit-Change-Number: 49308 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/board_status/board_status.sh: improve getopt detection and usage...
by Idwer Vollering (Code Review) 11 Jan '21

11 Jan '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49307 ) Change subject: util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes ...................................................................... util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b --- M util/board_status/board_status.sh 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/49307/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index ab4a310..17ba85c 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -205,7 +205,19 @@ " } -getopt -T +case $(uname) in +FreeBSD) + if [ ! -x /usr/local/bin/getopt ]; then + echo 'Please install getopt, or build and install misc/getopt from ports' + exit $EXIT_FAILURE + else + GETOPT=/usr/local/bin/getopt;; + fi +*) + GETOPT=/usr/bin/getopt;; +esac + +$GETOPT -T if [ $? -ne 4 ]; then echo "GNU-compatible getopt(1) required." exit $EXIT_FAILURE @@ -215,7 +227,7 @@ LONGOPTS="${LONGOPTS},serial-device:,serial-speed:" LONGOPTS="${LONGOPTS},ssh-port:" -ARGS=$(getopt -o c:n:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@"); +ARGS=$($GETOPT -o c:n:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@"); if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi eval set -- "$ARGS" while true ; do -- To view, visit https://review.coreboot.org/c/coreboot/+/49307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b Gerrit-Change-Number: 49307 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021