Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49308 )
Change subject: util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes
......................................................................
util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606
---
M util/board_status/board_status.sh
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/49308/1
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 17ba85c..ce636b7 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -306,7 +306,12 @@
# Results will be placed in a temporary location until we're ready to upload.
# If the user does not wish to upload, results will remain in /tmp.
-tmpdir=$(mktemp -d --tmpdir coreboot_board_status.XXXXXXXX)
+case $(uname) in
+FreeBSD)
+tmpdir=$(mktemp -d -t coreboot_board_status);;
+*)
+tmpdir=$(mktemp -d --tmpdir coreboot_board_status.XXXXXXXX);;
+esac
# Obtain coreboot config by running cbfstool on the ROM image. cbfstool may
# already exist in build/ or util/cbfstool/, but if not then we'll build it
--
To view, visit https://review.coreboot.org/c/coreboot/+/49308
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606
Gerrit-Change-Number: 49308
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-MessageType: newchange
Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49306 )
Change subject: util/board_status/board_status.sh: select the right gnu make binary
......................................................................
util/board_status/board_status.sh: select the right gnu make binary
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761
---
M util/board_status/board_status.sh
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/49306/1
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 31c3e7c..ab4a310 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -26,6 +26,13 @@
# Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo`
NVRAMTOOL_PATH=""
+case $(uname) in
+FreeBSD)
+ MAKE=gmake;;
+*)
+ MAKE=make;;
+esac
+
# test a command
#
# $1: 0 ($LOCAL) to run command locally,
@@ -302,7 +309,7 @@
exit $EXIT_FAILURE
fi
else
- make -C util/cbfstool/
+ $MAKE -C util/cbfstool/
do_clean_cbfstool=1
fi
fi
@@ -313,7 +320,7 @@
$cbfstool_cmd "$COREBOOT_IMAGE" extract -n config -f "${tmpdir}/config.txt" >/dev/null 2>&1
mv "${tmpdir}/config.txt" "${tmpdir}/config.short.txt"
cp "${tmpdir}/config.short.txt" "${tmpcfg}"
-yes "" | make "DOTCONFIG=${tmpcfg}" oldconfig 2>/dev/null >/dev/null
+yes "" | $MAKE "DOTCONFIG=${tmpcfg}" oldconfig 2>/dev/null >/dev/null
mv "${tmpcfg}" "${tmpdir}/config.txt"
rm -f "${tmpcfg}.old"
$cbfstool_cmd "$COREBOOT_IMAGE" print > "${tmpdir}/cbfs.txt"
@@ -329,7 +336,7 @@
md5sum -b "$COREBOOT_IMAGE" > "${tmpdir}/rom_checksum.txt"
if test $do_clean_cbfstool -eq 1; then
- make -C util/cbfstool clean
+ $MAKE -C util/cbfstool clean
fi
# Obtain board and revision info to form the directory structure:
--
To view, visit https://review.coreboot.org/c/coreboot/+/49306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761
Gerrit-Change-Number: 49306
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49303 )
Change subject: cpu/x86/mpinit: Serialize microcode updates for HT threads
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49303/comment/1983f657_6f84e193
PS1, Line 13: a Hyper-Threading enabled CPU on pre FIT platforms.
> model_106cx uses model_1067x mpinit code.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/49303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27bf5177859c12e92d6ce7a2966c965d7262b472
Gerrit-Change-Number: 49303
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 11 Jan 2021 12:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Kyösti Mälkki, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48829 )
Change subject: soc/intel/*: drop UART pad configuration from common code
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/48829/comment/8384a8cd_6f370ee2
PS9, Line 59: if (CONFIG_UART_FOR_CONSOLE > uart_max_index)
Comparisons should place the constant on the right side of the test
--
To view, visit https://review.coreboot.org/c/coreboot/+/48829
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03719eb8bd0414083148471ed05dea62a895126
Gerrit-Change-Number: 48829
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 12:34:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment