Attention is currently required from: Frank Wu, John Su, Furquan Shaikh, Martin Roth, Paul Menzel.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49236 )
Change subject: mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6d04f9c48aa0800189283608bf57416ac75cf7
Gerrit-Change-Number: 49236
Gerrit-PatchSet: 4
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 11 Jan 2021 15:36:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Hendricks.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49308 )
Change subject: util/board_status/board_status.sh: improve mktemp behaviour on non-linux OSes
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
v
--
To view, visit https://review.coreboot.org/c/coreboot/+/49308
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I763b0e7c7c81a2447ed20db0a25047d106e30606
Gerrit-Change-Number: 49308
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Comment-Date: Mon, 11 Jan 2021 14:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49312
to look at the new patch set (#2).
Change subject: util/ifdtool: Add coreboot build system support
......................................................................
util/ifdtool: Add coreboot build system support
When building as part of the coreboot build system, use the same
mechanism as other tools (cbfstool, amdfwtool, ...) so that abuild
builds ifdtool once into sharedutils instead of once per board (while
avoiding other race conditions, too).
Change-Id: I42c7b43cc0859916174d59cba6b62630e70287fd
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M Makefile.inc
A util/ifdtool/Makefile.inc
2 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49312/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49312
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42c7b43cc0859916174d59cba6b62630e70287fd
Gerrit-Change-Number: 49312
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49310
to look at the new patch set (#3).
Change subject: util/board_status/board_status.sh: build the cbmem binary when absent
......................................................................
util/board_status/board_status.sh: build the cbmem binary when absent
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: Ia6442e8ba5e789fc5eab89b6796ec45635f1e923
---
M util/board_status/board_status.sh
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/49310/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/49310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6442e8ba5e789fc5eab89b6796ec45635f1e923
Gerrit-Change-Number: 49310
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Andrey Petrov, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49313 )
Change subject: [WIP]soc/intel/apollolake: Select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/c/coreboot/+/49313/comment/c2ae3862_fcbe52fa
PS1, Line 185: }
adding a line without newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/49313
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdc5468fdd86f88bc8a09a69bfbc59279d1e3828
Gerrit-Change-Number: 49313
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 11 Jan 2021 14:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49307 )
Change subject: util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes
......................................................................
Patch Set 2:
(1 comment)
File util/board_status/board_status.sh:
https://review.coreboot.org/c/coreboot/+/49307/comment/9bc7594b_e1466b58
PS2, Line 213: echo "Please install getopt, or build and install misc/getopt from ports"
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/49307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b
Gerrit-Change-Number: 49307
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 11 Jan 2021 14:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49306
to look at the new patch set (#2).
Change subject: util/board_status/board_status.sh: select the right gnu make binary
......................................................................
util/board_status/board_status.sh: select the right gnu make binary
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761
---
M util/board_status/board_status.sh
1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/49306/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4523b1b235064f89c01530b47c9cb4c3c11c9761
Gerrit-Change-Number: 49306
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49307
to look at the new patch set (#2).
Change subject: util/board_status/board_status.sh: improve getopt detection and usage on non-linux OSes
......................................................................
util/board_status/board_status.sh: improve getopt detection and usage on
non-linux OSes
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b
---
M util/board_status/board_status.sh
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/49307/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/49307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba50d8a8609eda974f12b0d9802e04d7371aed5b
Gerrit-Change-Number: 49307
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset