Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45144 )
Change subject: apollolake: Define MAX_CPUS at SoC scope
......................................................................
apollolake: Define MAX_CPUS at SoC scope
The three Intel Apollo Lake boards (apl_rvp, leafhill and minnow3) do
not define MAX_CPUS, which would then default to 1. Since this is most
likely an oversight, use the same value as other Apollo Lake boards.
To ensure this does not happen again, factor out MAX_CPUS to SoC scope.
Change-Id: I5ed98a6b592c8010b59eca7ff773ae1ccc4cd7b1
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/google/reef/Kconfig
M src/mainboard/siemens/mc_apl1/Kconfig
M src/mainboard/up/squared/Kconfig
M src/soc/intel/apollolake/Kconfig
4 files changed, 1 insertion(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/45144/1
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig
index de4df62..76a8640 100644
--- a/src/mainboard/google/reef/Kconfig
+++ b/src/mainboard/google/reef/Kconfig
@@ -81,10 +81,6 @@
default "Google_Coral" if BOARD_GOOGLE_CORAL
default "Google_Reef"
-config MAX_CPUS
- int
- default 4
-
config UART_FOR_CONSOLE
int
default 2
diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig
index 705351f..ac85670 100644
--- a/src/mainboard/siemens/mc_apl1/Kconfig
+++ b/src/mainboard/siemens/mc_apl1/Kconfig
@@ -40,8 +40,4 @@
config UART_FOR_CONSOLE
default 2
-config MAX_CPUS
- int
- default 4
-
endif # BOARD_SIEMENS_BASEBOARD_MC_APL1
diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig
index 836c5bb..25e751c 100644
--- a/src/mainboard/up/squared/Kconfig
+++ b/src/mainboard/up/squared/Kconfig
@@ -60,10 +60,6 @@
string
default "10ec,8168"
-config MAX_CPUS
- int
- default 4
-
config LINUX_COMMAND_LINE
string
default "console=ttyS4,115200 earlyprintk=ttyS4,115200,keep" if PAYLOAD_LINUXBOOT && UART_FOR_CONSOLE=0
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 08710d2..a0b2cc1 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -109,7 +109,7 @@
config MAX_CPUS
int
- default 4 if SOC_INTEL_GEMINILAKE
+ default 4
config CHROMEOS
select CHROMEOS_RAMOOPS_DYNAMIC
--
To view, visit https://review.coreboot.org/c/coreboot/+/45144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed98a6b592c8010b59eca7ff773ae1ccc4cd7b1
Gerrit-Change-Number: 45144
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newchange
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45197 )
Change subject: mb/google/volteer: Fix GPP_E12 definition
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3ef864827aa94b0b96e335565119f3d5d008837
Gerrit-Change-Number: 45197
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 09 Sep 2020 10:00:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment