Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
apollolake: Limit MAX_CPUS to 4
Apollo Lake parts have at most four CPU threads.
Change-Id: Ib2ffadc0c31cdd96bec8eed5364c984acb2e1250 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/45143/1
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index df1d8c4..de4df62 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -83,7 +83,7 @@
config MAX_CPUS int - default 8 + default 4
config UART_FOR_CONSOLE int diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 0fe4a25..705351f 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -42,6 +42,6 @@
config MAX_CPUS int - default 8 + default 4
endif # BOARD_SIEMENS_BASEBOARD_MC_APL1
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG@9 PS1, Line 9: threads I think this should be cores.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG@9 PS1, Line 9: threads
I think this should be cores.
MAX_CPUS actually cares about CPU threads, not cores. But it's irrelevant for APL because it doesn't support Hyper-Threading (so each core has one thread) 😄
Will update.
Hello build bot (Jenkins), Mario Scheithauer, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45143
to look at the new patch set (#2).
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
apollolake: Limit MAX_CPUS to 4
APL does not support Hyper-Threading, and has at most four CPU cores.
Change-Id: Ib2ffadc0c31cdd96bec8eed5364c984acb2e1250 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/45143/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG@9 PS1, Line 9: threads
MAX_CPUS actually cares about CPU threads, not cores. […]
Done
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4 ......................................................................
apollolake: Limit MAX_CPUS to 4
APL does not support Hyper-Threading, and has at most four CPU cores.
Change-Id: Ib2ffadc0c31cdd96bec8eed5364c984acb2e1250 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45143 Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/reef/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Mario Scheithauer: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index df1d8c4..de4df62 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -83,7 +83,7 @@
config MAX_CPUS int - default 8 + default 4
config UART_FOR_CONSOLE int diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 0fe4a25..705351f 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -42,6 +42,6 @@
config MAX_CPUS int - default 8 + default 4
endif # BOARD_SIEMENS_BASEBOARD_MC_APL1
-
Angel Pons (Code Review) -
Mario Scheithauer (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)