Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45143 )
Change subject: apollolake: Limit MAX_CPUS to 4
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45143/1//COMMIT_MSG@9
PS1, Line 9: threads
I think this should be cores.
MAX_CPUS actually cares about CPU threads, not cores. But it's irrelevant for APL because it doesn't support Hyper-Threading (so each core has one thread) 😄
Will update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2ffadc0c31cdd96bec8eed5364c984acb2e1250
Gerrit-Change-Number: 45143
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Sep 2020 12:23:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment