coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2628 discussions

Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory
by Angel Pons (Code Review) 09 Sep '20

09 Sep '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 ) Change subject: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… File src/mainboard/google/sarien/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… PS2, Line 12: select GENERIC_SPD_BIN > Correct, sarien has DIMM slots. Thanks for confirming -- To view, visit https://review.coreboot.org/c/coreboot/+/45146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Gerrit-Change-Number: 45146 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 16:23:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory
by Tim Wawrzynczak (Code Review) 09 Sep '20

09 Sep '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 ) Change subject: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… File src/mainboard/google/sarien/Kconfig: https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarie… PS2, Line 12: select GENERIC_SPD_BIN > Seems to be correct, since this is mutually exclusive with SPD_READ_BY_WORD. […] Correct, sarien has DIMM slots. -- To view, visit https://review.coreboot.org/c/coreboot/+/45146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Gerrit-Change-Number: 45146 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 16:21:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: stop using hexdumps for SPD files
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Hello Felix Singer, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Frans Hendriks, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Nico Huber, Michał Żygowski, David Guckian, Martin Roth, Vanessa Eusebio, Alexander Couzens, Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44775 to look at the new patch set (#25). Change subject: treewide: stop using hexdumps for SPD files ...................................................................... treewide: stop using hexdumps for SPD files SPD files normally don't get edited. Keeping the files as hexdump does not have any advantage and conversion from hex to bin adds complexity with a high chance for bugs and other sorts of problems. One example for such problem is an issue that only appeared on one of my systems, where conversion of '01 02 03' to binary resulted in \x01\x32\x03 instead of \x01\x02\x03: for c in 01 02 03; do printf $(printf '\%o' 0x$c); done | xxd -g 1 00000000: 01 32 03 .2. The reason for this was that the syntax in lib/Makefile.inc is wrong and should have been `printf $(printf '\\%03o' 0x$c)`. Instead of fixing this, we should remove some of the aforementioned complexity to lower the probability of future encoding problems. Thus, convert all SPD hexdumps to binaries and adapt the Makefiles to just concatenate them to `spd.bin`. The SPDs, manifests and Makefiles for soc/intel/{tiger,jasper}lake and mainboard/google/{dedede,volteer,zork} have been regenerated using the following commands: go run util/spd_tools/ddr4/gen_spd.go src/soc/intel/tigerlake/spd/ \ util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt TGL go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/tigerlake/spd/ \ util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt TGL go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/jasperlake/spd/ \ util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt JSL for v in src/mainboard/google/zork/variants/*; do [ -f ${v}/spd/mem_parts_used.txt ] || continue go run util/spd_tools/ddr4/gen_part_id.go \ src/mainboard/google/zork/spd \ ${v}/spd ${v}/spd/mem_parts_used.txt done for v in src/mainboard/google/{dedede,volteer}/variants/*; do [ -f ${v}/memory/mem_list_variant.txt ] || continue for m in ddr4 lp4x; do go run ./util/spd_tools/${m}/gen_part_id.go \ src/soc/intel/tigerlake/spd ${v}/memory \ ${v}/memory/mem_list_variant.txt done done All other SPD files have been converted with `grep -v "^#" | xxd -ps -r` or `xxd -rg1`, depending on the format. Documentation has been updated where needed. For all affected boards the output binary has been verified to remain identical, using timeless abuild. Exception: google/volteer/variants/lindar will have an empty spd.bin until CB:44848 gets merged. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 --- M .gitignore M Documentation/Intel/Board/board.html M Documentation/soc/amd/family17h.md M src/lib/Kconfig M src/lib/Makefile.inc A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.bin D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.hex A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.bin D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.hex A src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.bin D src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex A src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.bin D src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex A src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin D src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex A src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.bin D src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.hex A src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.bin D src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/auron_paine/spd/Makefile.inc A src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/auron_yuna/spd/Makefile.inc A src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/gandof/spd/Makefile.inc A src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.hex A src/mainboard/google/auron/variants/gandof/spd/empty.spd.bin D src/mainboard/google/auron/variants/gandof/spd/empty.spd.hex M src/mainboard/google/auron/variants/lulu/spd/Makefile.inc A src/mainboard/google/auron/variants/lulu/spd/empty.spd.bin D src/mainboard/google/auron/variants/lulu/spd/empty.spd.hex A src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.bin D src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.hex A src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin D src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex A src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.bin D src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.hex M src/mainboard/google/auron/variants/samus/spd/Makefile.inc A src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.hex A src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.hex A src/mainboard/google/auron/variants/samus/spd/empty.spd.bin D src/mainboard/google/auron/variants/samus/spd/empty.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.hex A src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.hex A src/mainboard/google/cyan/spd/empty.spd.bin D src/mainboard/google/cyan/spd/empty.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.hex A src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin D src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex A src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.bin D src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex M src/mainboard/google/dedede/variants/boten/memory/Makefile.inc M src/mainboard/google/dedede/variants/drawcia/memory/Makefile.inc M src/mainboard/google/dedede/variants/madoo/memory/Makefile.inc M src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc M src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc M src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc M src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc M src/mainboard/google/drallion/spd/Makefile.inc A src/mainboard/google/drallion/spd/empty_ddr4.spd.bin D src/mainboard/google/drallion/spd/empty_ddr4.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex A src/mainboard/google/eve/spd/empty.spd.bin D src/mainboard/google/eve/spd/empty.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.hex A src/mainboard/google/glados/spd/empty.spd.bin D src/mainboard/google/glados/spd/empty.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex A src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.bin D src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.hex A src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.bin D src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.hex A src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.bin D src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.hex A src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.bin D src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.hex A src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.bin D src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex A src/mainboard/google/hatch/spd/16G_2400.spd.bin D src/mainboard/google/hatch/spd/16G_2400.spd.hex A src/mainboard/google/hatch/spd/16G_2666.spd.bin D src/mainboard/google/hatch/spd/16G_2666.spd.hex A src/mainboard/google/hatch/spd/16G_2666_2bg.spd.bin D src/mainboard/google/hatch/spd/16G_2666_2bg.spd.hex A src/mainboard/google/hatch/spd/16G_3200.spd.bin D src/mainboard/google/hatch/spd/16G_3200.spd.hex A src/mainboard/google/hatch/spd/16G_3200_4bg.spd.bin D src/mainboard/google/hatch/spd/16G_3200_4bg.spd.hex A src/mainboard/google/hatch/spd/4G_2400.spd.bin D src/mainboard/google/hatch/spd/4G_2400.spd.hex A src/mainboard/google/hatch/spd/8G_2400.spd.bin D src/mainboard/google/hatch/spd/8G_2400.spd.hex A src/mainboard/google/hatch/spd/8G_2666.spd.bin D src/mainboard/google/hatch/spd/8G_2666.spd.hex A src/mainboard/google/hatch/spd/8G_3200.spd.bin D src/mainboard/google/hatch/spd/8G_3200.spd.hex A src/mainboard/google/hatch/spd/LP_16G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_16G_2133.spd.hex A src/mainboard/google/hatch/spd/LP_4G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex A src/mainboard/google/hatch/spd/LP_8G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_8G_2133.spd.hex A src/mainboard/google/hatch/spd/empty_ddr4.spd.bin D src/mainboard/google/hatch/spd/empty_ddr4.spd.hex A src/mainboard/google/kahlee/spd/empty.spd.bin D src/mainboard/google/kahlee/spd/empty.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.hex A src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.bin D src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.hex A src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.bin D src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.hex A src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.bin D src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.hex M src/mainboard/google/poppy/spd/Makefile.inc A src/mainboard/google/poppy/spd/empty.spd.bin D src/mainboard/google/poppy/spd/empty.spd.hex A src/mainboard/google/poppy/spd/empty_ddr4.spd.bin D src/mainboard/google/poppy/spd/empty_ddr4.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.hex A src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.bin D src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.hex A src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.bin D src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.hex A src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex A src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.bin D src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.hex A src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.bin D src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.hex A src/mainboard/google/rambi/spd/empty.spd.bin D src/mainboard/google/rambi/spd/empty.spd.hex A src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.hex A src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.bin D src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex A src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.hex A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex M src/mainboard/google/slippy/variants/falco/Makefile.inc A src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.hex M src/mainboard/google/slippy/variants/leon/Makefile.inc A src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.hex M src/mainboard/google/slippy/variants/peppy/Makefile.inc A src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.hex M src/mainboard/google/slippy/variants/wolf/Makefile.inc A src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.hex M src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc M src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc M src/mainboard/google/volteer/variants/lindar/memory/Makefile.inc M src/mainboard/google/volteer/variants/malefor/memory/Makefile.inc M src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc M src/mainboard/google/volteer/variants/todor/memory/Makefile.inc M src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc M src/mainboard/google/volteer/variants/volteer/memory/Makefile.inc M src/mainboard/google/volteer/variants/volteer2/memory/Makefile.inc M src/mainboard/google/volteer/variants/voxel/memory/Makefile.inc A src/mainboard/google/zork/spd/ddr4-spd-1.bin D src/mainboard/google/zork/spd/ddr4-spd-1.hex A src/mainboard/google/zork/spd/ddr4-spd-2.bin D src/mainboard/google/zork/spd/ddr4-spd-2.hex A src/mainboard/google/zork/spd/ddr4-spd-3.bin D src/mainboard/google/zork/spd/ddr4-spd-3.hex A src/mainboard/google/zork/spd/ddr4-spd-4.bin D src/mainboard/google/zork/spd/ddr4-spd-4.hex A src/mainboard/google/zork/spd/ddr4-spd-5.bin D src/mainboard/google/zork/spd/ddr4-spd-5.hex A src/mainboard/google/zork/spd/ddr4-spd-6.bin D src/mainboard/google/zork/spd/ddr4-spd-6.hex A src/mainboard/google/zork/spd/ddr4-spd-7.bin D src/mainboard/google/zork/spd/ddr4-spd-7.hex A src/mainboard/google/zork/spd/ddr4-spd-8.bin D src/mainboard/google/zork/spd/ddr4-spd-8.hex A src/mainboard/google/zork/spd/ddr4-spd-empty.bin D src/mainboard/google/zork/spd/ddr4-spd-empty.hex M src/mainboard/google/zork/spd/ddr4_spd_manifest.generated.txt M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc M src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc A src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.bin D src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/empty.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/empty.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.hex A src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.bin D src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.hex A src/mainboard/intel/icelake_rvp/spd/empty.spd.bin D src/mainboard/intel/icelake_rvp/spd/empty.spd.hex A src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.bin D src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex A src/mainboard/intel/jasperlake_rvp/spd/empty.spd.bin D src/mainboard/intel/jasperlake_rvp/spd/empty.spd.hex A src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.bin D src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.hex A src/mainboard/intel/kblrvp/spd/empty.spd.bin D src/mainboard/intel/kblrvp/spd/empty.spd.hex A src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin D src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex A src/mainboard/intel/kblrvp/spd/rvp3.spd.bin D src/mainboard/intel/kblrvp/spd/rvp3.spd.hex A src/mainboard/intel/kunimitsu/spd/empty.spd.bin D src/mainboard/intel/kunimitsu/spd/empty.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.hex A src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.bin D src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex A src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.bin D src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.bin D src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.hex A src/mainboard/intel/tglrvp/spd/empty.spd.bin D src/mainboard/intel/tglrvp/spd/empty.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.hex A src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.hex A src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.hex M src/mainboard/lenovo/t430s/variants/t431s/spd/Makefile.inc A src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.bin D src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.hex A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.bin D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.bin D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex A src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.bin D src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex A src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.bin D src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex A src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.bin D src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex A src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.bin D src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex A src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin D src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex A src/mainboard/samsung/lumpy/spd/lumpy.spd.bin D src/mainboard/samsung/lumpy/spd/lumpy.spd.hex A src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.bin D src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.hex M src/soc/amd/picasso/Makefile.inc A src/soc/intel/jasperlake/spd/lp4x-spd-1.bin D src/soc/intel/jasperlake/spd/lp4x-spd-1.hex A src/soc/intel/jasperlake/spd/lp4x-spd-2.bin D src/soc/intel/jasperlake/spd/lp4x-spd-2.hex A src/soc/intel/jasperlake/spd/lp4x-spd-3.bin D src/soc/intel/jasperlake/spd/lp4x-spd-3.hex A src/soc/intel/jasperlake/spd/lp4x-spd-4.bin D src/soc/intel/jasperlake/spd/lp4x-spd-4.hex A src/soc/intel/jasperlake/spd/lp4x-spd-5.bin D src/soc/intel/jasperlake/spd/lp4x-spd-5.hex A src/soc/intel/jasperlake/spd/lp4x-spd-6.bin D src/soc/intel/jasperlake/spd/lp4x-spd-6.hex A src/soc/intel/jasperlake/spd/lp4x-spd-7.bin D src/soc/intel/jasperlake/spd/lp4x-spd-7.hex M src/soc/intel/jasperlake/spd/lp4x_spd_manifest.generated.txt A src/soc/intel/tigerlake/spd/ddr4-spd-1.bin D src/soc/intel/tigerlake/spd/ddr4-spd-1.hex A src/soc/intel/tigerlake/spd/ddr4-spd-2.bin D src/soc/intel/tigerlake/spd/ddr4-spd-2.hex A src/soc/intel/tigerlake/spd/ddr4-spd-3.bin D src/soc/intel/tigerlake/spd/ddr4-spd-3.hex A src/soc/intel/tigerlake/spd/ddr4-spd-4.bin D src/soc/intel/tigerlake/spd/ddr4-spd-4.hex A src/soc/intel/tigerlake/spd/ddr4-spd-5.bin D src/soc/intel/tigerlake/spd/ddr4-spd-5.hex A src/soc/intel/tigerlake/spd/ddr4-spd-6.bin D src/soc/intel/tigerlake/spd/ddr4-spd-6.hex A src/soc/intel/tigerlake/spd/ddr4-spd-7.bin D src/soc/intel/tigerlake/spd/ddr4-spd-7.hex A src/soc/intel/tigerlake/spd/ddr4-spd-8.bin D src/soc/intel/tigerlake/spd/ddr4-spd-8.hex A src/soc/intel/tigerlake/spd/ddr4-spd-empty.bin D src/soc/intel/tigerlake/spd/ddr4-spd-empty.hex M src/soc/intel/tigerlake/spd/ddr4_spd_manifest.generated.txt A src/soc/intel/tigerlake/spd/lp4x-spd-1.bin D src/soc/intel/tigerlake/spd/lp4x-spd-1.hex A src/soc/intel/tigerlake/spd/lp4x-spd-2.bin D src/soc/intel/tigerlake/spd/lp4x-spd-2.hex A src/soc/intel/tigerlake/spd/lp4x-spd-3.bin D src/soc/intel/tigerlake/spd/lp4x-spd-3.hex A src/soc/intel/tigerlake/spd/lp4x-spd-4.bin D src/soc/intel/tigerlake/spd/lp4x-spd-4.hex A src/soc/intel/tigerlake/spd/lp4x-spd-5.bin D src/soc/intel/tigerlake/spd/lp4x-spd-5.hex M src/soc/intel/tigerlake/spd/lp4x_spd_manifest.generated.txt 637 files changed, 185 insertions(+), 10,844 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/44775/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/44775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 Gerrit-Change-Number: 44775 Gerrit-PatchSet: 25 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Add ACPI support for camera in WDee
by Varshit B Pandya (Code Review) 09 Sep '20

09 Sep '20

Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45199 ) Change subject: mb/google/dedede: Add ACPI support for camera in WDee ...................................................................... mb/google/dedede: Add ACPI support for camera in WDee Update overridetree of Waddledee to generate SSDT entries for Camera. 1. Add support as per the schematics 2. Add 2 Ports and 2 Endpoints 3. Add support for OVTI5675 and OVTI9734 Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I3b2b1a679074984a44d989eaaf1816d42f21b302 --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 2 files changed, 129 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/45199/1 diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 971e646..412b1a2 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -49,6 +49,8 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP select BOARD_ROMSIZE_KB_32768 + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU config BOARD_GOOGLE_WHEELIE bool "Wheelie" diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index a525a0f..c6da5ab 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -55,7 +55,21 @@ }" device domain 0 on - device pci 05.0 on end # IPU - MIPI Camera + device pci 05.0 on # IPU - MIPI Camera + chip drivers/intel/mipi_camera + register "acpi_uid" = "0x50000" + register "acpi_name" = ""IPU0"" + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + + register "cio2_num_ports" = "2" + register "cio2_lanes_used" = "{1,2}" + register "cio2_lane_endpoint[0]" = ""^I2C5.CAM0"" + register "cio2_lane_endpoint[1]" = ""^I2C3.CAM1"" + register "cio2_prt[0]" = "0" + register "cio2_prt[1]" = "2" + device generic 0 on end + end + end device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on @@ -119,6 +133,78 @@ device i2c 0x5d on end end end # I2C 2 + device pci 15.3 on # I2C 3 + chip drivers/intel/mipi_camera + register "acpi_hid" = ""OVTI5675"" + register "acpi_uid" = "0" + register "acpi_name" = ""CAM1"" + register "chip_name" = ""Ov 5675 Camera"" + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + + register "ssdb.lanes_used" = "2" + register "ssdb.link_used" = "1" + register "ssdb.vcm_type" = "0x0C" + register "vcm_name" = ""VCM0"" + register "num_freq_entries" = "1" + register "link_freq[0]" = "DEFAULT_LINK_FREQ" + register "remote_name" = ""IPU0"" + + register "has_power_resource" = "1" + #Controls + register "clk_panel.clks[0].clknum" = "1" #IMGCLKOUT_1 + register "clk_panel.clks[0].freq" = "1" #19.2 Mhz + + register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8 + register "gpio_panel.gpio[1].gpio_num" = "GPP_D14" #power_enable_1p2 + register "gpio_panel.gpio[2].gpio_num" = "GPP_D12" #reset + + #_ON + register "on_seq.ops_cnt" = "5" + register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" + register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)" + register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" + + #_OFF + register "off_seq.ops_cnt" = "4" + register "off_seq.ops[0]" = "SEQ_OPS_CLK_DISABLE(0, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(2, 0)" + register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + + device i2c 36 on end + end + chip drivers/intel/mipi_camera + register "acpi_uid" = "3" + register "acpi_name" = ""VCM0"" + register "chip_name" = ""DW AF DAC"" + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + + register "pr0" = ""\\_SB.PCI0.I2C5.CAM1.PRIC"" + register "vcm_compat" = ""dongwoon,dw9714"" + + device i2c 0C on end + + end + chip drivers/intel/mipi_camera + register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" + register "acpi_uid" = "1" + register "acpi_name" = ""NVM0"" + register "chip_name" = ""GT24C08"" + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + + register "pr0" = ""\\_SB.PCI0.I2C3.CAM1.PRIC"" + + register "nvm_size" = "0x2000" + register "nvm_pagesize" = "1" + register "nvm_readonly" = "1" + register "nvm_width" = "0x10" + register "nvm_compat" = ""atmel,24c08"" + + device i2c 50 on end + end + end device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" @@ -144,6 +230,46 @@ device i2c 29 on end end end + device pci 19.1 on # I2C 5 + chip drivers/intel/mipi_camera + register "acpi_hid" = ""OVTI9734"" + register "acpi_uid" = "0" + register "acpi_name" = ""CAM0"" + register "chip_name" = ""Ov 9734 Camera"" + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "has_power_resource" = "1" + + register "ssdb.lanes_used" = "1" + register "num_freq_entries" = "1" + register "link_freq[0]" = "180000000" + register "remote_name" = ""IPU0"" + + #Controls + register "clk_panel.clks[0].clknum" = "0" #IMGCLKOUT_0 + register "clk_panel.clks[0].freq" = "1" #19.2 Mhz + + register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8 + register "gpio_panel.gpio[1].gpio_num" = "GPP_D14" #power_enable_1p2 + register "gpio_panel.gpio[2].gpio_num" = "GPP_D15" #reset + + #_ON + register "on_seq.ops_cnt" = "5" + register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" + register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)" + register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" + + #_OFF + register "off_seq.ops_cnt" = "4" + register "off_seq.ops[0]" = "SEQ_OPS_CLK_DISABLE(0, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(2, 0)" + register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + + device i2c 36 on end + end + end device pci 1c.7 on chip drivers/wifi/generic register "wake" = "GPE0_DW2_03" -- To view, visit https://review.coreboot.org/c/coreboot/+/45199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b2b1a679074984a44d989eaaf1816d42f21b302 Gerrit-Change-Number: 45199 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/google/volteer/var/trondo: Add memory parts and generate DRAM IDs
by David Wu (Code Review) 09 Sep '20

09 Sep '20

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45164 ) Change subject: mb/google/volteer/var/trondo: Add memory parts and generate DRAM IDs ...................................................................... mb/google/volteer/var/trondo: Add memory parts and generate DRAM IDs Add memory parts and generate DRAM IDs for trondo. BUG=None TEST=FW_NAME=trondo emerge-volteer coreboot chromeos-bootimage Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I2e89ecaf73a30595ed48ac9ce94ccbd4bb7ed3c2 --- M src/mainboard/google/volteer/variants/trondo/Makefile.inc A src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc A src/mainboard/google/volteer/variants/trondo/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/trondo/memory/mem_list_variant.txt 4 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/45164/1 diff --git a/src/mainboard/google/volteer/variants/trondo/Makefile.inc b/src/mainboard/google/volteer/variants/trondo/Makefile.inc index c9a128d..13269db 100644 --- a/src/mainboard/google/volteer/variants/trondo/Makefile.inc +++ b/src/mainboard/google/volteer/variants/trondo/Makefile.inc @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -SPD_SOURCES = - bootblock-y += gpio.c ramstage-y += gpio.c diff --git a/src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc b/src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc new file mode 100644 index 0000000..f40fba6 --- /dev/null +++ b/src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR diff --git a/src/mainboard/google/volteer/variants/trondo/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/trondo/memory/dram_id.generated.txt new file mode 100644 index 0000000..8d472df --- /dev/null +++ b/src/mainboard/google/volteer/variants/trondo/memory/dram_id.generated.txt @@ -0,0 +1,7 @@ +DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +H9HCNNNCPMMLXR-NEE 2 (0010) +K4UBE3D4AA-MGCR 2 (0010) diff --git a/src/mainboard/google/volteer/variants/trondo/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/trondo/memory/mem_list_variant.txt new file mode 100644 index 0000000..5ddd52e --- /dev/null +++ b/src/mainboard/google/volteer/variants/trondo/memory/mem_list_variant.txt @@ -0,0 +1,6 @@ +MT53E512M32D2NP-046 WT:E +H9HCNNNBKMMLXR-NEE +K4U6E3S4AA-MGCR +MT53E1G32D2NP-046 WT:A +H9HCNNNCPMMLXR-NEE +K4UBE3D4AA-MGCR -- To view, visit https://review.coreboot.org/c/coreboot/+/45164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e89ecaf73a30595ed48ac9ce94ccbd4bb7ed3c2 Gerrit-Change-Number: 45164 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

3 4

Change in coreboot[master]: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi, Tim Wawrzynczak, Paul Menzel, Angel Pons, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45146 to look at the new patch set (#5). Change subject: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory ...................................................................... mb/*: drop GENERIC_SPD_BIN from boards without soldered memory Some boards select GENERIC_SPD_BIN, despite having no soldered memory. Drop the option to stop failing the build due to empty SPD_SOURCES, that gets added in the follow-up change. Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/asrock/h110m/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/saddlebrook/Kconfig M src/mainboard/prodrive/hermes/Kconfig 7 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45146/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff Gerrit-Change-Number: 45146 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/mb/google/hatch: remove "sushi" variant.
by Paul Fagerburg (Code Review) 09 Sep '20

09 Sep '20

Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45175 ) Change subject: src/mb/google/hatch: remove "sushi" variant. ...................................................................... src/mb/google/hatch: remove "sushi" variant. Sushi is not a real product, just a test of the new_variant program. The effort to keep it up-to-date with the rest of Hatch is no longer worth it. Remove the variant. Signed-off-by: Paul Fagerburg <pfagerburg(a)chromium.org> Change-Id: I2b0036f3cbdea4bfaed1274ab87a20d24c75de57 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name D src/mainboard/google/hatch/variants/sushi/Makefile.inc D src/mainboard/google/hatch/variants/sushi/include/variant/acpi/dptf.asl D src/mainboard/google/hatch/variants/sushi/include/variant/ec.h D src/mainboard/google/hatch/variants/sushi/include/variant/gpio.h D src/mainboard/google/hatch/variants/sushi/overridetree.cb 7 files changed, 0 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/45175/1 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 782bed9..e4e343b 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -140,7 +140,6 @@ default "Nightfury" if BOARD_GOOGLE_NIGHTFURY default "Puff" if BOARD_GOOGLE_PUFF default "Stryke" if BOARD_GOOGLE_STRYKE - default "Sushi" if BOARD_GOOGLE_SUSHI default "Wyvern" if BOARD_GOOGLE_WYVERN default "Dooly" if BOARD_GOOGLE_DOOLY @@ -174,7 +173,6 @@ default "nightfury" if BOARD_GOOGLE_NIGHTFURY default "puff" if BOARD_GOOGLE_PUFF default "stryke" if BOARD_GOOGLE_STRYKE - default "sushi" if BOARD_GOOGLE_SUSHI default "wyvern" if BOARD_GOOGLE_WYVERN default "dooly" if BOARD_GOOGLE_DOOLY diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index f4fe50e..69bb28a 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -90,10 +90,6 @@ bool "-> Stryke" select BOARD_GOOGLE_BASEBOARD_HATCH -config BOARD_GOOGLE_SUSHI - bool "-> Sushi" - select BOARD_GOOGLE_BASEBOARD_HATCH - config BOARD_GOOGLE_WYVERN bool "-> Wyvern" select BOARD_GOOGLE_BASEBOARD_PUFF diff --git a/src/mainboard/google/hatch/variants/sushi/Makefile.inc b/src/mainboard/google/hatch/variants/sushi/Makefile.inc deleted file mode 100644 index a115aa9..0000000 --- a/src/mainboard/google/hatch/variants/sushi/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -SPD_SOURCES = diff --git a/src/mainboard/google/hatch/variants/sushi/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/sushi/include/variant/acpi/dptf.asl deleted file mode 100644 index fd3b5cf..0000000 --- a/src/mainboard/google/hatch/variants/sushi/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/hatch/variants/sushi/include/variant/ec.h b/src/mainboard/google/hatch/variants/sushi/include/variant/ec.h deleted file mode 100644 index ce6fbfe..0000000 --- a/src/mainboard/google/hatch/variants/sushi/include/variant/ec.h +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef VARIANT_EC_H -#define VARIANT_EC_H - -#include <baseboard/ec.h> - -#endif diff --git a/src/mainboard/google/hatch/variants/sushi/include/variant/gpio.h b/src/mainboard/google/hatch/variants/sushi/include/variant/gpio.h deleted file mode 100644 index d08b33b..0000000 --- a/src/mainboard/google/hatch/variants/sushi/include/variant/gpio.h +++ /dev/null @@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef VARIANT_GPIO_H -#define VARIANT_GPIO_H - -#include <baseboard/gpio.h> - -/* Memory configuration board straps */ -/* Copied from baseboard and may need to change for the new variant. */ -#define GPIO_MEM_CONFIG_0 GPP_F20 -#define GPIO_MEM_CONFIG_1 GPP_F21 -#define GPIO_MEM_CONFIG_2 GPP_F11 -#define GPIO_MEM_CONFIG_3 GPP_F22 - -#endif diff --git a/src/mainboard/google/hatch/variants/sushi/overridetree.cb b/src/mainboard/google/hatch/variants/sushi/overridetree.cb deleted file mode 100644 index abbcaaa..0000000 --- a/src/mainboard/google/hatch/variants/sushi/overridetree.cb +++ /dev/null @@ -1,6 +0,0 @@ -chip soc/intel/cannonlake - - device domain 0 on - end - -end -- To view, visit https://review.coreboot.org/c/coreboot/+/45175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b0036f3cbdea4bfaed1274ab87a20d24c75de57 Gerrit-Change-Number: 45175 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: newchange

5 7

Change in coreboot[master]: mb/google/volteer: Fix GPP_E12 definition
by Paul Menzel (Code Review) 09 Sep '20

09 Sep '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45197 ) Change subject: mb/google/volteer: Fix GPP_E12 definition ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/45197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3ef864827aa94b0b96e335565119f3d5d008837 Gerrit-Change-Number: 45197 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 14:30:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork: Switch zork to use spd_tools
by Rob Barnes (Code Review) 09 Sep '20

09 Sep '20

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44480 ) Change subject: mb/google/zork: Switch zork to use spd_tools ...................................................................... mb/google/zork: Switch zork to use spd_tools Switch all zork boards to use generate SPDs from spd_tools. BUG=b:162939176 TEST=Boot ezkinil Signed-off-by: Rob Barnes <robbarnes(a)google.com> Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5 --- M src/mainboard/google/zork/spd/Makefile.inc M src/mainboard/google/zork/variants/baseboard/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc A src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc A src/mainboard/google/zork/variants/dalboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/dalboz/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc A src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc A src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc A src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/trembyle/Makefile.inc A src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc A src/mainboard/google/zork/variants/trembyle/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/trembyle/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc A src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt M src/soc/amd/picasso/Makefile.inc 28 files changed, 219 insertions(+), 216 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44480/1 diff --git a/src/mainboard/google/zork/spd/Makefile.inc b/src/mainboard/google/zork/spd/Makefile.inc index e401fa6..66957d8 100644 --- a/src/mainboard/google/zork/spd/Makefile.inc +++ b/src/mainboard/google/zork/spd/Makefile.inc @@ -2,28 +2,3 @@ # This directory SPD_SOURCES_DIR := src/mainboard/$(MAINBOARDDIR)/spd - -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# TODO: Remove channel suffix when b:141434940 is fixed -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = hynix-H5AN8G6NCJR-VKC_x1 # 0b0000 -APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x2 # 0b0001 -APCB_SOURCES += empty # 0b0010 -APCB_SOURCES += empty # 0b0011 -APCB_SOURCES += empty # 0b0100 -APCB_SOURCES += empty # 0b0101 -APCB_SOURCES += empty # 0b0110 -APCB_SOURCES += empty # 0b0111 -APCB_SOURCES += empty # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 -APCB_SOURCES += empty # 0b1111 diff --git a/src/mainboard/google/zork/variants/baseboard/Makefile.inc b/src/mainboard/google/zork/variants/baseboard/Makefile.inc index c9e3657..dd9b7f3 100644 --- a/src/mainboard/google/zork/variants/baseboard/Makefile.inc +++ b/src/mainboard/google/zork/variants/baseboard/Makefile.inc @@ -49,11 +49,13 @@ APCB_BOARD_ID_GPIO1 = 120 1 0 APCB_BOARD_ID_GPIO2 = 131 3 0 APCB_BOARD_ID_GPIO3 = 116 1 0 +APCB_X2_CHANNELS = true else ifeq ($(CONFIG_BOARD_GOOGLE_BASEBOARD_DALBOZ),y) APCB_BOARD_ID_GPIO0 = 132 1 0 APCB_BOARD_ID_GPIO1 = 90 1 0 APCB_BOARD_ID_GPIO2 = 86 3 0 APCB_BOARD_ID_GPIO3 = 69 1 0 +APCB_X2_CHANNELS = false else $(error Undefined APCB selection GPIOS for Zork baseboard) endif #($(CONFIG_BOARD_GOOGLE_BASEBOARD_TREMBYLE),y) diff --git a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc index f53e662..63a75de 100644 --- a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc @@ -1,26 +1,13 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = samsung-K4A8G165WC-BCTD_x2 # 0b0000 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x2 # 0b0001 -# b/149596178: We can't use dual channel channel until the PSP supports missing -# channels. -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x2 # 0b0010 -APCB_SOURCES += hynix-H5AN8G6NDJR-XNC_x1 # 0b0011 -APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x2 # 0b0100 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x1 # 0b0101 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x2 # 0b0110 -APCB_SOURCES += hynix-H5ANAG6NCMR-XNC_x2 # 0b0111 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x2 # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 +SPD_SOURCES = +SPD_SOURCES += spd-4.hex # ID = 0(0b0000) Parts = K4A8G165WC-BCTD +SPD_SOURCES += spd-8.hex # ID = 1(0b0001) Parts = K4A8G165WC-BCWE +SPD_SOURCES += spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-1.hex # ID = 3(0b0011) Parts = H5AN8G6NDJR-XNC +SPD_SOURCES += spd-7.hex # ID = 4(0b0100) Parts = H5ANAG6NCMR-VKC +SPD_SOURCES += spd-8.hex # ID = 5(0b0101) Parts = K4A8G165WC-BCWE +SPD_SOURCES += spd-8.hex # ID = 6(0b0110) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-3.hex # ID = 7(0b0111) Parts = H5ANAG6NCMR-XNC +SPD_SOURCES += spd-8.hex # ID = 8(0b1000) Parts = K4AAG165WA-BCWE diff --git a/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt new file mode 100644 index 0000000..32b5981 --- /dev/null +++ b/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt @@ -0,0 +1,10 @@ +DRAM Part Name ID to assign +K4A8G165WC-BCTD 0 (0000) +K4A8G165WC-BCWE 1 (0001) +MT40A512M16TB-062E:J 2 (0010) +H5AN8G6NDJR-XNC 3 (0011) +H5ANAG6NCMR-VKC 4 (0100) +K4A8G165WC-BCWE 5 (0101) +MT40A1G16KD-062E:E 6 (0110) +H5ANAG6NCMR-XNC 7 (0111) +K4AAG165WA-BCWE 8 (1000) diff --git a/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt new file mode 100644 index 0000000..1c88e23 --- /dev/null +++ b/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +K4A8G165WC-BCTD, 0 +K4A8G165WC-BCWE, 1 +MT40A512M16TB-062E:J, 2 +H5AN8G6NDJR-XNC, 3 +H5ANAG6NCMR-VKC, 4 +K4A8G165WC-BCWE, 5 +MT40A1G16KD-062E:E, 6 +H5ANAG6NCMR-XNC, 7 +K4AAG165WA-BCWE, 8 diff --git a/src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc index 7baf8be..026c696 100644 --- a/src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc @@ -1,25 +1,9 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = hynix-HMA851S6CJR6N-VK_x1 # 0b0000 -APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x1 # 0b0001 -APCB_SOURCES += samsung-K4A8G165WC-BCTD_x1 # 0b0010 -APCB_SOURCES += samsung-K4AAG165WB-MCTD_x1 # 0b0011 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x1 # 0b0100 -APCB_SOURCES += empty # 0b0101 -APCB_SOURCES += empty # 0b0110 -APCB_SOURCES += empty # 0b0111 -APCB_SOURCES += empty # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 -APCB_SOURCES += empty # 0b1111 +SPD_SOURCES = +SPD_SOURCES += spd-4.hex # ID = 0(0b0000) Parts = HMA851S6CJR6N-VK +SPD_SOURCES += spd-7.hex # ID = 1(0b0001) Parts = H5ANAG6NCMR-VKC +SPD_SOURCES += spd-4.hex # ID = 2(0b0010) Parts = K4A8G165WC-BCTD +SPD_SOURCES += spd-6.hex # ID = 3(0b0011) Parts = K4AAG165WB-MCTD +SPD_SOURCES += spd-8.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCWE diff --git a/src/mainboard/google/zork/variants/dalboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/dalboz/spd/dram_id.generated.txt new file mode 100644 index 0000000..f70d7f3 --- /dev/null +++ b/src/mainboard/google/zork/variants/dalboz/spd/dram_id.generated.txt @@ -0,0 +1,6 @@ +DRAM Part Name ID to assign +HMA851S6CJR6N-VK 0 (0000) +H5ANAG6NCMR-VKC 1 (0001) +K4A8G165WC-BCTD 2 (0010) +K4AAG165WB-MCTD 3 (0011) +K4A8G165WC-BCWE 4 (0100) diff --git a/src/mainboard/google/zork/variants/dalboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/dalboz/spd/mem_parts_used.txt new file mode 100644 index 0000000..f254851 --- /dev/null +++ b/src/mainboard/google/zork/variants/dalboz/spd/mem_parts_used.txt @@ -0,0 +1,5 @@ +HMA851S6CJR6N-VK, 0 +H5ANAG6NCMR-VKC, 1 +K4A8G165WC-BCTD, 2 +K4AAG165WB-MCTD, 3 +K4A8G165WC-BCWE, 4 diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc index 480e757..66a0f6c 100644 --- a/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc @@ -1,25 +1,15 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = hynix-HMA851S6CJR6N-VK_x1 # 0b0000 -APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x1 # 0b0001 -APCB_SOURCES += samsung-K4A8G165WC-BCTD_x1 # 0b0010 -APCB_SOURCES += samsung-K4AAG165WB-MCTD_x1 # 0b0011 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x1 # 0b0100 -APCB_SOURCES += hynix-H5AN8G6NDJR-XNC_x1 # 0b0101 -APCB_SOURCES += hynix-H5ANAG6NCMR-XNC_x1 # 0b0110 -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x1 # 0b0111 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x1 # 0b1000 -APCB_SOURCES += samsung-K4AAG165WA-BCTD_x1 # 0b1001 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x1 # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 -APCB_SOURCES += empty # 0b1111 +SPD_SOURCES = +SPD_SOURCES += spd-4.hex # ID = 0(0b0000) Parts = HMA851S6CJR6N-VK +SPD_SOURCES += spd-7.hex # ID = 1(0b0001) Parts = H5ANAG6NCMR-VKC +SPD_SOURCES += spd-4.hex # ID = 2(0b0010) Parts = K4A8G165WC-BCTD +SPD_SOURCES += spd-6.hex # ID = 3(0b0011) Parts = K4AAG165WB-MCTD +SPD_SOURCES += spd-8.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCWE +SPD_SOURCES += spd-1.hex # ID = 5(0b0101) Parts = H5AN8G6NDJR-XNC +SPD_SOURCES += spd-3.hex # ID = 6(0b0110) Parts = H5ANAG6NCMR-XNC +SPD_SOURCES += spd-1.hex # ID = 7(0b0111) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-8.hex # ID = 8(0b1000) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-8.hex # ID = 9(0b1001) Parts = K4AAG165WA-BCTD +SPD_SOURCES += spd-8.hex # ID = 10(0b1010) Parts = K4AAG165WA-BCWE diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt new file mode 100644 index 0000000..9d4b9f3 --- /dev/null +++ b/src/mainboard/google/zork/variants/dirinboz/spd/dram_id.generated.txt @@ -0,0 +1,12 @@ +DRAM Part Name ID to assign +HMA851S6CJR6N-VK 0 (0000) +H5ANAG6NCMR-VKC 1 (0001) +K4A8G165WC-BCTD 2 (0010) +K4AAG165WB-MCTD 3 (0011) +K4A8G165WC-BCWE 4 (0100) +H5AN8G6NDJR-XNC 5 (0101) +H5ANAG6NCMR-XNC 6 (0110) +MT40A512M16TB-062E:J 7 (0111) +MT40A1G16KD-062E:E 8 (1000) +K4AAG165WA-BCTD 9 (1001) +K4AAG165WA-BCWE 10 (1010) diff --git a/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt new file mode 100644 index 0000000..9035dee --- /dev/null +++ b/src/mainboard/google/zork/variants/dirinboz/spd/mem_parts_used.txt @@ -0,0 +1,11 @@ +HMA851S6CJR6N-VK, 0 +H5ANAG6NCMR-VKC, 1 +K4A8G165WC-BCTD, 2 +K4AAG165WB-MCTD, 3 +K4A8G165WC-BCWE, 4 +H5AN8G6NDJR-XNC, 5 +H5ANAG6NCMR-XNC, 6 +MT40A512M16TB-062E:J, 7 +MT40A1G16KD-062E:E, 8 +K4AAG165WA-BCTD, 9 +K4AAG165WA-BCWE, 10 diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc index cd91272..dfe2661 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc @@ -1,25 +1,9 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = hynix-H5AN8G6NCJR-VKC_x2 # 0b0000 -APCB_SOURCES += hynix-HMAA1GS6CMR6N-VK_x2 # 0b0001 -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x2 # 0b0010 -APCB_SOURCES += micron-MT40A1G16KNR-075-E_x2 # 0b0011 -APCB_SOURCES += samsung-K4A8G165WC-BCTD_x2 # 0b0100 -APCB_SOURCES += empty # 0b0101 -APCB_SOURCES += empty # 0b0110 -APCB_SOURCES += empty # 0b0111 -APCB_SOURCES += empty # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 -APCB_SOURCES += empty # 0b1111 +SPD_SOURCES = +SPD_SOURCES += spd-4.hex # ID = 0(0b0000) Parts = H5AN8G6NCJR-VKC +SPD_SOURCES += spd-2.hex # ID = 1(0b0001) Parts = HMAA1GS6CMR6N-VK +SPD_SOURCES += spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-5.hex # ID = 3(0b0011) Parts = MT40A1G16KNR-075:E +SPD_SOURCES += spd-4.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCTD diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt new file mode 100644 index 0000000..037b69b --- /dev/null +++ b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt @@ -0,0 +1,6 @@ +DRAM Part Name ID to assign +H5AN8G6NCJR-VKC 0 (0000) +HMAA1GS6CMR6N-VK 1 (0001) +MT40A512M16TB-062E:J 2 (0010) +MT40A1G16KNR-075:E 3 (0011) +K4A8G165WC-BCTD 4 (0100) diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt new file mode 100644 index 0000000..5187d57 --- /dev/null +++ b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt @@ -0,0 +1,5 @@ +H5AN8G6NCJR-VKC, 0 +HMAA1GS6CMR6N-VK, 1 +MT40A512M16TB-062E:J, 2 +MT40A1G16KNR-075:E, 3 +K4A8G165WC-BCTD, 4 diff --git a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc index 080d468..25fb789 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc @@ -1,26 +1,14 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# Alternatively, generated APCBs stored at -# 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/APCB_{NAME}.bin will be included. -APCB_SOURCES = samsung-K4AAG165WA-BCWE_x2 # 0b0000 -APCB_SOURCES += empty # 0b0001 -# b/149596178: We can't use dual channel channel until the PSP supports missing -# channels. -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x1 # 0b0010 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x2 # 0b0011 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x1 # 0b0100 -APCB_SOURCES += hynix-H5AN8G6NDJR-XNC_x1 # 0b0101 -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x1 # 0b0110 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x2 # 0b0111 -APCB_SOURCES += hynix-H5ANAG6NCMR-XNC_x2 # 0b1000 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x2 # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 +SPD_SOURCES = +SPD_SOURCES += spd-8.hex # ID = 0(0b0000) Parts = K4AAG165WA-BCWE +SPD_SOURCES += spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-8.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-8.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCWE +SPD_SOURCES += spd-1.hex # ID = 5(0b0101) Parts = H5AN8G6NDJR-XNC +SPD_SOURCES += spd-1.hex # ID = 6(0b0110) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-8.hex # ID = 7(0b0111) Parts = K4AAG165WA-BCWE +SPD_SOURCES += spd-3.hex # ID = 8(0b1000) Parts = H5ANAG6NCMR-XNC +SPD_SOURCES += spd-8.hex # ID = 9(0b1001) Parts = K4A8G165WC-BCWE diff --git a/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt new file mode 100644 index 0000000..7210071 --- /dev/null +++ b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt @@ -0,0 +1,10 @@ +DRAM Part Name ID to assign +K4AAG165WA-BCWE 0 (0000) +MT40A512M16TB-062E:J 2 (0010) +MT40A1G16KD-062E:E 3 (0011) +K4A8G165WC-BCWE 4 (0100) +H5AN8G6NDJR-XNC 5 (0101) +MT40A512M16TB-062E:J 6 (0110) +K4AAG165WA-BCWE 7 (0111) +H5ANAG6NCMR-XNC 8 (1000) +K4A8G165WC-BCWE 9 (1001) diff --git a/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt new file mode 100644 index 0000000..cc83b11 --- /dev/null +++ b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +K4AAG165WA-BCWE, 0 +MT40A512M16TB-062E:J, 2 +MT40A1G16KD-062E:E, 3 +K4A8G165WC-BCWE, 4 +H5AN8G6NDJR-XNC, 5 +MT40A512M16TB-062E:J, 6 +K4AAG165WA-BCWE, 7 +H5ANAG6NCMR-XNC, 8 +K4A8G165WC-BCWE, 9 \ No newline at end of file diff --git a/src/mainboard/google/zork/variants/trembyle/Makefile.inc b/src/mainboard/google/zork/variants/trembyle/Makefile.inc index 0b6bc4b..e22847e 100644 --- a/src/mainboard/google/zork/variants/trembyle/Makefile.inc +++ b/src/mainboard/google/zork/variants/trembyle/Makefile.inc @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-or-later -subdirs-y += ../baseboard/spd +subdirs-y += ../spd ramstage-y += gpio.c diff --git a/src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc b/src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc new file mode 100644 index 0000000..aeac9a7 --- /dev/null +++ b/src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc @@ -0,0 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-4.hex # ID = 0(0b0000) Parts = H5AN8G6NCJR-VKC +SPD_SOURCES += spd-7.hex # ID = 1(0b0001) Parts = H5ANAG6NCMR-VKC diff --git a/src/mainboard/google/zork/variants/trembyle/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/trembyle/spd/dram_id.generated.txt new file mode 100644 index 0000000..20232a3 --- /dev/null +++ b/src/mainboard/google/zork/variants/trembyle/spd/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +H5AN8G6NCJR-VKC 0 (0000) +H5ANAG6NCMR-VKC 1 (0001) diff --git a/src/mainboard/google/zork/variants/trembyle/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/trembyle/spd/mem_parts_used.txt new file mode 100644 index 0000000..1a19bdf --- /dev/null +++ b/src/mainboard/google/zork/variants/trembyle/spd/mem_parts_used.txt @@ -0,0 +1,2 @@ +H5AN8G6NCJR-VKC, 0 +H5ANAG6NCMR-VKC, 1 \ No newline at end of file diff --git a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc index c9a9108..25fb789 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc @@ -1,26 +1,14 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -# Ordered List of APCB entries, up to 16. -# Entries should match this pattern {NAME}_x{1,2} -# There should be a matching SPD hex file in SPD_SOURCES_DIR -# matching the pattern {NAME}.spd.hex -# The _x{1,2} suffix denotes single or dual channel -# TODO: Remove channel suffix when b:141434940 is fixed -# Alternatively, generated APCBs stored at -# CONFIG_APCB_BLOB_DIR/APCB_{NAME}.bin can be included. -APCB_SOURCES = hynix-H5AN8G6NCJR-VKC_x1 # 0b0000 -APCB_SOURCES += hynix-H5ANAG6NCMR-VKC_x1 # 0b0001 -APCB_SOURCES += samsung-K4A8G165WC-BCWE_x1 # 0b0010 -APCB_SOURCES += hynix-H5AN8G6NDJR-XNC_x1 # 0b0011 -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x1 # 0b0100 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x1 # 0b0101 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x1 # 0b0110 -APCB_SOURCES += empty # 0b0111 -APCB_SOURCES += empty # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 -APCB_SOURCES += empty # 0b1011 -APCB_SOURCES += empty # 0b1100 -APCB_SOURCES += empty # 0b1101 -APCB_SOURCES += empty # 0b1110 -APCB_SOURCES += empty # 0b1111 +SPD_SOURCES = +SPD_SOURCES += spd-8.hex # ID = 0(0b0000) Parts = K4AAG165WA-BCWE +SPD_SOURCES += spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-8.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-8.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCWE +SPD_SOURCES += spd-1.hex # ID = 5(0b0101) Parts = H5AN8G6NDJR-XNC +SPD_SOURCES += spd-1.hex # ID = 6(0b0110) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-8.hex # ID = 7(0b0111) Parts = K4AAG165WA-BCWE +SPD_SOURCES += spd-3.hex # ID = 8(0b1000) Parts = H5ANAG6NCMR-XNC +SPD_SOURCES += spd-8.hex # ID = 9(0b1001) Parts = K4A8G165WC-BCWE diff --git a/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt new file mode 100644 index 0000000..7210071 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt @@ -0,0 +1,10 @@ +DRAM Part Name ID to assign +K4AAG165WA-BCWE 0 (0000) +MT40A512M16TB-062E:J 2 (0010) +MT40A1G16KD-062E:E 3 (0011) +K4A8G165WC-BCWE 4 (0100) +H5AN8G6NDJR-XNC 5 (0101) +MT40A512M16TB-062E:J 6 (0110) +K4AAG165WA-BCWE 7 (0111) +H5ANAG6NCMR-XNC 8 (1000) +K4A8G165WC-BCWE 9 (1001) diff --git a/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt new file mode 100644 index 0000000..cc83b11 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +K4AAG165WA-BCWE, 0 +MT40A512M16TB-062E:J, 2 +MT40A1G16KD-062E:E, 3 +K4A8G165WC-BCWE, 4 +H5AN8G6NDJR-XNC, 5 +MT40A512M16TB-062E:J, 6 +K4AAG165WA-BCWE, 7 +H5ANAG6NCMR-XNC, 8 +K4A8G165WC-BCWE, 9 \ No newline at end of file diff --git a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc index 8c60fe6..987331c 100644 --- a/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/woomax/spd/Makefile.inc @@ -1,18 +1,16 @@ -# SPDX-License-Identifier: GPL-2.0-or-later +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! -APCB_SOURCES = micron-MT40A512M16TB-062E-J_x1 # 0b00000 -APCB_SOURCES += hynix-H5AN8G6NCJR-XNC_x1 # 0b00001 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x1 # 0b00010 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x1 # 0b00011 -APCB_SOURCES += empty # 0b00100 -APCB_SOURCES += empty # 0b00101 -APCB_SOURCES += empty # 0b00110 -APCB_SOURCES += empty # 0b00111 -APCB_SOURCES += micron-MT40A512M16TB-062E-J_x2 # 0b01000 -APCB_SOURCES += hynix-H5AN8G6NCJR-XNC_x2 # 0b01001 -APCB_SOURCES += micron-MT40A1G16KD-062E-E_x2 # 0b01010 -APCB_SOURCES += samsung-K4AAG165WA-BCWE_x2 # 0b01011 -APCB_SOURCES += empty # 0b01100 -APCB_SOURCES += empty # 0b01101 -APCB_SOURCES += empty # 0b01110 -APCB_SOURCES += empty # 0b01111 +SPD_SOURCES = +SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-1.hex # ID = 1(0b0001) Parts = H5AN8G6NCJR-XNC +SPD_SOURCES += spd-8.hex # ID = 2(0b0010) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-8.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE +SPD_SOURCES += spd-empty.hex # ID = 4(0b0100) +SPD_SOURCES += spd-empty.hex # ID = 5(0b0101) +SPD_SOURCES += spd-empty.hex # ID = 6(0b0110) +SPD_SOURCES += spd-empty.hex # ID = 7(0b0111) +SPD_SOURCES += spd-1.hex # ID = 8(0b1000) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += spd-1.hex # ID = 9(0b1001) Parts = H5AN8G6NCJR-XNC +SPD_SOURCES += spd-8.hex # ID = 10(0b1010) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += spd-8.hex # ID = 11(0b1011) Parts = K4AAG165WA-BCWE diff --git a/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt new file mode 100644 index 0000000..5c2cda5 --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/spd/dram_id.generated.txt @@ -0,0 +1,9 @@ +DRAM Part Name ID to assign +MT40A512M16TB-062E:J 0 (0000) +H5AN8G6NCJR-XNC 1 (0001) +MT40A1G16KD-062E:E 2 (0010) +K4AAG165WA-BCWE 3 (0011) +MT40A512M16TB-062E:J 8 (1000) +H5AN8G6NCJR-XNC 9 (1001) +MT40A1G16KD-062E:E 10 (1010) +K4AAG165WA-BCWE 11 (1011) diff --git a/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt new file mode 100644 index 0000000..1dccbac --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/spd/mem_parts_used.txt @@ -0,0 +1,8 @@ +MT40A512M16TB-062E:J, 0 +H5AN8G6NCJR-XNC, 1 +MT40A1G16KD-062E:E, 2 +K4AAG165WA-BCWE, 3 +MT40A512M16TB-062E:J, 8 +H5AN8G6NCJR-XNC, 9 +MT40A1G16KD-062E:E, 10 +K4AAG165WA-BCWE, 11 diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index bbb064f..4a40fb0 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -197,7 +197,7 @@ # # type = 0x60 -PSP_APCB_FILES=$(foreach f, $(APCB_SOURCES), $(obj)/APCB_$(f).bin) +PSP_APCB_FILES=$(foreach f, $(basename $(SPD_SOURCES)), $(obj)/APCB_$(f).bin) # type = 0x61 PSP_APOB_BASE=$(CONFIG_PSP_APOB_DRAM_ADDRESS) @@ -386,16 +386,7 @@ # APCB binary with magic numbers to be replaced by apcb_edit tool APCB_MAGIC_BLOB:=$(FIRMWARE_LOCATE)/APCB_magic.bin -$(obj)/APCB_empty.bin: $(APCB_MAGIC_BLOB) $(APCB_EDIT_TOOL) - $(APCB_EDIT_TOOL) \ - $(APCB_MAGIC_BLOB) \ - $@ \ - --board_id_gpio0 $(APCB_BOARD_ID_GPIO0) \ - --board_id_gpio1 $(APCB_BOARD_ID_GPIO1) \ - --board_id_gpio2 $(APCB_BOARD_ID_GPIO2) \ - --board_id_gpio3 $(APCB_BOARD_ID_GPIO3) - -$(obj)/APCB_%_x1.bin: $$(SPD_SOURCES_DIR)/%.spd.hex \ +$(obj)/APCB_%.bin: $$(SPD_SOURCES_DIR)/%.hex \ $(APCB_EDIT_TOOL) \ $(APCB_MAGIC_BLOB) $(APCB_EDIT_TOOL) \ @@ -404,21 +395,7 @@ --hex \ --strip_manufacturer_information \ --spd_0_0 $< \ - --board_id_gpio0 $(APCB_BOARD_ID_GPIO0) \ - --board_id_gpio1 $(APCB_BOARD_ID_GPIO1) \ - --board_id_gpio2 $(APCB_BOARD_ID_GPIO2) \ - --board_id_gpio3 $(APCB_BOARD_ID_GPIO3) - -$(obj)/APCB_%_x2.bin: $$(SPD_SOURCES_DIR)/%.spd.hex \ - $(APCB_EDIT_TOOL) \ - $(APCB_MAGIC_BLOB) - $(APCB_EDIT_TOOL) \ - $(APCB_MAGIC_BLOB) \ - $@ \ - --hex \ - --strip_manufacturer_information \ - --spd_0_0 $< \ - --spd_1_0 $< \ + $$([ $(APCB_X2_CHANNEL) == true ] && echo "--spd_1_0 $<") \ --board_id_gpio0 $(APCB_BOARD_ID_GPIO0) \ --board_id_gpio1 $(APCB_BOARD_ID_GPIO1) \ --board_id_gpio2 $(APCB_BOARD_ID_GPIO2) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/44480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5 Gerrit-Change-Number: 44480 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

9 39

Change in coreboot[master]: Add config IPMI_KCS_IO_TIMEOUT for IPMI KCS timeout value
by Johnny Lin (Code Review) 09 Sep '20

09 Sep '20

Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45103 ) Change subject: Add config IPMI_KCS_IO_TIMEOUT for IPMI KCS timeout value ...................................................................... Add config IPMI_KCS_IO_TIMEOUT for IPMI KCS timeout value The current value of 1000 cycles of 100ns would see timeout occurs on OCP Delta Lake, especially when the log level is smaller than 8 because the prink(BIOS_SPEW, ..) in ipmi_kcs_status() creates delay and avoid the problem, but after setting log level to 4 we see the timeout occurs. Default remains as 1000. Change-Id: I42ede1d9200bb5d0dbb455d2ff66e2816f10e86b Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/drivers/ipmi/Kconfig M src/drivers/ipmi/ipmi_kcs.c 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/45103/1 diff --git a/src/drivers/ipmi/Kconfig b/src/drivers/ipmi/Kconfig index 44ed17e..f86f609 100644 --- a/src/drivers/ipmi/Kconfig +++ b/src/drivers/ipmi/Kconfig @@ -33,3 +33,10 @@ help The PNP base address of BMC KCS. It must be equal to the pnp port value defined in devicetree for chip drivers/ipmi. + +config IPMI_KCS_IO_TIMEOUT + int + default 1000 + depends on IPMI_KCS + help + The timeout time for a single KCS IO in the unit of 100 microseconds. diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c index 1d6b71c..e1f6c75 100644 --- a/src/drivers/ipmi/ipmi_kcs.c +++ b/src/drivers/ipmi/ipmi_kcs.c @@ -35,7 +35,7 @@ static int wait_ibf_timeout(int port) { - int timeout = 1000; + int timeout = CONFIG_IPMI_KCS_IO_TIMEOUT; do { if (!(ipmi_kcs_status(port) & IPMI_KCS_IBF)) return 0; @@ -47,7 +47,7 @@ static int wait_obf_timeout(int port) { - int timeout = 1000; + int timeout = CONFIG_IPMI_KCS_IO_TIMEOUT; do { if ((ipmi_kcs_status(port) & IPMI_KCS_OBF)) return 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/45103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42ede1d9200bb5d0dbb455d2ff66e2816f10e86b Gerrit-Change-Number: 45103 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-MessageType: newchange

5 13

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020