coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2629 discussions

Change in coreboot[master]: lib/Makefile.inc: fix hex-to-bin conversion of SPD files
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45207 ) Change subject: lib/Makefile.inc: fix hex-to-bin conversion of SPD files ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/45207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36b0efac81977e95d3cc4f189c3ae418379fe315 Gerrit-Change-Number: 45207 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: stop using hexdumps for SPD files
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Frans Hendriks, Jeremy Soller, Stefan Reinauer, Angel Pons, Patrick Rudolph, Piotr Król, Nico Huber, Martin Roth, Michał Żygowski, David Guckian, Tim Wawrzynczak, Vanessa Eusebio, Alexander Couzens, Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44775 to look at the new patch set (#27). Change subject: treewide: stop using hexdumps for SPD files ...................................................................... treewide: stop using hexdumps for SPD files SPD files normally don't get edited. Keeping the files as hexdump does not have any advantage and conversion from hex to bin adds complexity with a high chance for bugs and other sorts of problems. One example for such problem is an issue that only appeared on one of my systems, where conversion of '01 02 03' to binary resulted in \x01\x32\x03 instead of \x01\x02\x03: for c in 01 02 03; do printf $(printf '\%o' 0x$c); done | xxd -g 1 00000000: 01 32 03 .2. The reason for this was that the syntax in lib/Makefile.inc is wrong, because the backslash must be escaped due to chaining two printf commands. To avoid future problems, we should remove some of the aforementioned complexity to lower the probability of future encoding problems. Thus, convert all SPD hexdumps to binaries and adapt the Makefiles to just concatenate them to `spd.bin`. The SPDs, manifests and Makefiles for soc/intel/{tiger,jasper}lake and mainboard/google/{dedede,volteer,zork} have been regenerated using the following commands: go run util/spd_tools/ddr4/gen_spd.go src/soc/intel/tigerlake/spd/ \ util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt TGL go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/tigerlake/spd/ \ util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt TGL go run util/spd_tools/lp4x/gen_spd.go src/soc/intel/jasperlake/spd/ \ util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt JSL for v in src/mainboard/google/zork/variants/*; do [ -f ${v}/spd/mem_parts_used.txt ] || continue go run util/spd_tools/ddr4/gen_part_id.go \ src/mainboard/google/zork/spd \ ${v}/spd ${v}/spd/mem_parts_used.txt done for v in src/mainboard/google/{dedede,volteer}/variants/*; do [ -f ${v}/memory/mem_list_variant.txt ] || continue for m in ddr4 lp4x; do go run ./util/spd_tools/${m}/gen_part_id.go \ src/soc/intel/tigerlake/spd ${v}/memory \ ${v}/memory/mem_list_variant.txt done done All other SPD files have been converted with `grep -v "^#" | xxd -ps -r` or `xxd -rg1`, depending on the format. Documentation has been updated where needed. For all affected boards the output binary has been verified to remain identical, using timeless abuild. Exception: google/volteer/variants/lindar will have an empty spd.bin until CB:44848 gets merged. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 --- M .gitignore M Documentation/Intel/Board/board.html M Documentation/soc/amd/family17h.md M src/lib/Kconfig M src/lib/Makefile.inc A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.bin D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_1066.spd.hex A src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.bin D src/mainboard/bap/ode_e20XX/spd/BAP_Q7_800.spd.hex A src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.bin D src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex A src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.bin D src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex A src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin D src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex A src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.bin D src/mainboard/gizmosphere/gizmo/spd/Elpida_EDJ2116DEBG.spd.hex A src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.bin D src/mainboard/gizmosphere/gizmo2/spd/Micron_MT41J128M16JT.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/auron_paine/spd/Makefile.inc A src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.bin D src/mainboard/google/auron/variants/auron_paine/spd/empty.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/auron_yuna/spd/Makefile.inc A src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.bin D src/mainboard/google/auron/variants/auron_yuna/spd/empty.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex M src/mainboard/google/auron/variants/gandof/spd/Makefile.inc A src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.bin D src/mainboard/google/auron/variants/gandof/spd/Samsung_M471B5674EB0-YK0.spd.hex A src/mainboard/google/auron/variants/gandof/spd/empty.spd.bin D src/mainboard/google/auron/variants/gandof/spd/empty.spd.hex M src/mainboard/google/auron/variants/lulu/spd/Makefile.inc A src/mainboard/google/auron/variants/lulu/spd/empty.spd.bin D src/mainboard/google/auron/variants/lulu/spd/empty.spd.hex A src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/auron/variants/lulu/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.bin D src/mainboard/google/auron/variants/lulu/spd/hynix_4GiB_dimm_H5TC8G63CMR-PBA.spd.hex A src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin D src/mainboard/google/auron/variants/lulu/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex A src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.bin D src/mainboard/google/auron/variants/lulu/spd/micron_4GiB_dimm_MT41K512M16TNA-125.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.bin D src/mainboard/google/auron/variants/lulu/spd/samsung_4GiB_dimm_K4B8G1646Q-MYK0.spd.hex M src/mainboard/google/auron/variants/samus/spd/Makefile.inc A src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_16.spd.hex A src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/elpida_8.spd.hex A src/mainboard/google/auron/variants/samus/spd/empty.spd.bin D src/mainboard/google/auron/variants/samus/spd/empty.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_16.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/hynix_8.spd.hex A src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.bin D src/mainboard/google/auron/variants/samus/spd/samsung_4.spd.hex A src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.bin D src/mainboard/google/auron/variants/samus/spd/samsung_8.spd.hex A src/mainboard/google/cyan/spd/empty.spd.bin D src/mainboard/google/cyan/spd/empty.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/cyan/spd/hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.bin D src/mainboard/google/cyan/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-GD-F-R.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_EDF8132A3MA-JD-F.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF-107WT.spd.hex A src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.bin D src/mainboard/google/cyan/spd/micron_2GiB_dimm_MT52L256M32D1PF.spd.hex A src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin D src/mainboard/google/cyan/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex A src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.bin D src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_2GiB_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/cyan/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex M src/mainboard/google/dedede/variants/boten/memory/Makefile.inc M src/mainboard/google/dedede/variants/drawcia/memory/Makefile.inc M src/mainboard/google/dedede/variants/madoo/memory/Makefile.inc M src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc M src/mainboard/google/dedede/variants/waddledee/memory/Makefile.inc M src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc M src/mainboard/google/dedede/variants/wheelie/memory/Makefile.inc M src/mainboard/google/drallion/spd/Makefile.inc A src/mainboard/google/drallion/spd/empty_ddr4.spd.bin D src/mainboard/google/drallion/spd/empty_ddr4.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NDJR-XNC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin D src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCWE.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WA-BCWE.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.bin D src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex A src/mainboard/google/eve/spd/empty.spd.bin D src/mainboard/google/eve/spd/empty.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex A src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin D src/mainboard/google/eve/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4E6E304EB.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4E8E324EB.spd.hex A src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.bin D src/mainboard/google/eve/spd/samsung_dimm_K4EBE304EB.spd.hex A src/mainboard/google/glados/spd/empty.spd.bin D src/mainboard/google/glados/spd/empty.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR-NUD.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8GTMLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNN8JTBLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR-NUD.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLGALAR.spd.hex A src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.bin D src/mainboard/google/glados/spd/hynix_dimm_H9CCNNNCLTMLAR.spd.hex A src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.bin D src/mainboard/google/glados/spd/micron_16GiB_dimm_MT52L1G32D4PG.spd.hex A src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.bin D src/mainboard/google/glados/spd/micron_4GiB_dimm_MT52L256M32D1PF.spd.hex A src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.bin D src/mainboard/google/glados/spd/micron_8GiB_dimm_MT52L512M32D2PF.spd.hex A src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.bin D src/mainboard/google/glados/spd/micron_dimm_MT52L256M32D1PF-107-1G-1866.spd.hex A src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.bin D src/mainboard/google/glados/spd/micron_dimm_MT52L512M32D2PF-107-2G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF-2G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E6E304EE-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E304EE-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF-1G-1866.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCF.spd.hex A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin D src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex A src/mainboard/google/hatch/spd/16G_2400.spd.bin D src/mainboard/google/hatch/spd/16G_2400.spd.hex A src/mainboard/google/hatch/spd/16G_2666.spd.bin D src/mainboard/google/hatch/spd/16G_2666.spd.hex A src/mainboard/google/hatch/spd/16G_2666_2bg.spd.bin D src/mainboard/google/hatch/spd/16G_2666_2bg.spd.hex A src/mainboard/google/hatch/spd/16G_3200.spd.bin D src/mainboard/google/hatch/spd/16G_3200.spd.hex A src/mainboard/google/hatch/spd/16G_3200_4bg.spd.bin D src/mainboard/google/hatch/spd/16G_3200_4bg.spd.hex A src/mainboard/google/hatch/spd/4G_2400.spd.bin D src/mainboard/google/hatch/spd/4G_2400.spd.hex A src/mainboard/google/hatch/spd/8G_2400.spd.bin D src/mainboard/google/hatch/spd/8G_2400.spd.hex A src/mainboard/google/hatch/spd/8G_2666.spd.bin D src/mainboard/google/hatch/spd/8G_2666.spd.hex A src/mainboard/google/hatch/spd/8G_3200.spd.bin D src/mainboard/google/hatch/spd/8G_3200.spd.hex A src/mainboard/google/hatch/spd/LP_16G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_16G_2133.spd.hex A src/mainboard/google/hatch/spd/LP_4G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex A src/mainboard/google/hatch/spd/LP_8G_2133.spd.bin D src/mainboard/google/hatch/spd/LP_8G_2133.spd.hex A src/mainboard/google/hatch/spd/empty_ddr4.spd.bin D src/mainboard/google/hatch/spd/empty_ddr4.spd.hex A src/mainboard/google/kahlee/spd/empty.spd.bin D src/mainboard/google/kahlee/spd/empty.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NAFR-UH.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5AN8G6NCJR-XNC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NAMR-UH.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.bin D src/mainboard/google/kahlee/spd/hynix-H5ANAG6NCMR-XNC.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A1G16KNR-075-E.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A1G16RC-062E-B.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16JY-083E-B.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16LY-075-E.spd.hex A src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.bin D src/mainboard/google/kahlee/spd/micron-MT40A512M16TB-062E-J.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCTD.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4A8G165WC-BCWE.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCTD.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WA-BCWE.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCRC.spd.hex A src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.bin D src/mainboard/google/kahlee/spd/samsung-K4AAG165WB-MCTD.spd.hex A src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.bin D src/mainboard/google/link/spd/elpida_4Gb_1600_x16.spd.hex A src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.bin D src/mainboard/google/link/spd/micron_4Gb_1600_1.35v_x16.spd.hex A src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.bin D src/mainboard/google/link/spd/samsung_4Gb_1600_1.35v_x16.spd.hex M src/mainboard/google/poppy/spd/Makefile.inc A src/mainboard/google/poppy/spd/empty.spd.bin D src/mainboard/google/poppy/spd/empty.spd.hex A src/mainboard/google/poppy/spd/empty_ddr4.spd.bin D src/mainboard/google/poppy/spd/empty_ddr4.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NBJR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NAFR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAMR-UHC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNN8GTALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBJTALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCPTALBR-NUD.spd.hex A src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.bin D src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNFAGMLLR-NUD.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L1G64D8QC-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-093.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M32D1PF-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L256M64D2PP-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-093.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex A src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.bin D src/mainboard/google/poppy/spd/micron_dimm_MT52L512M64D4PQ-107.spd.hex A src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.bin D src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QF3F30BM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QF4F40BM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K3QFAFA0CM-AGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4AAG165WB-MCRC.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EB-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304EC-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E6E304ED-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324EB-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4E8E324ED-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCF.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304EC-EGCG.spd.hex A src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.bin D src/mainboard/google/poppy/spd/samsung_dimm_K4EBE304ED-EGCG.spd.hex A src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.bin D src/mainboard/google/rambi/spd/HT_micron_HTTC4G63CFR-PBA_x16_4Gb.spd.hex A src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.bin D src/mainboard/google/rambi/spd/Hynix_HMT425S6CFR6A_H5TC4G63CFR.spd.hex A src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/rambi/spd/Samsung_2Gib_K4B4G1646Q-HYK0.spd.hex A src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.bin D src/mainboard/google/rambi/spd/Samsung_2Gib_M471B5674QH0.spd.hex A src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.bin D src/mainboard/google/rambi/spd/elpida_2GiB_dimm_EDJ4216EFBG-GNL-F.spd.hex A src/mainboard/google/rambi/spd/empty.spd.bin D src/mainboard/google/rambi/spd/empty.spd.hex A src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_1GiB_dimm_H5TC2G63FFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63AFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63CFR-PBA.spd.hex A src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.bin D src/mainboard/google/rambi/spd/hynix_2GiB_dimm_H5TC4G63MFR-PBA.spd.hex A src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.bin D src/mainboard/google/rambi/spd/micron_1GiB_dimm_MT41K128M16JT-125.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16HA-125a.spd.hex A src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.bin D src/mainboard/google/rambi/spd/micron_2GiB_dimm_MT41K256M16TW-107.spd.hex A src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_1GiB_dimm_K4B2G1646Q-BYK0.spd.hex A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646E-BYK0.spd.hex A src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.bin D src/mainboard/google/rambi/spd/samsung_2GiB_dimm_K4B4G1646Q-HYK0.spd.hex M src/mainboard/google/slippy/variants/falco/Makefile.inc A src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Elpida_EDJ4216EFBG.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.bin D src/mainboard/google/slippy/variants/falco/spd/Samsung_M471B5674QH0.spd.hex M src/mainboard/google/slippy/variants/leon/Makefile.inc A src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.bin D src/mainboard/google/slippy/variants/leon/spd/Samsung_K4B4G1646Q.spd.hex M src/mainboard/google/slippy/variants/peppy/Makefile.inc A src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Elpida_EDJ4216EFBG.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Hynix_HMT425S6CFR6A.spd.hex A src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/peppy/spd/Micron_4KTF25664HZ.spd.hex M src/mainboard/google/slippy/variants/wolf/Makefile.inc A src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Hynix_HMT425S6AFR6A.spd.hex A src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Micron_4KTF25664HZ.spd.hex A src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.bin D src/mainboard/google/slippy/variants/wolf/spd/Samsung_K4B4G1646B.spd.hex M src/mainboard/google/volteer/variants/delbin/memory/Makefile.inc M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc M src/mainboard/google/volteer/variants/halvor/memory/Makefile.inc M src/mainboard/google/volteer/variants/lindar/memory/Makefile.inc M src/mainboard/google/volteer/variants/malefor/memory/Makefile.inc M src/mainboard/google/volteer/variants/terrador/memory/Makefile.inc M src/mainboard/google/volteer/variants/todor/memory/Makefile.inc M src/mainboard/google/volteer/variants/trondo/memory/Makefile.inc M src/mainboard/google/volteer/variants/volteer/memory/Makefile.inc M src/mainboard/google/volteer/variants/volteer2/memory/Makefile.inc M src/mainboard/google/volteer/variants/voxel/memory/Makefile.inc A src/mainboard/google/zork/spd/ddr4-spd-1.bin D src/mainboard/google/zork/spd/ddr4-spd-1.hex A src/mainboard/google/zork/spd/ddr4-spd-2.bin D src/mainboard/google/zork/spd/ddr4-spd-2.hex A src/mainboard/google/zork/spd/ddr4-spd-3.bin D src/mainboard/google/zork/spd/ddr4-spd-3.hex A src/mainboard/google/zork/spd/ddr4-spd-4.bin D src/mainboard/google/zork/spd/ddr4-spd-4.hex A src/mainboard/google/zork/spd/ddr4-spd-5.bin D src/mainboard/google/zork/spd/ddr4-spd-5.hex A src/mainboard/google/zork/spd/ddr4-spd-6.bin D src/mainboard/google/zork/spd/ddr4-spd-6.hex A src/mainboard/google/zork/spd/ddr4-spd-7.bin D src/mainboard/google/zork/spd/ddr4-spd-7.hex A src/mainboard/google/zork/spd/ddr4-spd-8.bin D src/mainboard/google/zork/spd/ddr4-spd-8.hex A src/mainboard/google/zork/spd/ddr4-spd-empty.bin D src/mainboard/google/zork/spd/ddr4-spd-empty.hex M src/mainboard/google/zork/spd/ddr4_spd_manifest.generated.txt M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/dalboz/spd/Makefile.inc M src/mainboard/google/zork/variants/dirinboz/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc M src/mainboard/google/zork/variants/trembyle/spd/Makefile.inc M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc M src/mainboard/google/zork/variants/woomax/spd/Makefile.inc A src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.bin D src/mainboard/hp/snb_ivb_laptops/spd/hynix_4g.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/empty.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/empty.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/samsung_ddr4_4GB.spd.hex A src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.bin D src/mainboard/intel/cannonlake_rvp/spd/samsung_lpddr4_8GB.spd.hex A src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.bin D src/mainboard/intel/harcuvar/spd/micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2.spd.hex A src/mainboard/intel/icelake_rvp/spd/empty.spd.bin D src/mainboard/intel/icelake_rvp/spd/empty.spd.hex A src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.bin D src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex A src/mainboard/intel/jasperlake_rvp/spd/empty.spd.bin D src/mainboard/intel/jasperlake_rvp/spd/empty.spd.hex A src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.bin D src/mainboard/intel/jasperlake_rvp/spd/jslrvp.spd.hex A src/mainboard/intel/kblrvp/spd/empty.spd.bin D src/mainboard/intel/kblrvp/spd/empty.spd.hex A src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.bin D src/mainboard/intel/kblrvp/spd/hynix_dimm_H9CCNNNBJTMLAR.spd.hex A src/mainboard/intel/kblrvp/spd/rvp3.spd.bin D src/mainboard/intel/kblrvp/spd/rvp3.spd.hex A src/mainboard/intel/kunimitsu/spd/empty.spd.bin D src/mainboard/intel/kunimitsu/spd/empty.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTALAR-NUD-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNN8JTBLAR-NUD-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTALAR-NUD-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/hynix_dimm_H9CCNNNBLTBLAR-NUD-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/mic_dimm_EDF8132A3MA-JD-F-1G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E6E304EE-EGCF-2G-1866.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCE.spd.hex A src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.bin D src/mainboard/intel/kunimitsu/spd/samsung_dimm_K4E8E304EE-EGCF-1G-1866.spd.hex A src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.bin D src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex A src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.bin D src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.bin D src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.hex A src/mainboard/intel/tglrvp/spd/empty.spd.bin D src/mainboard/intel/tglrvp/spd/empty.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_4gb.spd.hex A src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.bin D src/mainboard/lenovo/s230u/spd/elpida_8gb.spd.hex A src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/hynix_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/hynix_4gb.spd.hex A src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.bin D src/mainboard/lenovo/s230u/spd/samsung_2gb.spd.hex A src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.bin D src/mainboard/lenovo/s230u/spd/samsung_4gb.spd.hex M src/mainboard/lenovo/t430s/variants/t431s/spd/Makefile.inc A src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.bin D src/mainboard/lenovo/t430s/variants/t431s/spd/samsung_4gb.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.spd.hex A src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.bin D src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.spd.hex A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.bin D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex A src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.bin D src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex A src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.bin D src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex A src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.bin D src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex A src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.bin D src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex A src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.bin D src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex A src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.bin D src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.bin D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L1G32D4PG-107.spd.hex A src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.bin D src/mainboard/razer/blade_stealth_kbl/spd/micron_dimm_MT52L512M32D2PF-107.spd.hex A src/mainboard/samsung/lumpy/spd/lumpy.spd.bin D src/mainboard/samsung/lumpy/spd/lumpy.spd.hex A src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.bin D src/mainboard/system76/lemp9/spd/samsung-K4AAG165WA-BCTD.spd.hex M src/soc/amd/picasso/Makefile.inc A src/soc/intel/jasperlake/spd/lp4x-spd-1.bin D src/soc/intel/jasperlake/spd/lp4x-spd-1.hex A src/soc/intel/jasperlake/spd/lp4x-spd-2.bin D src/soc/intel/jasperlake/spd/lp4x-spd-2.hex A src/soc/intel/jasperlake/spd/lp4x-spd-3.bin D src/soc/intel/jasperlake/spd/lp4x-spd-3.hex A src/soc/intel/jasperlake/spd/lp4x-spd-4.bin D src/soc/intel/jasperlake/spd/lp4x-spd-4.hex A src/soc/intel/jasperlake/spd/lp4x-spd-5.bin D src/soc/intel/jasperlake/spd/lp4x-spd-5.hex A src/soc/intel/jasperlake/spd/lp4x-spd-6.bin D src/soc/intel/jasperlake/spd/lp4x-spd-6.hex A src/soc/intel/jasperlake/spd/lp4x-spd-7.bin D src/soc/intel/jasperlake/spd/lp4x-spd-7.hex M src/soc/intel/jasperlake/spd/lp4x_spd_manifest.generated.txt A src/soc/intel/tigerlake/spd/ddr4-spd-1.bin D src/soc/intel/tigerlake/spd/ddr4-spd-1.hex A src/soc/intel/tigerlake/spd/ddr4-spd-2.bin D src/soc/intel/tigerlake/spd/ddr4-spd-2.hex A src/soc/intel/tigerlake/spd/ddr4-spd-3.bin D src/soc/intel/tigerlake/spd/ddr4-spd-3.hex A src/soc/intel/tigerlake/spd/ddr4-spd-4.bin D src/soc/intel/tigerlake/spd/ddr4-spd-4.hex A src/soc/intel/tigerlake/spd/ddr4-spd-5.bin D src/soc/intel/tigerlake/spd/ddr4-spd-5.hex A src/soc/intel/tigerlake/spd/ddr4-spd-6.bin D src/soc/intel/tigerlake/spd/ddr4-spd-6.hex A src/soc/intel/tigerlake/spd/ddr4-spd-7.bin D src/soc/intel/tigerlake/spd/ddr4-spd-7.hex A src/soc/intel/tigerlake/spd/ddr4-spd-8.bin D src/soc/intel/tigerlake/spd/ddr4-spd-8.hex A src/soc/intel/tigerlake/spd/ddr4-spd-empty.bin D src/soc/intel/tigerlake/spd/ddr4-spd-empty.hex M src/soc/intel/tigerlake/spd/ddr4_spd_manifest.generated.txt A src/soc/intel/tigerlake/spd/lp4x-spd-1.bin D src/soc/intel/tigerlake/spd/lp4x-spd-1.hex A src/soc/intel/tigerlake/spd/lp4x-spd-2.bin D src/soc/intel/tigerlake/spd/lp4x-spd-2.hex A src/soc/intel/tigerlake/spd/lp4x-spd-3.bin D src/soc/intel/tigerlake/spd/lp4x-spd-3.hex A src/soc/intel/tigerlake/spd/lp4x-spd-4.bin D src/soc/intel/tigerlake/spd/lp4x-spd-4.hex A src/soc/intel/tigerlake/spd/lp4x-spd-5.bin D src/soc/intel/tigerlake/spd/lp4x-spd-5.hex M src/soc/intel/tigerlake/spd/lp4x_spd_manifest.generated.txt 637 files changed, 185 insertions(+), 10,844 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/44775/27 -- To view, visit https://review.coreboot.org/c/coreboot/+/44775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 Gerrit-Change-Number: 44775 Gerrit-PatchSet: 27 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer: Fix GPP_E12 definition
by Tim Wawrzynczak (Code Review) 09 Sep '20

09 Sep '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45197 ) Change subject: mb/google/volteer: Fix GPP_E12 definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3ef864827aa94b0b96e335565119f3d5d008837 Gerrit-Change-Number: 45197 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:39:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide: stop using hexdumps for SPD files
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44775 ) Change subject: treewide: stop using hexdumps for SPD files ...................................................................... Patch Set 26: > Patch Set 25: > > > Patch Set 25: > > > > > Patch Set 25: Code-Review-1 > > > > > > This will make it significantly harder to edit and read the SPD files in the tree. > > > > The hex-to-bin handling has been a mess. we might be better off building an SPD editor (in golang? ;-) ) and stop pretending that this stuff is source. > > How about bincfg? we already have DDR3 and DDR4 spec files. > Patch Set 25: > > We have util/bincfg in the tree for exactly stuff like this. I have been told, that bincfg does not support checksums -- To view, visit https://review.coreboot.org/c/coreboot/+/44775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 Gerrit-Change-Number: 44775 Gerrit-PatchSet: 26 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:20:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/Makefile.inc: fail build when SPD would be empty
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45131 ) Change subject: lib/Makefile.inc: fail build when SPD would be empty ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/45131/10/src/lib/Makefile.inc File src/lib/Makefile.inc: https://review.coreboot.org/c/coreboot/+/45131/10/src/lib/Makefile.inc@364 PS10, Line 364: GENERIC_SPD_BIN > HAVE_SPD_BIN_IN_CBFS 😉 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/45131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6db1dbe5fed5f242e408bcad4f36dda1b1fa1b4 Gerrit-Change-Number: 45131 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/Makefile.inc: fail build when SPD would be empty
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Hello Felix Singer, build bot (Jenkins), David Wu, Aaron Durbin, Furquan Shaikh, Patrick Georgi, Paul Menzel, Angel Pons, Aaron Durbin, Nico Huber, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45131 to look at the new patch set (#11). Change subject: lib/Makefile.inc: fail build when SPD would be empty ...................................................................... lib/Makefile.inc: fail build when SPD would be empty Add a check to be sure that at least one SPD file will be added and fail the build when the resulting spd.bin would be empty. Change-Id: Ic6db1dbe5fed5f242e408bcad4f36dda1b1fa1b4 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/lib/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/45131/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/45131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6db1dbe5fed5f242e408bcad4f36dda1b1fa1b4 Gerrit-Change-Number: 45131 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: treewide: stop using hexdumps for SPD files
by Martin Roth (Code Review) 09 Sep '20

09 Sep '20

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44775 ) Change subject: treewide: stop using hexdumps for SPD files ...................................................................... Patch Set 25: > Patch Set 25: > I brought [bincfg] up early in the discussion of this effort. The main counterargument was that just throwing binary files around is dead simple (and won't fail with vendors adding some custom flags somewhere or whatever). > > We could document a workflow with bincfg to edit the binaries, though. > > I guess this boils down to: should we get the binary representation in (and do whatever is necessary to make editing a painless experience, better than it is now) or do we need to investigate a text format we want to use (bincfg or anything else) as part of the build process? I'd vote for not checking binaries into the coreboot source tree at all. Personally, I'd like to get rid of the vbt binaries and have a tool to compile them as well. My understanding was that there wasn't documentation for the VBT fields, but it seems that maybe this is no longer the case. [1] I agree that distributing binaries is much easier than text, which is why we deal with so many blobs. We have a make process to build the coreboot source, so let's just continue using it. As far as vendors adding custom flags, I don't see how binary vs text solves any problem there. [1]: https://github.com/ZoranStojsavljevic/Video-BIOS-Table-parser-assembler -- To view, visit https://review.coreboot.org/c/coreboot/+/44775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91 Gerrit-Change-Number: 44775 Gerrit-PatchSet: 25 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:13:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add missing special function pads for CNL-H
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45204 ) Change subject: util/inteltool: add missing special function pads for CNL-H ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/45204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib83aeef9f4b6aa174e61ccbd87fb7b6450ed773b Gerrit-Change-Number: 45204 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:03:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add missing native functions of special pads for CNL-H
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45203 ) Change subject: util/inteltool: add missing native functions of special pads for CNL-H ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/45203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71339d66362d29806c91375c214e9fb84c989201 Gerrit-Change-Number: 45203 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: rename GPIO_RSVD_* to their correct names for CNL-H
by Michael Niewöhner (Code Review) 09 Sep '20

09 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45202 ) Change subject: util/inteltool: rename GPIO_RSVD_* to their correct names for CNL-H ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/45202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6cabb646000c8dff695c5c4f7196b2779f1430 Gerrit-Change-Number: 45202 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 09 Sep 2020 18:03:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020