Marc Jones has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/22575 )
Change subject: lib/spd_bin: Only build when CONFIG option is set
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/22575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a4d810199c96912d13737046e6041b74315164
Gerrit-Change-Number: 22575
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: trogdor: SoC makefile blob support
......................................................................
Patch Set 93:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35508/76//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35508/76//COMMIT_MSG@7
PS76, Line 7: HACK trogdor: SoC makefile BLOB support HACK
> Please make it a statement by adding a verb (in imperative mood).
That's not a strict requirement, I think this subject is fine for a patch like this.
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/M…
File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/M…
PS15, Line 102: DCB_FILE := $(SC7180_BLOB)/600E_0100_1_1_dcb.bin
> Sorry, I don't understand what you mean here? QcLib doesn't ever get to see this filename, all it ge […]
Done
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/M…
File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/M…
PS78, Line 79: SC7180_BLOB := $(top)/3rdparty/blobs/soc/qualcomm/sc7180
> Now that CB:42548 has landed, please rewrite this to access $(top)/3rdparty/qc_blobs instead and tak […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/35508
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1
Gerrit-Change-Number: 35508
Gerrit-PatchSet: 93
Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: ashk(a)codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Saurabh Gorecha <sgorecha(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 09 Sep 2020 22:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45200 )
Change subject: util/inteltool: rename GPIO_RSVD_* to their correct names for CNL-LP
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/45200
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86c7159d9f48560c41efdfe49f162aef00499d13
Gerrit-Change-Number: 45200
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 09 Sep 2020 20:51:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment