Change in coreboot[master]: sc7180: GPIO: Add I2S configuration for google/trogdor

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

15 May 2020 15 May '20

4:54 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: Add I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41428/1

diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index c82eaa0..5081db9 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -19,13 +19,13 @@ {

gpio_configure(GPIO(49), GPIO49_FUNC_MI2S_1_SCK, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT);

gpio_configure(GPIO(50), GPIO50_FUNC_MI2S_1_WS, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT);

gpio_configure(GPIO(51), GPIO51_FUNC_MI2S_1_DATA0, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT); }

static void load_qup_fw(void)

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Ravi kumar (Code Review)

15 May 15 May

6:34 p.m.

New subject: Change in coreboot[master]: sc7180: GPIO: I2S configuration for google/trogdor

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41428

to look at the new patch set (#2).

Change subject: sc7180: GPIO: I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Signed-off-by: V Sujith Kumar Reddy vsujithk@codeaurora.org --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41428/2

Julius Werner (Code Review)

9:25 p.m.

New subject: Change in coreboot[master]: sc7180: GPIO: I2S configuration for google/trogdor

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: I2S configuration for google/trogdor ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG@12 PS2, Line 12: layout was changed. I'm confused, does this commit message actually have anything to do with the patch? I mean the patch is fine, I wanted the pull to be changed, but that's not what makes it break on rev1 right? And the bug below was mostly about adjusting the volume in depthcharge, not the GPIO config here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Fri, 15 May 2020 21:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ajit Pandey (Code Review)

18 May 18 May

10:56 a.m.

New subject: Change in coreboot[master]: sc7180: GPIO: I2S configuration for google/trogdor

Ajit Pandey has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: I2S configuration for google/trogdor ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG@12 PS2, Line 12: layout was changed.

...

I'm confused, does this commit message actually have anything to do with the patch? I mean the patch […]

yes Julius you are right,To Say that Total Functionality of beep sound works only after the Maximum codec hardware change.so mentioned that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 18 May 2020 10:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Manideep Kurumella (Code Review)

21 May 21 May

6:28 p.m.

Manideep Kurumella has uploaded a new patch set (#3) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: Add I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41428/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

10 Jun 10 Jun

5:19 p.m.

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41428

to look at the new patch set (#7).

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: Add I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41428/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 7 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

6 Jul 6 Jul

11:56 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41428/12//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41428/12//COMMIT_MSG@16 PS12, Line 16: This needs a Signed-off-by line. (You can see that by clicking on the https://qa.coreboot.org/job/coreboot-gerrit/133372/ link posted by Jenkins. Please try to resolve CI issues on your own and let me know if you need help with a specific one.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 12 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 06 Jul 2020 23:56:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi kumar (Code Review)

9 Jul 9 Jul

12:03 p.m.

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41428

to look at the new patch set (#13).

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: Add I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Signed-off-by: vsujithk vsujithk@codeaurora.org --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/41428/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 13 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Ajit Pandey (Code Review)

1:12 p.m.

Ajit Pandey has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41428/12//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41428/12//COMMIT_MSG@16 PS12, Line 16:

...

This needs a Signed-off-by line. (You can see that by clicking on the https://qa.coreboot. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 13 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 09 Jul 2020 13:12:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Julius Werner (Code Review)

22 Jul 22 Jul

1:12 a.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 14 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Wed, 22 Jul 2020 01:12:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

9 Sep 9 Sep

10:08 p.m.

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

sc7180: GPIO: Add I2S configuration for google/trogdor

Configure GPIO pins as I2S mode for audio speaker.

The audio speaker does not work on Trogdor revision 1, as the layout was changed.

Developer/Reviewer reference, be aware of this issue: https://partnerissuetracker.corp.google.com/issues/146533652

Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Signed-off-by: vsujithk vsujithk@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/41428 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/trogdor/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index 4d6e352..349c306 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -22,13 +22,13 @@ {

gpio_configure(GPIO(49), GPIO49_FUNC_MI2S_1_SCK, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT);

gpio_configure(GPIO(50), GPIO50_FUNC_MI2S_1_WS, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT);

gpio_configure(GPIO(51), GPIO51_FUNC_MI2S_1_DATA0, - GPIO_PULL_UP, GPIO_8MA, GPIO_OUTPUT); + GPIO_NO_PULL, GPIO_8MA, GPIO_OUTPUT); }

static void load_qup_fw(void)

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 24 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

9elements QA (Code Review)

10:58 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )

Change subject: sc7180: GPIO: Add I2S configuration for google/trogdor ......................................................................

Patch Set 24:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18515 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18514 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18513 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18512 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18511 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18518 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18517 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18516

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3 Gerrit-Change-Number: 41428 Gerrit-PatchSet: 24 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Ajit Pandey c_ajitp@qualcomm.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Sep 2020 22:58:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1331

days inactive

1448

days old

coreboot-gerrit@coreboot.org

11 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Ajit Pandey (Code Review)
Julius Werner (Code Review)
Manideep Kurumella (Code Review)
Ravi kumar (Code Review)