Ajit Pandey has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41428 )
Change subject: sc7180: GPIO: I2S configuration for google/trogdor
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41428/2//COMMIT_MSG@12
PS2, Line 12: layout was changed.
I'm confused, does this commit message actually have anything to do with the patch? I mean the patch […]
yes Julius you are right,To Say that Total Functionality of beep sound works only after the Maximum codec hardware change.so mentioned that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4bbfea591a3231640b53e64f0e4e9d43c4437a3
Gerrit-Change-Number: 41428
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ajit Pandey
c_ajitp@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 18 May 2020 10:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment