Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: trogdor: SoC makefile blob support ......................................................................
Patch Set 93:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35508/76//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35508/76//COMMIT_MSG@7 PS76, Line 7: HACK trogdor: SoC makefile BLOB support HACK
Please make it a statement by adding a verb (in imperative mood).
That's not a strict requirement, I think this subject is fine for a patch like this.
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma... PS15, Line 102: DCB_FILE := $(SC7180_BLOB)/600E_0100_1_1_dcb.bin
Sorry, I don't understand what you mean here? QcLib doesn't ever get to see this filename, all it ge […]
Done
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/Ma... PS78, Line 79: SC7180_BLOB := $(top)/3rdparty/blobs/soc/qualcomm/sc7180
Now that CB:42548 has landed, please rewrite this to access $(top)/3rdparty/qc_blobs instead and tak […]
Done