Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44775 )
Change subject: treewide: stop using hexdumps for SPD files
......................................................................
Patch Set 25:
Patch Set 25:
I brought [bincfg] up early in the discussion of this effort. The main counterargument was that just throwing binary files around is dead simple (and won't fail with vendors adding some custom flags somewhere or whatever).
We could document a workflow with bincfg to edit the binaries, though.
I guess this boils down to: should we get the binary representation in (and do whatever is necessary to make editing a painless experience, better than it is now) or do we need to investigate a text format we want to use (bincfg or anything else) as part of the build process?
I'd vote for not checking binaries into the coreboot source tree at all. Personally, I'd like to get rid of the vbt binaries and have a tool to compile them as well. My understanding was that there wasn't documentation for the VBT fields, but it seems that maybe this is no longer the case. [1]
I agree that distributing binaries is much easier than text, which is why we deal with so many blobs. We have a make process to build the coreboot source, so let's just continue using it.
As far as vendors adding custom flags, I don't see how binary vs text solves any problem there.
[1]: https://github.com/ZoranStojsavljevic/Video-BIOS-Table-parser-assembler
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f24183a872924cddcfdf7587cc0c126da900f91
Gerrit-Change-Number: 44775
Gerrit-PatchSet: 25
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Wed, 09 Sep 2020 18:13:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment