Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45146 )
Change subject: mb/*: drop GENERIC_SPD_BIN from boards without soldered memory
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarien...
File src/mainboard/google/sarien/Kconfig:
https://review.coreboot.org/c/coreboot/+/45146/2/src/mainboard/google/sarien...
PS2, Line 12: select GENERIC_SPD_BIN
Seems to be correct, since this is mutually exclusive with SPD_READ_BY_WORD. […]
Correct, sarien has DIMM slots.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id05fe45007d5662ff9bee326f28470df1206fcff
Gerrit-Change-Number: 45146
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Sep 2020 16:21:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment