Change in coreboot[master]: driver/intel/mipi_camera: Add compatible field for nvm

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45161 )

Change subject: driver/intel/mipi_camera: Add compatible field for nvm
......................................................................

driver/intel/mipi_camera: Add compatible field for nvm

BUG=none
TEST=emerge-dedede coreboot

Signed-off-by: Wisley Chen 
Change-Id: I7993c4665c6afdd71721bdea840a535a5b03d654
---
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/mipi_camera/chip.h
2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/45161/1

diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 6f237a9..ea992a1 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -454,6 +454,9 @@
    struct drivers_intel_mipi_camera_config *config = dev->chip_info;
    struct acpi_dp *dsd = acpi_dp_new_table("_DSD");

+	if (!config->nvm_compat)
+		return;
+
    /* It might be possible to default size or width based on type. */
    if (!config->disable_nvm_defaults && !config->nvm_pagesize)
    	config->nvm_pagesize = 1;
@@ -473,6 +476,7 @@
    if (config->nvm_width)
    	acpi_dp_add_integer(dsd, "address-width", config->nvm_width);

+	acpi_dp_add_string(dsd, "compatible", config->nvm_compat);
    acpi_dp_write(dsd);
 }

diff --git a/src/drivers/intel/mipi_camera/chip.h b/src/drivers/intel/mipi_camera/chip.h
index d91e1e7..28f8464 100644
--- a/src/drivers/intel/mipi_camera/chip.h
+++ b/src/drivers/intel/mipi_camera/chip.h
@@ -241,6 +241,7 @@
    uint32_t nvm_pagesize;
    uint32_t nvm_readonly;
    uint32_t nvm_width;
+	const char *nvm_compat;

/* Settings specific to vcm */
    const char *vcm_compat;

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45161 )

Change subject: driver/intel/mipi_camera: Add compatible field for nvm
......................................................................

Patch Set 1: Code-Review+1

[Andy Yeh (Code Review)]

Andy Yeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45161 )

Change subject: driver/intel/mipi_camera: Add compatible field for nvm
......................................................................

Patch Set 1: Code-Review+1

[Chen Wisley (Code Review)]

Chen Wisley has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45161 )

Change subject: driver/intel/mipi_camera: Add compatible field for nvm
......................................................................

Abandoned

Due to no need nvm_compat in CB:44939