Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45131 )
Change subject: lib/Makefile.inc: fail build when SPD would be empty
......................................................................
Patch Set 8:
> Patch Set 8:
>
> > Patch Set 6:
> >
> > > Patch Set 6:
> > >
> > > > Patch Set 6:
> > > >
> > > > Does anyone know which kind of memory (slotted or memory-down) Google Sushi and Google Trondo use?
> > >
> > > Sushi was a test platform, and won't actually be built. But if you need to specify something, then memory-down.
> >
> > Right, thanks for the insight. If Sushi won't actually be built, we might as well drop it then? Treating it like a memory-down platform would require adding an invalid SPD binary to it, which wouldn't work.
>
> I'll look at what's involved besides just removing it from coreboot.
https://review.coreboot.org/c/coreboot/+/45175
--
To view, visit https://review.coreboot.org/c/coreboot/+/45131
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6db1dbe5fed5f242e408bcad4f36dda1b1fa1b4
Gerrit-Change-Number: 45131
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 08 Sep 2020 17:01:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment